* [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder
@ 2024-04-04 18:23 Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 1/4] ACPI: x86: Introduce a Makefile Andy Shevchenko
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Andy Shevchenko @ 2024-04-04 18:23 UTC (permalink / raw)
To: Zhang Rui, Andy Shevchenko, Rafael J. Wysocki, linux-kernel,
linux-acpi
Cc: Rafael J. Wysocki, Len Brown
Move x86 related modules (which are solely for x86) to the dedicated
folder.
Note, there are more modules, but they are related to tables and
potentially might be used for other architectures in the future.
Hence touched only non-table related code.
In v2:
- fixed acpi_lpss_init() stub visibility (LKP)
Andy Shevchenko (4):
ACPI: x86: Introduce a Makefile
ACPI: x86: Move acpi_cmos_rtc to x86 folder
ACPI: x86: Move blacklist to x86 folder
ACPI: x86: Move LPSS to x86 folder
drivers/acpi/Makefile | 7 +------
drivers/acpi/internal.h | 3 ++-
drivers/acpi/x86/Makefile | 8 ++++++++
drivers/acpi/{ => x86}/blacklist.c | 2 +-
drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} | 2 +-
drivers/acpi/{acpi_lpss.c => x86/lpss.c} | 2 +-
6 files changed, 14 insertions(+), 10 deletions(-)
create mode 100644 drivers/acpi/x86/Makefile
rename drivers/acpi/{ => x86}/blacklist.c (99%)
rename drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} (98%)
rename drivers/acpi/{acpi_lpss.c => x86/lpss.c} (99%)
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v2 1/4] ACPI: x86: Introduce a Makefile
2024-04-04 18:23 [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Andy Shevchenko
@ 2024-04-04 18:23 ` Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 2/4] ACPI: x86: Move acpi_cmos_rtc to x86 folder Andy Shevchenko
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2024-04-04 18:23 UTC (permalink / raw)
To: Zhang Rui, Andy Shevchenko, Rafael J. Wysocki, linux-kernel,
linux-acpi
Cc: Rafael J. Wysocki, Len Brown
There will be more modules coming here, so, introduce a separate
Makefile and include it in parent one via obj-$(CONFIG_X86).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/Makefile | 4 +---
drivers/acpi/x86/Makefile | 4 ++++
2 files changed, 5 insertions(+), 3 deletions(-)
create mode 100644 drivers/acpi/x86/Makefile
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index d69d5444acdb..0db88aab309f 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -56,9 +56,6 @@ acpi-y += evged.o
acpi-y += sysfs.o
acpi-y += property.o
acpi-$(CONFIG_X86) += acpi_cmos_rtc.o
-acpi-$(CONFIG_X86) += x86/apple.o
-acpi-$(CONFIG_X86) += x86/utils.o
-acpi-$(CONFIG_X86) += x86/s2idle.o
acpi-$(CONFIG_DEBUG_FS) += debugfs.o
acpi-y += acpi_lpat.o
acpi-$(CONFIG_ACPI_FPDT) += acpi_fpdt.o
@@ -133,3 +130,4 @@ obj-$(CONFIG_ARM64) += arm64/
obj-$(CONFIG_ACPI_VIOT) += viot.o
obj-$(CONFIG_RISCV) += riscv/
+obj-$(CONFIG_X86) += x86/
diff --git a/drivers/acpi/x86/Makefile b/drivers/acpi/x86/Makefile
new file mode 100644
index 000000000000..bd17dd2c2c5b
--- /dev/null
+++ b/drivers/acpi/x86/Makefile
@@ -0,0 +1,4 @@
+obj-$(CONFIG_ACPI) += acpi-x86.o
+acpi-x86-y += apple.o
+acpi-x86-y += s2idle.o
+acpi-x86-y += utils.o
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 2/4] ACPI: x86: Move acpi_cmos_rtc to x86 folder
2024-04-04 18:23 [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 1/4] ACPI: x86: Introduce a Makefile Andy Shevchenko
@ 2024-04-04 18:23 ` Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 3/4] ACPI: x86: Move blacklist " Andy Shevchenko
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2024-04-04 18:23 UTC (permalink / raw)
To: Zhang Rui, Andy Shevchenko, Rafael J. Wysocki, linux-kernel,
linux-acpi
Cc: Rafael J. Wysocki, Len Brown
acpi_cmos_rtc is built solely for x86, move it to the respective folder.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/Makefile | 1 -
drivers/acpi/x86/Makefile | 1 +
drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} | 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
rename drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} (98%)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 0db88aab309f..413c18e2bf61 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -55,7 +55,6 @@ acpi-y += event.o
acpi-y += evged.o
acpi-y += sysfs.o
acpi-y += property.o
-acpi-$(CONFIG_X86) += acpi_cmos_rtc.o
acpi-$(CONFIG_DEBUG_FS) += debugfs.o
acpi-y += acpi_lpat.o
acpi-$(CONFIG_ACPI_FPDT) += acpi_fpdt.o
diff --git a/drivers/acpi/x86/Makefile b/drivers/acpi/x86/Makefile
index bd17dd2c2c5b..b97b1bcf8404 100644
--- a/drivers/acpi/x86/Makefile
+++ b/drivers/acpi/x86/Makefile
@@ -1,4 +1,5 @@
obj-$(CONFIG_ACPI) += acpi-x86.o
acpi-x86-y += apple.o
+acpi-x86-y += cmos_rtc.o
acpi-x86-y += s2idle.o
acpi-x86-y += utils.o
diff --git a/drivers/acpi/acpi_cmos_rtc.c b/drivers/acpi/x86/cmos_rtc.c
similarity index 98%
rename from drivers/acpi/acpi_cmos_rtc.c
rename to drivers/acpi/x86/cmos_rtc.c
index 9b55d1593d16..51643ff6fe5f 100644
--- a/drivers/acpi/acpi_cmos_rtc.c
+++ b/drivers/acpi/x86/cmos_rtc.c
@@ -15,7 +15,7 @@
#include <linux/module.h>
#include <linux/mc146818rtc.h>
-#include "internal.h"
+#include "../internal.h"
static const struct acpi_device_id acpi_cmos_rtc_ids[] = {
{ "PNP0B00" },
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 3/4] ACPI: x86: Move blacklist to x86 folder
2024-04-04 18:23 [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 1/4] ACPI: x86: Introduce a Makefile Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 2/4] ACPI: x86: Move acpi_cmos_rtc to x86 folder Andy Shevchenko
@ 2024-04-04 18:23 ` Andy Shevchenko
2024-04-05 14:44 ` Kuppuswamy Sathyanarayanan
2024-04-04 18:23 ` [PATCH v2 4/4] ACPI: x86: Move LPSS " Andy Shevchenko
2024-04-05 14:45 ` [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Kuppuswamy Sathyanarayanan
4 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2024-04-04 18:23 UTC (permalink / raw)
To: Zhang Rui, Andy Shevchenko, Rafael J. Wysocki, linux-kernel,
linux-acpi
Cc: Rafael J. Wysocki, Len Brown
blacklist is built solely for x86, move it to the respective folder.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/Makefile | 1 -
drivers/acpi/x86/Makefile | 2 ++
drivers/acpi/{ => x86}/blacklist.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
rename drivers/acpi/{ => x86}/blacklist.c (99%)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 413c18e2bf61..6f4187a34f41 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -14,7 +14,6 @@ tables.o: $(src)/../../include/$(CONFIG_ACPI_CUSTOM_DSDT_FILE) ;
endif
obj-$(CONFIG_ACPI) += tables.o
-obj-$(CONFIG_X86) += blacklist.o
#
# ACPI Core Subsystem (Interpreter)
diff --git a/drivers/acpi/x86/Makefile b/drivers/acpi/x86/Makefile
index b97b1bcf8404..1f3c5fa84f9e 100644
--- a/drivers/acpi/x86/Makefile
+++ b/drivers/acpi/x86/Makefile
@@ -3,3 +3,5 @@ acpi-x86-y += apple.o
acpi-x86-y += cmos_rtc.o
acpi-x86-y += s2idle.o
acpi-x86-y += utils.o
+
+obj-$(CONFIG_X86) += blacklist.o
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/x86/blacklist.c
similarity index 99%
rename from drivers/acpi/blacklist.c
rename to drivers/acpi/x86/blacklist.c
index a558d24fb788..55214d0a12b1 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/x86/blacklist.c
@@ -17,7 +17,7 @@
#include <linux/acpi.h>
#include <linux/dmi.h>
-#include "internal.h"
+#include "../internal.h"
#ifdef CONFIG_DMI
static const struct dmi_system_id acpi_rev_dmi_table[] __initconst;
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 3/4] ACPI: x86: Move blacklist to x86 folder
2024-04-04 18:23 ` [PATCH v2 3/4] ACPI: x86: Move blacklist " Andy Shevchenko
@ 2024-04-05 14:44 ` Kuppuswamy Sathyanarayanan
2024-04-05 15:19 ` Andy Shevchenko
0 siblings, 1 reply; 11+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2024-04-05 14:44 UTC (permalink / raw)
To: Andy Shevchenko, Zhang Rui, Rafael J. Wysocki, linux-kernel,
linux-acpi
Cc: Rafael J. Wysocki, Len Brown
On 4/4/24 11:23 AM, Andy Shevchenko wrote:
> blacklist is built solely for x86, move it to the respective folder.
Don't you need #ifdef CONFIG_X86 for acpi_blacklisted() in
include/linux/acpi.h
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/Makefile | 1 -
> drivers/acpi/x86/Makefile | 2 ++
> drivers/acpi/{ => x86}/blacklist.c | 2 +-
> 3 files changed, 3 insertions(+), 2 deletions(-)
> rename drivers/acpi/{ => x86}/blacklist.c (99%)
>
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 413c18e2bf61..6f4187a34f41 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -14,7 +14,6 @@ tables.o: $(src)/../../include/$(CONFIG_ACPI_CUSTOM_DSDT_FILE) ;
> endif
>
> obj-$(CONFIG_ACPI) += tables.o
> -obj-$(CONFIG_X86) += blacklist.o
>
> #
> # ACPI Core Subsystem (Interpreter)
> diff --git a/drivers/acpi/x86/Makefile b/drivers/acpi/x86/Makefile
> index b97b1bcf8404..1f3c5fa84f9e 100644
> --- a/drivers/acpi/x86/Makefile
> +++ b/drivers/acpi/x86/Makefile
> @@ -3,3 +3,5 @@ acpi-x86-y += apple.o
> acpi-x86-y += cmos_rtc.o
> acpi-x86-y += s2idle.o
> acpi-x86-y += utils.o
> +
> +obj-$(CONFIG_X86) += blacklist.o
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/x86/blacklist.c
> similarity index 99%
> rename from drivers/acpi/blacklist.c
> rename to drivers/acpi/x86/blacklist.c
> index a558d24fb788..55214d0a12b1 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/x86/blacklist.c
> @@ -17,7 +17,7 @@
> #include <linux/acpi.h>
> #include <linux/dmi.h>
>
> -#include "internal.h"
> +#include "../internal.h"
>
> #ifdef CONFIG_DMI
> static const struct dmi_system_id acpi_rev_dmi_table[] __initconst;
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 3/4] ACPI: x86: Move blacklist to x86 folder
2024-04-05 14:44 ` Kuppuswamy Sathyanarayanan
@ 2024-04-05 15:19 ` Andy Shevchenko
2024-04-05 15:29 ` Kuppuswamy Sathyanarayanan
0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2024-04-05 15:19 UTC (permalink / raw)
To: Kuppuswamy Sathyanarayanan
Cc: Zhang Rui, Rafael J. Wysocki, linux-kernel, linux-acpi,
Rafael J. Wysocki, Len Brown
On Fri, Apr 05, 2024 at 07:44:15AM -0700, Kuppuswamy Sathyanarayanan wrote:
>
> On 4/4/24 11:23 AM, Andy Shevchenko wrote:
> > blacklist is built solely for x86, move it to the respective folder.
>
> Don't you need #ifdef CONFIG_X86 for acpi_blacklisted() in
> include/linux/acpi.h
It's unrelated to this series.
It was like that before and this series doesn't change this aspect.
AFAICS the API is called from x86 only, that's why it's not a problem,
but strictly speaking you are right. Feel free to submit a patch.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/4] ACPI: x86: Move blacklist to x86 folder
2024-04-05 15:19 ` Andy Shevchenko
@ 2024-04-05 15:29 ` Kuppuswamy Sathyanarayanan
0 siblings, 0 replies; 11+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2024-04-05 15:29 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Zhang Rui, Rafael J. Wysocki, linux-kernel, linux-acpi,
Rafael J. Wysocki, Len Brown
On 4/5/24 8:19 AM, Andy Shevchenko wrote:
> On Fri, Apr 05, 2024 at 07:44:15AM -0700, Kuppuswamy Sathyanarayanan wrote:
>> On 4/4/24 11:23 AM, Andy Shevchenko wrote:
>>> blacklist is built solely for x86, move it to the respective folder.
>> Don't you need #ifdef CONFIG_X86 for acpi_blacklisted() in
>> include/linux/acpi.h
> It's unrelated to this series.
> It was like that before and this series doesn't change this aspect.
>
> AFAICS the API is called from x86 only, that's why it's not a problem,
> but strictly speaking you are right. Feel free to submit a patch.
>
Agree.
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 4/4] ACPI: x86: Move LPSS to x86 folder
2024-04-04 18:23 [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Andy Shevchenko
` (2 preceding siblings ...)
2024-04-04 18:23 ` [PATCH v2 3/4] ACPI: x86: Move blacklist " Andy Shevchenko
@ 2024-04-04 18:23 ` Andy Shevchenko
2024-04-05 14:45 ` [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Kuppuswamy Sathyanarayanan
4 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2024-04-04 18:23 UTC (permalink / raw)
To: Zhang Rui, Andy Shevchenko, Rafael J. Wysocki, linux-kernel,
linux-acpi
Cc: Rafael J. Wysocki, Len Brown
LPSS is built solely for x86, move it to the respective folder.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/Makefile | 1 -
drivers/acpi/internal.h | 3 ++-
drivers/acpi/x86/Makefile | 1 +
drivers/acpi/{acpi_lpss.c => x86/lpss.c} | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
rename drivers/acpi/{acpi_lpss.c => x86/lpss.c} (99%)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 6f4187a34f41..39ea5cfa8326 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -45,7 +45,6 @@ acpi-y += ec.o
acpi-$(CONFIG_ACPI_DOCK) += dock.o
acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o
obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o
-acpi-$(CONFIG_PCI) += acpi_lpss.o
acpi-y += acpi_apd.o
acpi-y += acpi_platform.o
acpi-y += acpi_pnp.o
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index ca72a0dc5715..60c483836756 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -69,7 +69,8 @@ void acpi_debugfs_init(void);
#else
static inline void acpi_debugfs_init(void) { return; }
#endif
-#ifdef CONFIG_PCI
+
+#if defined(CONFIG_X86) && defined(CONFIG_PCI)
void acpi_lpss_init(void);
#else
static inline void acpi_lpss_init(void) {}
diff --git a/drivers/acpi/x86/Makefile b/drivers/acpi/x86/Makefile
index 1f3c5fa84f9e..63c99509ed9d 100644
--- a/drivers/acpi/x86/Makefile
+++ b/drivers/acpi/x86/Makefile
@@ -1,6 +1,7 @@
obj-$(CONFIG_ACPI) += acpi-x86.o
acpi-x86-y += apple.o
acpi-x86-y += cmos_rtc.o
+acpi-x86-$(CONFIG_PCI) += lpss.o
acpi-x86-y += s2idle.o
acpi-x86-y += utils.o
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/x86/lpss.c
similarity index 99%
rename from drivers/acpi/acpi_lpss.c
rename to drivers/acpi/x86/lpss.c
index a3d2d94be5c0..148e29c2c526 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/x86/lpss.c
@@ -25,7 +25,7 @@
#include <linux/suspend.h>
#include <linux/delay.h>
-#include "internal.h"
+#include "../internal.h"
#ifdef CONFIG_X86_INTEL_LPSS
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder
2024-04-04 18:23 [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Andy Shevchenko
` (3 preceding siblings ...)
2024-04-04 18:23 ` [PATCH v2 4/4] ACPI: x86: Move LPSS " Andy Shevchenko
@ 2024-04-05 14:45 ` Kuppuswamy Sathyanarayanan
2024-04-05 15:20 ` Andy Shevchenko
4 siblings, 1 reply; 11+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2024-04-05 14:45 UTC (permalink / raw)
To: Andy Shevchenko, Zhang Rui, Rafael J. Wysocki, linux-kernel,
linux-acpi
Cc: Rafael J. Wysocki, Len Brown
On 4/4/24 11:23 AM, Andy Shevchenko wrote:
> Move x86 related modules (which are solely for x86) to the dedicated
> folder.
> Note, there are more modules, but they are related to tables and
> potentially might be used for other architectures in the future.
> Hence touched only non-table related code.
Except the blacklisted patch Nit, rest looks good to me.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> In v2:
> - fixed acpi_lpss_init() stub visibility (LKP)
>
> Andy Shevchenko (4):
> ACPI: x86: Introduce a Makefile
> ACPI: x86: Move acpi_cmos_rtc to x86 folder
> ACPI: x86: Move blacklist to x86 folder
> ACPI: x86: Move LPSS to x86 folder
>
> drivers/acpi/Makefile | 7 +------
> drivers/acpi/internal.h | 3 ++-
> drivers/acpi/x86/Makefile | 8 ++++++++
> drivers/acpi/{ => x86}/blacklist.c | 2 +-
> drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} | 2 +-
> drivers/acpi/{acpi_lpss.c => x86/lpss.c} | 2 +-
> 6 files changed, 14 insertions(+), 10 deletions(-)
> create mode 100644 drivers/acpi/x86/Makefile
> rename drivers/acpi/{ => x86}/blacklist.c (99%)
> rename drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} (98%)
> rename drivers/acpi/{acpi_lpss.c => x86/lpss.c} (99%)
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder
2024-04-05 14:45 ` [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Kuppuswamy Sathyanarayanan
@ 2024-04-05 15:20 ` Andy Shevchenko
0 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2024-04-05 15:20 UTC (permalink / raw)
To: Kuppuswamy Sathyanarayanan
Cc: Zhang Rui, Rafael J. Wysocki, linux-kernel, linux-acpi,
Rafael J. Wysocki, Len Brown
On Fri, Apr 05, 2024 at 07:45:29AM -0700, Kuppuswamy Sathyanarayanan wrote:
>
> On 4/4/24 11:23 AM, Andy Shevchenko wrote:
> > Move x86 related modules (which are solely for x86) to the dedicated
> > folder.
> > Note, there are more modules, but they are related to tables and
> > potentially might be used for other architectures in the future.
> > Hence touched only non-table related code.
>
> Except the blacklisted patch Nit, rest looks good to me.
Not sure how that related (see my reply).
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 4/4] ACPI: x86: Move LPSS to x86 folder
@ 2024-04-08 18:33 kernel test robot
0 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2024-04-08 18:33 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240404183448.3310449-5-andriy.shevchenko@linux.intel.com>
References: <20240404183448.3310449-5-andriy.shevchenko@linux.intel.com>
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
TO: Zhang Rui <rui.zhang@intel.com>
TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
TO: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
TO: linux-kernel@vger.kernel.org
TO: linux-acpi@vger.kernel.org
CC: Len Brown <lenb@kernel.org>
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/acpi-bus linus/master v6.9-rc3 next-20240408]
[cannot apply to rafael-pm/devprop]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ACPI-x86-Introduce-a-Makefile/20240405-023649
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240404183448.3310449-5-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v2 4/4] ACPI: x86: Move LPSS to x86 folder
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: i386-randconfig-141-20240408 (https://download.01.org/0day-ci/archive/20240409/202404090234.ZGYcaqJz-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202404090234.ZGYcaqJz-lkp@intel.com/
smatch warnings:
drivers/acpi/x86/lpss.c:677 acpi_lpss_create_device() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +677 drivers/acpi/x86/lpss.c
e6ce0ce34f65779 drivers/acpi/acpi_lpss.c Adrian Hunter 2017-12-15 613
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 614 static int acpi_lpss_create_device(struct acpi_device *adev,
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 615 const struct acpi_device_id *id)
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 616 {
b2687cd7d5fd739 drivers/acpi/acpi_lpss.c Mathias Krause 2015-06-13 617 const struct lpss_device_desc *dev_desc;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 618 struct lpss_private_data *pdata;
90e97820619dc91 drivers/acpi/acpi_lpss.c Jiang Liu 2015-02-05 619 struct resource_entry *rentry;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 620 struct list_head resource_list;
8ce62f85a81f57e drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2014-05-25 621 struct platform_device *pdev;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 622 int ret;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 623
b2687cd7d5fd739 drivers/acpi/acpi_lpss.c Mathias Krause 2015-06-13 624 dev_desc = (const struct lpss_device_desc *)id->driver_data;
bda3df10fb1ee99 drivers/acpi/acpi_lpss.c Raag Jadav 2023-10-03 625 if (!dev_desc)
bda3df10fb1ee99 drivers/acpi/acpi_lpss.c Raag Jadav 2023-10-03 626 return -EINVAL;
bda3df10fb1ee99 drivers/acpi/acpi_lpss.c Raag Jadav 2023-10-03 627
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 628 pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 629 if (!pdata)
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 630 return -ENOMEM;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 631
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 632 INIT_LIST_HEAD(&resource_list);
840baca4c44130e drivers/acpi/acpi_lpss.c Heikki Krogerus 2022-08-16 633 ret = acpi_dev_get_memory_resources(adev, &resource_list);
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 634 if (ret < 0)
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 635 goto err_out;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 636
da13b3361bb609f drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 637 rentry = list_first_entry_or_null(&resource_list, struct resource_entry, node);
da13b3361bb609f drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 638 if (rentry) {
958c4eb2aa32509 drivers/acpi/acpi_lpss.c Mika Westerberg 2013-06-18 639 if (dev_desc->prv_size_override)
958c4eb2aa32509 drivers/acpi/acpi_lpss.c Mika Westerberg 2013-06-18 640 pdata->mmio_size = dev_desc->prv_size_override;
958c4eb2aa32509 drivers/acpi/acpi_lpss.c Mika Westerberg 2013-06-18 641 else
90e97820619dc91 drivers/acpi/acpi_lpss.c Jiang Liu 2015-02-05 642 pdata->mmio_size = resource_size(rentry->res);
da13b3361bb609f drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 643 pdata->mmio_base = ioremap(rentry->res->start, pdata->mmio_size);
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 644 }
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 645
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 646 acpi_dev_free_resource_list(&resource_list);
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 647
d3e13ff3c1aa240 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2015-07-07 648 if (!pdata->mmio_base) {
e1681599345b846 drivers/acpi/acpi_lpss.c Hans de Goede 2018-01-14 649 /* Avoid acpi_bus_attach() instantiating a pdev for this dev. */
e1681599345b846 drivers/acpi/acpi_lpss.c Hans de Goede 2018-01-14 650 adev->pnp.type.platform_id = 0;
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 651 goto out_free;
d3e13ff3c1aa240 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2015-07-07 652 }
d3e13ff3c1aa240 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2015-07-07 653
dd242a080d178c3 drivers/acpi/acpi_lpss.c Hans de Goede 2017-07-06 654 pdata->adev = adev;
af65cfe9aeae03e drivers/acpi/acpi_lpss.c Mika Westerberg 2013-09-02 655 pdata->dev_desc = dev_desc;
af65cfe9aeae03e drivers/acpi/acpi_lpss.c Mika Westerberg 2013-09-02 656
03f09f73bbd805f drivers/acpi/acpi_lpss.c Heikki Krogerus 2014-09-02 657 if (dev_desc->setup)
03f09f73bbd805f drivers/acpi/acpi_lpss.c Heikki Krogerus 2014-09-02 658 dev_desc->setup(pdata);
03f09f73bbd805f drivers/acpi/acpi_lpss.c Heikki Krogerus 2014-09-02 659
ff8c1af5e7ebfdf drivers/acpi/acpi_lpss.c Heikki Krogerus 2014-09-02 660 if (dev_desc->flags & LPSS_CLK) {
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 661 ret = register_device_clock(adev, pdata);
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 662 if (ret)
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 663 goto out_free;
b9e95fc65ededbe drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-06-19 664 }
b9e95fc65ededbe drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-06-19 665
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 666 /*
b9e95fc65ededbe drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-06-19 667 * This works around a known issue in ACPI tables where LPSS devices
b9e95fc65ededbe drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-06-19 668 * have _PS0 and _PS3 without _PSC (and no power resources), so
b9e95fc65ededbe drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-06-19 669 * acpi_bus_init_power() will assume that the BIOS has put them into D0.
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 670 */
1a2fa02f7489dc4 drivers/acpi/acpi_lpss.c Hans de Goede 2018-12-08 671 acpi_device_fix_up_power(adev);
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 672
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 673 adev->driver_data = pdata;
1571875beecd5de drivers/acpi/acpi_lpss.c Heikki Krogerus 2016-11-03 674 pdev = acpi_create_platform_device(adev, dev_desc->properties);
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 675 if (IS_ERR_OR_NULL(pdev)) {
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 676 adev->driver_data = NULL;
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 @677 ret = PTR_ERR(pdev);
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 678 goto err_out;
8ce62f85a81f57e drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2014-05-25 679 }
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 680
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 681 acpi_lpss_create_device_links(adev, pdev);
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 682 return 1;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 683
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 684 out_free:
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 685 /* Skip the device, but continue the namespace scan */
6cc401be16482bf drivers/acpi/acpi_lpss.c Andy Shevchenko 2022-08-29 686 ret = 0;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 687 err_out:
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 688 kfree(pdata);
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 689 return ret;
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 690 }
f58b082aed43400 drivers/acpi/acpi_lpss.c Rafael J. Wysocki 2013-03-06 691
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-04-08 18:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-04 18:23 [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 1/4] ACPI: x86: Introduce a Makefile Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 2/4] ACPI: x86: Move acpi_cmos_rtc to x86 folder Andy Shevchenko
2024-04-04 18:23 ` [PATCH v2 3/4] ACPI: x86: Move blacklist " Andy Shevchenko
2024-04-05 14:44 ` Kuppuswamy Sathyanarayanan
2024-04-05 15:19 ` Andy Shevchenko
2024-04-05 15:29 ` Kuppuswamy Sathyanarayanan
2024-04-04 18:23 ` [PATCH v2 4/4] ACPI: x86: Move LPSS " Andy Shevchenko
2024-04-05 14:45 ` [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder Kuppuswamy Sathyanarayanan
2024-04-05 15:20 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2024-04-08 18:33 [PATCH v2 4/4] ACPI: x86: Move LPSS to x86 folder kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.