From: Kees Cook <keescook@chromium.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Eric Biederman <ebiederm@xmission.com>,
Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 1/2] selftests: Replace "Bail out" with "Error"
Date: Fri, 5 Apr 2024 08:32:33 -0700 [thread overview]
Message-ID: <202404050832.35AE5A95@keescook> (raw)
In-Reply-To: <20240405131748.1582646-2-usama.anjum@collabora.com>
On Fri, Apr 05, 2024 at 06:17:47PM +0500, Muhammad Usama Anjum wrote:
> "Bail out! " is not descriptive. It rather should be: "Failed: " and
> then that added prefix doesn't need to be added everywhere. Usually in
> the logs, we are searching for "Failed" or "Error" instead of "Bail
> out".
>
> Suggested-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2024-04-05 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 13:17 [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() Muhammad Usama Anjum
2024-04-05 13:17 ` [PATCH 1/2] selftests: Replace "Bail out" with "Error" Muhammad Usama Anjum
2024-04-05 15:32 ` Kees Cook [this message]
2024-04-05 13:17 ` [PATCH 2/2] selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages Muhammad Usama Anjum
2024-04-05 15:32 ` Kees Cook
2024-04-05 14:56 ` [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() Shuah Khan
2024-04-05 15:32 ` Kees Cook
2024-04-05 18:50 ` Shuah Khan
2024-04-05 19:36 ` Bird, Tim
2024-04-05 20:38 ` Muhammad Usama Anjum
2024-04-05 21:07 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404050832.35AE5A95@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.