From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>, Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kernel@collabora.com, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg()
Date: Fri, 5 Apr 2024 08:56:31 -0600 [thread overview]
Message-ID: <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org> (raw)
In-Reply-To: <20240405131748.1582646-1-usama.anjum@collabora.com>
On 4/5/24 07:17, Muhammad Usama Anjum wrote:
> "Bail out! " is not descriptive. It rather should be: "Failed: " and
> then this added prefix doesn't need to be added everywhere. Usually in
> the logs, we are searching for "Failed" or "Error" instead of "Bail
> out" so it must be replace.
>
> Remove Error/Failed prefixes from all usages as well.
>
> Muhammad Usama Anjum (2):
> selftests: Replace "Bail out" with "Error"
> selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages
>
> tools/testing/selftests/exec/load_address.c | 8 +-
> .../testing/selftests/exec/recursion-depth.c | 10 +-
> tools/testing/selftests/kselftest.h | 2 +-
> .../selftests/mm/map_fixed_noreplace.c | 24 +--
> tools/testing/selftests/mm/map_populate.c | 2 +-
> tools/testing/selftests/mm/mremap_dontunmap.c | 2 +-
> tools/testing/selftests/mm/pagemap_ioctl.c | 166 +++++++++---------
> .../selftests/mm/split_huge_page_test.c | 2 +-
> 8 files changed, 108 insertions(+), 108 deletions(-)
>
Andrew, Kees,
I will apply these to linux-kselftest next as a series since these
changes depend on change to tools/testing/selftests/kselftest.h
and need to go together.
Are you okay with that?
thanks,
-- Shuah
next prev parent reply other threads:[~2024-04-05 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 13:17 [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() Muhammad Usama Anjum
2024-04-05 13:17 ` [PATCH 1/2] selftests: Replace "Bail out" with "Error" Muhammad Usama Anjum
2024-04-05 15:32 ` Kees Cook
2024-04-05 13:17 ` [PATCH 2/2] selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages Muhammad Usama Anjum
2024-04-05 15:32 ` Kees Cook
2024-04-05 14:56 ` Shuah Khan [this message]
2024-04-05 15:32 ` [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() Kees Cook
2024-04-05 18:50 ` Shuah Khan
2024-04-05 19:36 ` Bird, Tim
2024-04-05 20:38 ` Muhammad Usama Anjum
2024-04-05 21:07 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.