All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged mm-hotfixes-stable] init-open-output-files-from-cpio-unpacking-with-o_largefile.patch removed from -mm tree
@ 2024-04-05 18:22 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2024-04-05 18:22 UTC (permalink / raw)
  To: mm-commits, tglx, rdunlap, peterz, ndesaulniers, axboe, jsperbeck,
	akpm


The quilt patch titled
     Subject: init: open output files from cpio unpacking with O_LARGEFILE
has been removed from the -mm tree.  Its filename was
     init-open-output-files-from-cpio-unpacking-with-o_largefile.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: John Sperbeck <jsperbeck@google.com>
Subject: init: open output files from cpio unpacking with O_LARGEFILE
Date: Sat, 23 Mar 2024 08:29:34 -0700

If a member of a cpio archive for an initrd or initrams is larger than
2Gb, we'll eventually fail to write to that file when we get to that
limit, unless O_LARGEFILE is set.

The problem can be seen with this recipe, assuming that BLK_DEV_RAM
is not configured:

cd /tmp
dd if=/dev/zero of=BIGFILE bs=1048576 count=2200
echo BIGFILE | cpio -o -H newc -R root:root > initrd.img
kexec -l /boot/vmlinuz-$(uname -r) --initrd=initrd.img --reuse-cmdline
kexec -e

The console will show 'Initramfs unpacking failed: write error'.  With
the patch, the error is gone.

Link: https://lkml.kernel.org/r/20240323152934.3307391-1-jsperbeck@google.com
Signed-off-by: John Sperbeck <jsperbeck@google.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 init/initramfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/init/initramfs.c~init-open-output-files-from-cpio-unpacking-with-o_largefile
+++ a/init/initramfs.c
@@ -367,7 +367,7 @@ static int __init do_name(void)
 	if (S_ISREG(mode)) {
 		int ml = maybe_link();
 		if (ml >= 0) {
-			int openflags = O_WRONLY|O_CREAT;
+			int openflags = O_WRONLY|O_CREAT|O_LARGEFILE;
 			if (ml != 1)
 				openflags |= O_TRUNC;
 			wfile = filp_open(collected, openflags, mode);
_

Patches currently in -mm which might be from jsperbeck@google.com are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-05 18:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-05 18:22 [merged mm-hotfixes-stable] init-open-output-files-from-cpio-unpacking-with-o_largefile.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.