All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: kvm-riscv@lists.infradead.org
Subject: [RFC kvm-unit-tests PATCH v2 00/14] add shellcheck support
Date: Sat,  6 Apr 2024 22:38:09 +1000	[thread overview]
Message-ID: <20240406123833.406488-1-npiggin@gmail.com> (raw)

Tree here

https://gitlab.com/npiggin/kvm-unit-tests/-/tree/shellcheck

Again on top of the "v8 migration, powerpc improvements" series. I
don't plan to rebase the other way around since it's a lot of work.
So this is still in RFC until the other big series gets merged.

Thanks to Andrew for a lot of review. A submitted the likely s390x
bugs separately ahead of this series, and also disabled one of the
tests and dropped its fix patch as-per review comments. Hence 3 fewer
patches. Other than that, since last post:

* Tidied commit messages and added some of Andrew's comments.
* Removed the "SC2034 unused variable" blanket disable, and just
  suppressed the config.mak and a couple of other warnings.
* Blanket disabled "SC2235 Use { ..; } instead of (..)" and dropped
  the fix for it.
* Change warning suppression comments as per Andrew's review, also
  mention in the new unittests doc about the "check =" option not
  allowing whitespace etc in the name since we don't cope with that.

Thanks,
Nick

Nicholas Piggin (14):
  Add initial shellcheck checking
  shellcheck: Fix SC2223
  shellcheck: Fix SC2295
  shellcheck: Fix SC2094
  shellcheck: Fix SC2006
  shellcheck: Fix SC2155
  shellcheck: Fix SC2143
  shellcheck: Fix SC2013
  shellcheck: Fix SC2145
  shellcheck: Fix SC2124
  shellcheck: Fix SC2294
  shellcheck: Fix SC2178
  shellcheck: Fix SC2048
  shellcheck: Suppress various messages

 .shellcheckrc           | 30 ++++++++++++++++++++++++
 Makefile                |  4 ++++
 README.md               |  3 +++
 arm/efi/run             |  4 ++--
 configure               |  2 ++
 riscv/efi/run           |  4 ++--
 run_tests.sh            | 11 +++++----
 scripts/arch-run.bash   | 52 ++++++++++++++++++++++++++++++-----------
 scripts/common.bash     |  5 +++-
 scripts/mkstandalone.sh |  4 +++-
 scripts/runtime.bash    | 14 +++++++----
 11 files changed, 105 insertions(+), 28 deletions(-)
 create mode 100644 .shellcheckrc

-- 
2.43.0



WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alexandru Elisei" <alexandru.elisei@arm.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
	"Nico Böhr" <nrb@linux.ibm.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Shaoqin Huang" <shahuang@redhat.com>,
	"Nikos Nikoleris" <nikos.nikoleris@arm.com>,
	"David Woodhouse" <dwmw@amazon.co.uk>,
	"Ricardo Koller" <ricarkol@google.com>,
	rminmin <renmm6@chinaunicom.cn>, "Gavin Shan" <gshan@redhat.com>,
	"Nina Schoetterl-Glausch" <nsg@linux.ibm.com>,
	"Sean Christopherson" <seanjc@google.com>,
	kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org
Subject: [RFC kvm-unit-tests PATCH v2 00/14] add shellcheck support
Date: Sat,  6 Apr 2024 22:38:09 +1000	[thread overview]
Message-ID: <20240406123833.406488-1-npiggin@gmail.com> (raw)

Tree here

https://gitlab.com/npiggin/kvm-unit-tests/-/tree/shellcheck

Again on top of the "v8 migration, powerpc improvements" series. I
don't plan to rebase the other way around since it's a lot of work.
So this is still in RFC until the other big series gets merged.

Thanks to Andrew for a lot of review. A submitted the likely s390x
bugs separately ahead of this series, and also disabled one of the
tests and dropped its fix patch as-per review comments. Hence 3 fewer
patches. Other than that, since last post:

* Tidied commit messages and added some of Andrew's comments.
* Removed the "SC2034 unused variable" blanket disable, and just
  suppressed the config.mak and a couple of other warnings.
* Blanket disabled "SC2235 Use { ..; } instead of (..)" and dropped
  the fix for it.
* Change warning suppression comments as per Andrew's review, also
  mention in the new unittests doc about the "check =" option not
  allowing whitespace etc in the name since we don't cope with that.

Thanks,
Nick

Nicholas Piggin (14):
  Add initial shellcheck checking
  shellcheck: Fix SC2223
  shellcheck: Fix SC2295
  shellcheck: Fix SC2094
  shellcheck: Fix SC2006
  shellcheck: Fix SC2155
  shellcheck: Fix SC2143
  shellcheck: Fix SC2013
  shellcheck: Fix SC2145
  shellcheck: Fix SC2124
  shellcheck: Fix SC2294
  shellcheck: Fix SC2178
  shellcheck: Fix SC2048
  shellcheck: Suppress various messages

 .shellcheckrc           | 30 ++++++++++++++++++++++++
 Makefile                |  4 ++++
 README.md               |  3 +++
 arm/efi/run             |  4 ++--
 configure               |  2 ++
 riscv/efi/run           |  4 ++--
 run_tests.sh            | 11 +++++----
 scripts/arch-run.bash   | 52 ++++++++++++++++++++++++++++++-----------
 scripts/common.bash     |  5 +++-
 scripts/mkstandalone.sh |  4 +++-
 scripts/runtime.bash    | 14 +++++++----
 11 files changed, 105 insertions(+), 28 deletions(-)
 create mode 100644 .shellcheckrc

-- 
2.43.0


             reply	other threads:[~2024-04-06 12:38 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-06 12:38 Nicholas Piggin [this message]
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 00/14] add shellcheck support Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 01/14] Add initial shellcheck checking Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-11  7:03   ` Thomas Huth
2024-04-11  7:03     ` Thomas Huth
2024-04-16  4:35     ` Nicholas Piggin
2024-04-16  4:35       ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 02/14] shellcheck: Fix SC2223 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 03/14] shellcheck: Fix SC2295 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 04/14] shellcheck: Fix SC2094 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 05/14] shellcheck: Fix SC2006 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 06/14] shellcheck: Fix SC2155 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 07/14] shellcheck: Fix SC2143 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 08/14] shellcheck: Fix SC2013 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-08  7:34   ` Andrew Jones
2024-04-08  7:34     ` Andrew Jones
2024-04-10  4:29     ` Nicholas Piggin
2024-04-10  4:29       ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 09/14] shellcheck: Fix SC2145 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 10/14] shellcheck: Fix SC2124 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 11/14] shellcheck: Fix SC2294 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 12/14] shellcheck: Fix SC2178 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 13/14] shellcheck: Fix SC2048 Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 14/14] shellcheck: Suppress various messages Nicholas Piggin
2024-04-06 12:38   ` Nicholas Piggin
2024-04-08  7:37   ` Andrew Jones
2024-04-08  7:37     ` Andrew Jones
2024-04-15 11:59 ` [RFC kvm-unit-tests PATCH v2 00/14] add shellcheck support Thomas Huth
2024-04-15 11:59   ` Thomas Huth
2024-04-16  3:26   ` Nicholas Piggin
2024-04-16  3:26     ` Nicholas Piggin
2024-04-16  4:46     ` Thomas Huth
2024-04-16  4:46       ` Thomas Huth
2024-04-17  1:40       ` Nicholas Piggin
2024-04-17  1:40         ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240406123833.406488-1-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.