[bcachefs:bcachefs-testing 97/99] fs/bcachefs/btree_gc.c:590:5-8: Unneeded variable: "ret". Return "0" on line 608

[bcachefs:bcachefs-testing 97/99] fs/bcachefs/btree_gc.c:590:5-8: Unneeded variable: "ret". Return "0" on line 608

[kernel test robot]

tree:   https://evilpiepirate.org/git/bcachefs.git bcachefs-testing
head:   efbb47fc238f9ee4c06285f5934f118703e7577e
commit: 62b7bba5f9af1d544a9c65461184b5db0dcf1988 [97/99] bcachefs: bch2_check_allocations_early()
config: mips-randconfig-r062-20240408 (https://download.01.org/0day-ci/archive/20240408/202404080707.wxVEtr4P-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404080707.wxVEtr4P-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/btree_gc.c:590:5-8: Unneeded variable: "ret". Return "0" on line 608

vim +590 fs/bcachefs/btree_gc.c

   587	
   588	static int mark_allocation_early(struct bch_fs *c, struct bkey_s_c k)
   589	{
 > 590		int ret = 0;
   591	
   592		BUG_ON(bch2_journal_seq_verify &&
   593		       k.k->version.lo > atomic64_read(&c->journal.seq));
   594	
   595		if (fsck_err_on(k.k->version.lo > atomic64_read(&c->key_version), c,
   596				bkey_version_in_future,
   597				"key version number higher than recorded: %llu > %llu",
   598				k.k->version.lo,
   599				atomic64_read(&c->key_version)))
   600			atomic64_set(&c->key_version, k.k->version.lo);
   601	
   602		struct bkey_ptrs_c ptrs = bch2_bkey_ptrs_c(k);
   603		bkey_for_each_ptr(ptrs, ptr) {
   604			struct bch_dev *ca = bch_dev_bkey_exists(c, ptr->dev);
   605			__set_bit(PTR_BUCKET_NR(ca, ptr), ca->buckets_nouse);
   606		}
   607	fsck_err:
 > 608		return ret;
   609	}
   610	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki