All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, llvm@lists.linux.dev,
	Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Wedson Almeida Filho <wedsonaf@gmail.com>,
	Gary Guo <gary@garyguo.net>,
	"Bj\"orn Roy Baron" <bjorn3_gh@protonmail.com>,
	Benno Lossin <benno.lossin@proton.me>,
	Andreas Hindborg <a.hindborg@samsung.com>,
	Alice Ryhl <aliceryhl@google.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrea Parri <parri.andrea@gmail.com>,
	Will Deacon <will@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Akira Yokosawa <akiyks@gmail.com>,
	Daniel Lustig <dlustig@nvidia.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	kent.overstreet@gmail.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	elver@google.com, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	torvalds@linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [WIP 0/3] Memory model and atomic API in Rust
Date: Tue, 9 Apr 2024 12:50:15 +0200	[thread overview]
Message-ID: <20240409105015.GC21779@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ZgHly_fioG7X4wGE@boqun-archlinux>

On Mon, Mar 25, 2024 at 01:59:55PM -0700, Boqun Feng wrote:
> On Mon, Mar 25, 2024 at 10:44:45AM +0000, Mark Rutland wrote:
> [...]
> > > 
> > > * I choose to re-implement atomics in Rust `asm` because we are still
> > >   figuring out how we can make it easy and maintainable for Rust to call
> > >   a C function _inlinely_ (Gary makes some progress [2]). Otherwise,
> > >   atomic primitives would be function calls, and that can be performance
> > >   bottleneck in a few cases.
> > 
> > I don't think we want to maintain two copies of each architecture's atomics.
> > This gets painful very quickly (e.g. as arm64's atomics get patched between
> > LL/SC and LSE forms).
> > 
> 
> No argument here ;-)

Didn't we talk about bindgen being able to convert inline C functions
into equivalent inline Rust functions? ISTR that getting stuck on Rust
not having a useful inline asm.

But fixing all that in a hurry seems like the much saner path forward.

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, llvm@lists.linux.dev,
	Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Wedson Almeida Filho <wedsonaf@gmail.com>,
	Gary Guo <gary@garyguo.net>,
	"Bj\"orn Roy Baron" <bjorn3_gh@protonmail.com>,
	Benno Lossin <benno.lossin@proton.me>,
	Andreas Hindborg <a.hindborg@samsung.com>,
	Alice Ryhl <aliceryhl@google.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrea Parri <parri.andrea@gmail.com>,
	Will Deacon <will@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Akira Yokosawa <akiyks@gmail.com>,
	Daniel Lustig <dlustig@nvidia.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	kent.overstreet@gmail.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	elver@google.com, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	torvalds@linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [WIP 0/3] Memory model and atomic API in Rust
Date: Tue, 9 Apr 2024 12:50:15 +0200	[thread overview]
Message-ID: <20240409105015.GC21779@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ZgHly_fioG7X4wGE@boqun-archlinux>

On Mon, Mar 25, 2024 at 01:59:55PM -0700, Boqun Feng wrote:
> On Mon, Mar 25, 2024 at 10:44:45AM +0000, Mark Rutland wrote:
> [...]
> > > 
> > > * I choose to re-implement atomics in Rust `asm` because we are still
> > >   figuring out how we can make it easy and maintainable for Rust to call
> > >   a C function _inlinely_ (Gary makes some progress [2]). Otherwise,
> > >   atomic primitives would be function calls, and that can be performance
> > >   bottleneck in a few cases.
> > 
> > I don't think we want to maintain two copies of each architecture's atomics.
> > This gets painful very quickly (e.g. as arm64's atomics get patched between
> > LL/SC and LSE forms).
> > 
> 
> No argument here ;-)

Didn't we talk about bindgen being able to convert inline C functions
into equivalent inline Rust functions? ISTR that getting stuck on Rust
not having a useful inline asm.

But fixing all that in a hurry seems like the much saner path forward.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-04-09 10:50 UTC|newest]

Thread overview: 152+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 23:38 [WIP 0/3] Memory model and atomic API in Rust Boqun Feng
2024-03-22 23:38 ` Boqun Feng
2024-03-22 23:38 ` [WIP 1/3] rust: Introduce atomic module Boqun Feng
2024-03-22 23:38   ` Boqun Feng
2024-03-22 23:52   ` Andrew Lunn
2024-03-22 23:52     ` Andrew Lunn
2024-03-23  0:03     ` Boqun Feng
2024-03-23  0:03       ` Boqun Feng
2024-03-23 19:13       ` Miguel Ojeda
2024-03-23 19:13         ` Miguel Ojeda
2024-03-23 19:30         ` Boqun Feng
2024-03-23 19:30           ` Boqun Feng
2024-03-23  9:58     ` Alice Ryhl
2024-03-23  9:58       ` Alice Ryhl
2024-03-23 14:10       ` Andrew Lunn
2024-03-23 14:10         ` Andrew Lunn
2024-03-23 19:09         ` Miguel Ojeda
2024-03-23 19:09           ` Miguel Ojeda
2024-03-26  5:56         ` Trevor Gross
2024-03-26  5:56           ` Trevor Gross
2024-03-22 23:38 ` [WIP 2/3] rust: atomic: Add ARM64 fetch_add_relaxed() Boqun Feng
2024-03-22 23:38   ` Boqun Feng
2024-03-22 23:38 ` [WIP 3/3] rust: atomic: Add fetch_sub_release() Boqun Feng
2024-03-22 23:38   ` Boqun Feng
2024-03-22 23:57 ` [WIP 0/3] Memory model and atomic API in Rust Kent Overstreet
2024-03-22 23:57   ` Kent Overstreet
2024-03-23  0:12   ` Linus Torvalds
2024-03-23  0:12     ` Linus Torvalds
2024-03-23  0:21     ` Kent Overstreet
2024-03-23  0:21       ` Kent Overstreet
2024-03-23  0:36       ` Linus Torvalds
2024-03-23  0:36         ` Linus Torvalds
2024-03-23  2:07         ` Kent Overstreet
2024-03-23  2:07           ` Kent Overstreet
2024-03-23  2:26           ` Boqun Feng
2024-03-23  2:26             ` Boqun Feng
2024-03-23  2:33             ` Kent Overstreet
2024-03-23  2:33               ` Kent Overstreet
2024-03-23  2:57               ` Boqun Feng
2024-03-23  2:57                 ` Boqun Feng
2024-03-23  3:10                 ` Kent Overstreet
2024-03-23  3:10                   ` Kent Overstreet
2024-03-23  3:51                   ` Boqun Feng
2024-03-23  3:51                     ` Boqun Feng
2024-03-23  4:16                     ` Kent Overstreet
2024-03-23  4:16                       ` Kent Overstreet
2024-03-25 13:56         ` Philipp Stanner
2024-03-25 13:56           ` Philipp Stanner
2024-03-25 17:44           ` Linus Torvalds
2024-03-25 17:44             ` Linus Torvalds
2024-03-25 18:59             ` Kent Overstreet
2024-03-25 18:59               ` Kent Overstreet
2024-03-25 19:44               ` Linus Torvalds
2024-03-25 19:44                 ` Linus Torvalds
2024-03-25 21:14                 ` Kent Overstreet
2024-03-25 21:14                   ` Kent Overstreet
2024-03-25 21:37                   ` Boqun Feng
2024-03-25 21:37                     ` Boqun Feng
2024-03-25 22:09                     ` Kent Overstreet
2024-03-25 22:09                       ` Kent Overstreet
2024-03-25 22:38                       ` Boqun Feng
2024-03-25 22:38                         ` Boqun Feng
2024-03-25 23:02                         ` Kent Overstreet
2024-03-25 23:02                           ` Kent Overstreet
2024-03-25 23:41                           ` Boqun Feng
2024-03-25 23:41                             ` Boqun Feng
2024-03-26  0:05                 ` Dr. David Alan Gilbert
2024-03-26  0:05                   ` Dr. David Alan Gilbert
2024-03-26  0:36                   ` Kent Overstreet
2024-03-26  0:36                     ` Kent Overstreet
2024-03-26  1:35                     ` Dr. David Alan Gilbert
2024-03-26  1:35                       ` Dr. David Alan Gilbert
2024-03-26  3:28                       ` Kent Overstreet
2024-03-26  3:28                         ` Kent Overstreet
2024-03-26  2:51                   ` Boqun Feng
2024-03-26  2:51                     ` Boqun Feng
2024-03-26  3:49                   ` Linus Torvalds
2024-03-26  3:49                     ` Linus Torvalds
2024-03-26 14:35                     ` Dr. David Alan Gilbert
2024-03-26 14:35                       ` Dr. David Alan Gilbert
2024-03-27 16:16                     ` comex
2024-03-27 16:16                       ` comex
2024-03-27 18:50                       ` Kent Overstreet
2024-03-27 18:50                         ` Kent Overstreet
2024-03-27 19:07                         ` Linus Torvalds
2024-03-27 19:07                           ` Linus Torvalds
2024-03-27 19:41                           ` Kent Overstreet
2024-03-27 19:41                             ` Kent Overstreet
2024-03-27 20:45                             ` Linus Torvalds
2024-03-27 20:45                               ` Linus Torvalds
2024-03-27 21:41                               ` Kent Overstreet
2024-03-27 21:41                                 ` Kent Overstreet
2024-03-27 22:57                                 ` Linus Torvalds
2024-03-27 22:57                                   ` Linus Torvalds
2024-03-27 23:35                                   ` Kent Overstreet
2024-03-27 23:35                                     ` Kent Overstreet
2024-03-27 21:21                             ` Boqun Feng
2024-03-27 21:21                               ` Boqun Feng
2024-03-27 21:49                               ` Kent Overstreet
2024-03-27 21:49                                 ` Kent Overstreet
2024-03-27 22:26                                 ` Boqun Feng
2024-03-27 22:26                                   ` Boqun Feng
2024-03-27 21:56                               ` comex
2024-03-27 21:56                                 ` comex
2024-03-27 22:02                                 ` comex
2024-03-27 22:02                                   ` comex
2024-04-05 17:13                           ` Philipp Stanner
2024-04-05 17:13                             ` Philipp Stanner
2024-04-08 16:02             ` Matthew Wilcox
2024-04-08 16:02               ` Matthew Wilcox
2024-04-08 16:55               ` Paul E. McKenney
2024-04-08 16:55                 ` Paul E. McKenney
2024-04-08 17:03                 ` Matthew Wilcox
2024-04-08 17:03                   ` Matthew Wilcox
2024-04-08 18:47                   ` Paul E. McKenney
2024-04-08 18:47                     ` Paul E. McKenney
2024-04-09  0:58                   ` Kent Overstreet
2024-04-09  0:58                     ` Kent Overstreet
2024-04-09  4:47                     ` Paul E. McKenney
2024-04-09  4:47                       ` Paul E. McKenney
2024-04-08 17:01               ` Linus Torvalds
2024-04-08 17:01                 ` Linus Torvalds
2024-04-08 18:14                 ` Al Viro
2024-04-08 18:14                   ` Al Viro
2024-04-08 20:05                   ` Linus Torvalds
2024-04-08 20:05                     ` Linus Torvalds
2024-03-23 21:40     ` comex
2024-03-23 21:40       ` comex
2024-03-24 15:22       ` Alan Stern
2024-03-24 15:22         ` Alan Stern
2024-03-24 17:37         ` comex
2024-03-24 17:37           ` comex
2024-03-23  0:15   ` Boqun Feng
2024-03-23  0:15     ` Boqun Feng
2024-03-23  0:49     ` Boqun Feng
2024-03-23  0:49       ` Boqun Feng
2024-03-23  1:42       ` Kent Overstreet
2024-03-23  1:42         ` Kent Overstreet
2024-03-23 14:29     ` Andrew Lunn
2024-03-23 14:29       ` Andrew Lunn
2024-03-23 14:41       ` Boqun Feng
2024-03-23 14:41         ` Boqun Feng
2024-03-23 14:55         ` Boqun Feng
2024-03-23 14:55           ` Boqun Feng
2024-03-25 10:44 ` Mark Rutland
2024-03-25 10:44   ` Mark Rutland
2024-03-25 20:59   ` Boqun Feng
2024-03-25 20:59     ` Boqun Feng
2024-04-09 10:50     ` Peter Zijlstra [this message]
2024-04-09 10:50       ` Peter Zijlstra
2024-04-16 18:12       ` Boqun Feng
2024-04-16 18:12         ` Boqun Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240409105015.GC21779@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=a.hindborg@samsung.com \
    --cc=akiyks@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dhowells@redhat.com \
    --cc=dlustig@nvidia.com \
    --cc=elver@google.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=j.alglave@ucl.ac.uk \
    --cc=joel@joelfernandes.org \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=luc.maranget@inria.fr \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=npiggin@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wedsonaf@gmail.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.