* [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH
@ 2024-04-08 6:18 Yi Zhang
2024-04-09 13:55 ` Christoph Hellwig
2024-04-09 22:40 ` Chaitanya Kulkarni
0 siblings, 2 replies; 5+ messages in thread
From: Yi Zhang @ 2024-04-08 6:18 UTC (permalink / raw)
To: linux-nvme; +Cc: kbusch, axboe, hch
Only print oneline log about shared namespaces without CONFIG_NVME_MULTIPATH
Fixes: ce8d78616a6b ("nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH")
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 27281a9a8951..e4bec200ebeb 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3681,7 +3681,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
"Found shared namespace %d, but multipathing not supported.\n",
info->nsid);
dev_warn_once(ctrl->device,
- "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n.");
+ "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0.\n");
}
}
--
2.34.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH
2024-04-08 6:18 [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH Yi Zhang
@ 2024-04-09 13:55 ` Christoph Hellwig
2024-04-10 0:58 ` Yi Zhang
2024-04-09 22:40 ` Chaitanya Kulkarni
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2024-04-09 13:55 UTC (permalink / raw)
To: Yi Zhang; +Cc: linux-nvme, kbusch, axboe
The commit log is a bit weird. What this does is to remove the stray
dot after the newline, right? Maybe state that, and whie you're at
it cut the commit log line to 73 characters and make sure it ends with
a dot.
The change itself looks good to me, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH
2024-04-08 6:18 [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH Yi Zhang
2024-04-09 13:55 ` Christoph Hellwig
@ 2024-04-09 22:40 ` Chaitanya Kulkarni
2024-04-10 0:59 ` Yi Zhang
1 sibling, 1 reply; 5+ messages in thread
From: Chaitanya Kulkarni @ 2024-04-09 22:40 UTC (permalink / raw)
To: Yi Zhang, linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de
On 4/7/2024 11:18 PM, Yi Zhang wrote:
> Only print oneline log about shared namespaces without CONFIG_NVME_MULTIPATH
>
Consider following commit log :-
Move the period '.'that is currently at the end of the line after
newline '\n' to
before newline character which is the right position.
> Fixes: ce8d78616a6b ("nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH") > Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 27281a9a8951..e4bec200ebeb 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3681,7 +3681,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
> "Found shared namespace %d, but multipathing not supported.\n",
> info->nsid);
> dev_warn_once(ctrl->device,
> - "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n.");
> + "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0.\n");
> }
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH
2024-04-09 13:55 ` Christoph Hellwig
@ 2024-04-10 0:58 ` Yi Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Yi Zhang @ 2024-04-10 0:58 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-nvme, kbusch, axboe
On Tue, Apr 9, 2024 at 9:55 PM Christoph Hellwig <hch@lst.de> wrote:
>
> The commit log is a bit weird. What this does is to remove the stray
> dot after the newline, right? Maybe state that, and whie you're at
> it cut the commit log line to 73 characters and make sure it ends with
> a dot.
Thanks, will update it at v2.
>
> The change itself looks good to me, thanks!
>
--
Best Regards,
Yi Zhang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH
2024-04-09 22:40 ` Chaitanya Kulkarni
@ 2024-04-10 0:59 ` Yi Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Yi Zhang @ 2024-04-10 0:59 UTC (permalink / raw)
To: Chaitanya Kulkarni
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org,
axboe@kernel.dk, hch@lst.de
On Wed, Apr 10, 2024 at 6:40 AM Chaitanya Kulkarni
<chaitanyak@nvidia.com> wrote:
>
> On 4/7/2024 11:18 PM, Yi Zhang wrote:
> > Only print oneline log about shared namespaces without CONFIG_NVME_MULTIPATH
> >
>
> Consider following commit log :-
>
> Move the period '.'that is currently at the end of the line after
> newline '\n' to
> before newline character which is the right position.
Thanks, just send v2 as suggested.
>
> > Fixes: ce8d78616a6b ("nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH") > Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> > ---
> > drivers/nvme/host/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> > index 27281a9a8951..e4bec200ebeb 100644
> > --- a/drivers/nvme/host/core.c
> > +++ b/drivers/nvme/host/core.c
> > @@ -3681,7 +3681,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
> > "Found shared namespace %d, but multipathing not supported.\n",
> > info->nsid);
> > dev_warn_once(ctrl->device,
> > - "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n.");
> > + "Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0.\n");
> > }
> > }
> >
--
Best Regards,
Yi Zhang
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-10 0:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-08 6:18 [PATCH] nvme: fix warn output about shared namespaces without CONFIG_NVME_MULTIPATH Yi Zhang
2024-04-09 13:55 ` Christoph Hellwig
2024-04-10 0:58 ` Yi Zhang
2024-04-09 22:40 ` Chaitanya Kulkarni
2024-04-10 0:59 ` Yi Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.