Re: (subset) [PATCH] dt-bindings: mfd: syscon: Add missing simple syscon compatibles

From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, tools@kernel.org
Subject: Re: (subset) [PATCH] dt-bindings: mfd: syscon: Add missing simple syscon compatibles
Date: Thu, 11 Apr 2024 16:07:44 +0100	[thread overview]
Message-ID: <20240411150744.GE2399047@google.com> (raw)
In-Reply-To: <CAL_JsqL5M0gvjBa7VvRm9B3kRpj8=c6f8k2MnG7LbA-jZstB8A@mail.gmail.com>

+tools@kernel.org

On Thu, 11 Apr 2024, Rob Herring wrote:

> On Thu, Apr 11, 2024 at 7:50 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Tue, 02 Apr 2024 15:24:11 -0500, Rob Herring wrote:
> > > Add various "simple" syscon compatibles which were undocumented or
> > > still documented with old text bindings.
> > >
> > > apm,xgene-csw, apm,xgene-efuse, apm,xgene-mcb, apm,xgene-rb,
> > > fsl,ls1088a-reset, marvell,armada-3700-cpu-misc,
> > > mediatek,mt2712-pctl-a-syscfg, mediatek,mt6397-pctl-pmic-syscfg, and
> > > mediatek,mt8173-pctl-a-syscfg were all undocumented, but are in use
> > > already. Remove the old text binding docs for the others.
> > >
> > > [...]
> >
> > Applied, thanks!
> 
> Note that something is going haywire with b4 or you applied a subset
> of a single patch... I really wish b4 didn't change the subjects at
> all since Gmail is incapable of following standard threading.

I think "haywire" is a bit drastic. :)

It's to do with the way I fetch patches from the list:

    b4 am -3 -slt ${PATCHES} -o - ${id} > ${MBOX}

Where ${PATCHES}:

    if [ "${RANGE}" != "" ]; then
        PATCHES="-P ${RANGE}"
    elif [ "${SET}" == "" ]; then
        PATCHES="-P _"  # We need this to pluck patches from sets
    fi

`-P _` means cherry-pick, which doesn't appear to know whether we're
picking up an entire set containing only a single patch or pulling out
an individual patch from a larger set.

There is an option to add a new Mutt key binding to do it which drops
the `-P _` part in the former case, but I've ran out of free keys!

Present Mutt bindings for kernel maintenance:

macro index,pager  M         '<pipe-entry>~/bin/apply-patch.sh mfd-next<enter>'
macro index,pager  F         '<pipe-entry>~/bin/apply-patch.sh mfd-fixes<enter>'
macro index,pager  B         '<pipe-entry>~/bin/apply-patch.sh backlight-next<enter>'
macro index,pager  L         '<pipe-entry>~/bin/apply-patch.sh leds-next<enter>'
macro index,pager  T         '<pipe-entry>~/bin/apply-patch.sh toys<enter>'
- These all apply single patches (single submissions or cherry-picks from sets)

macro index,pager  S         '<pipe-entry>~/bin/apply-patch.sh set<enter>'
- This presents a menu of kernel repos, then applies the whole set to ${choice}

macro index,pager  R         '<pipe-entry>~/bin/apply-patch.sh range<enter>'
- This presents a prompt to enter a given range (e.g. 1-3,6,8)
- Followed by a menu of kernel repos, then applies the range to ${choice}

macro index,pager  A         '<copy-message>=patches-to-apply<enter><enter>'
- Manually applies patches from a mail folder (does not use b4)

-- 
Lee Jones [李琼斯]