* [PATCH] irqchip/riscv-imsic: Fix boot time update effective affinity warning
@ 2024-04-13 6:52 ` Anup Patel
0 siblings, 0 replies; 3+ messages in thread
From: Anup Patel @ 2024-04-13 6:52 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Anup Patel, Anup Patel, Paul Walmsley, linux-kernel,
Palmer Dabbelt, Atish Patra, linux-riscv, Andrew Jones
Currently, the following warning is observed on the QEMU virt machine:
genirq: irq_chip APLIC-MSI-d000000.aplic did not update eff. affinity mask of irq 12
The above warning is because the IMSIC driver does not set the initial
value of effective affinity in the irq descriptor. To address this,
initialize the effective affinity in imsic_irq_domain_alloc().
Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
drivers/irqchip/irq-riscv-imsic-platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 1e6dddfd3046..11723a763c10 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -157,6 +157,7 @@ static int imsic_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
handle_simple_irq, NULL, NULL);
irq_set_noprobe(virq);
irq_set_affinity(virq, cpu_online_mask);
+ irq_data_update_effective_affinity(irq_get_irq_data(virq), cpumask_of(vec->cpu));
return 0;
}
--
2.34.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] irqchip/riscv-imsic: Fix boot time update effective affinity warning
@ 2024-04-13 6:52 ` Anup Patel
0 siblings, 0 replies; 3+ messages in thread
From: Anup Patel @ 2024-04-13 6:52 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Palmer Dabbelt, Paul Walmsley, Atish Patra, Andrew Jones,
Sunil V L, Anup Patel, linux-riscv, linux-kernel, Anup Patel
Currently, the following warning is observed on the QEMU virt machine:
genirq: irq_chip APLIC-MSI-d000000.aplic did not update eff. affinity mask of irq 12
The above warning is because the IMSIC driver does not set the initial
value of effective affinity in the irq descriptor. To address this,
initialize the effective affinity in imsic_irq_domain_alloc().
Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
drivers/irqchip/irq-riscv-imsic-platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 1e6dddfd3046..11723a763c10 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -157,6 +157,7 @@ static int imsic_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
handle_simple_irq, NULL, NULL);
irq_set_noprobe(virq);
irq_set_affinity(virq, cpu_online_mask);
+ irq_data_update_effective_affinity(irq_get_irq_data(virq), cpumask_of(vec->cpu));
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [tip: irq/core] irqchip/riscv-imsic: Fix boot time update effective affinity warning
2024-04-13 6:52 ` Anup Patel
(?)
@ 2024-04-14 11:37 ` tip-bot2 for Anup Patel
-1 siblings, 0 replies; 3+ messages in thread
From: tip-bot2 for Anup Patel @ 2024-04-14 11:37 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Anup Patel, Thomas Gleixner, x86, linux-kernel, maz
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 35d77eb7b974f62aaef5a0dc72d93ddb1ada4074
Gitweb: https://git.kernel.org/tip/35d77eb7b974f62aaef5a0dc72d93ddb1ada4074
Author: Anup Patel <apatel@ventanamicro.com>
AuthorDate: Sat, 13 Apr 2024 12:22:10 +05:30
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sun, 14 Apr 2024 13:28:49 +02:00
irqchip/riscv-imsic: Fix boot time update effective affinity warning
Currently, the following warning is observed on the QEMU virt machine:
genirq: irq_chip APLIC-MSI-d000000.aplic did not update eff. affinity mask of irq 12
The above warning is because the IMSIC driver does not set the initial
value of effective affinity in the interrupt descriptor. To address this,
initialize the effective affinity in imsic_irq_domain_alloc().
Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240413065210.315896-1-apatel@ventanamicro.com
---
drivers/irqchip/irq-riscv-imsic-platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 1e6dddf..11723a7 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -157,6 +157,7 @@ static int imsic_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
handle_simple_irq, NULL, NULL);
irq_set_noprobe(virq);
irq_set_affinity(virq, cpu_online_mask);
+ irq_data_update_effective_affinity(irq_get_irq_data(virq), cpumask_of(vec->cpu));
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-14 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-13 6:52 [PATCH] irqchip/riscv-imsic: Fix boot time update effective affinity warning Anup Patel
2024-04-13 6:52 ` Anup Patel
2024-04-14 11:37 ` [tip: irq/core] " tip-bot2 for Anup Patel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.