All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Theodore Ts'o <tytso@mit.edu>
Cc: "Andreas Dilger" <adilger@dilger.ca>,
	"Nam Cao" <namcao@linutronix.de>,
	"Björn Töpel" <bjorn@kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"Christian Brauner" <brauner@kernel.org>,
	"Jan Kara" <jack@suse.cz>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-riscv@lists.infradead.org,
	"Ext4 Developers List" <linux-ext4@vger.kernel.org>,
	"Conor Dooley" <conor@kernel.org>
Subject: Re: riscv32 EXT4 splat, 6.8 regression?
Date: Sun, 14 Apr 2024 03:18:30 +0100	[thread overview]
Message-ID: <20240414021830.GR2118490@ZenIV> (raw)
In-Reply-To: <20240414020457.GI187181@mit.edu>

On Sat, Apr 13, 2024 at 10:04:57PM -0400, Theodore Ts'o wrote:
> On Sat, Apr 13, 2024 at 07:46:03PM -0600, Andreas Dilger wrote:
> > This looks like a straight-forward mathematical substitution of "dlimit"
> > with "search_buf + buf_size" and rearranging of the terms to make the
> > while loop offset "zero based" rather than "address based" and would
> > avoid overflow if "search_buf" was within one 4kB block of overflow:
> > 
> >    dlimit = search_buf + buf_size = 0xfffff000 + 0x1000 = 0x00000000
> 
> Umm... maybe, but does riscv32 actually have a memory map where a
> kernel page would actually have an address in high memory like that?
> That seems.... unusual.

Would instanty break IS_ERR() and friends.  And those are arch-independent.

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Theodore Ts'o <tytso@mit.edu>
Cc: "Andreas Dilger" <adilger@dilger.ca>,
	"Nam Cao" <namcao@linutronix.de>,
	"Björn Töpel" <bjorn@kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"Christian Brauner" <brauner@kernel.org>,
	"Jan Kara" <jack@suse.cz>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-riscv@lists.infradead.org,
	"Ext4 Developers List" <linux-ext4@vger.kernel.org>,
	"Conor Dooley" <conor@kernel.org>
Subject: Re: riscv32 EXT4 splat, 6.8 regression?
Date: Sun, 14 Apr 2024 03:18:30 +0100	[thread overview]
Message-ID: <20240414021830.GR2118490@ZenIV> (raw)
In-Reply-To: <20240414020457.GI187181@mit.edu>

On Sat, Apr 13, 2024 at 10:04:57PM -0400, Theodore Ts'o wrote:
> On Sat, Apr 13, 2024 at 07:46:03PM -0600, Andreas Dilger wrote:
> > This looks like a straight-forward mathematical substitution of "dlimit"
> > with "search_buf + buf_size" and rearranging of the terms to make the
> > while loop offset "zero based" rather than "address based" and would
> > avoid overflow if "search_buf" was within one 4kB block of overflow:
> > 
> >    dlimit = search_buf + buf_size = 0xfffff000 + 0x1000 = 0x00000000
> 
> Umm... maybe, but does riscv32 actually have a memory map where a
> kernel page would actually have an address in high memory like that?
> That seems.... unusual.

Would instanty break IS_ERR() and friends.  And those are arch-independent.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-04-14  2:18 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 14:57 riscv32 EXT4 splat, 6.8 regression? Björn Töpel
2024-04-12 14:57 ` Björn Töpel
2024-04-12 15:43 ` Theodore Ts'o
2024-04-12 15:43   ` Theodore Ts'o
2024-04-12 16:59   ` Björn Töpel
2024-04-12 16:59     ` Björn Töpel
2024-04-13  4:35     ` Theodore Ts'o
2024-04-13  4:35       ` Theodore Ts'o
2024-04-13 10:01       ` Conor Dooley
2024-04-13 10:01         ` Conor Dooley
2024-04-13 14:43 ` Nam Cao
2024-04-13 14:43   ` Nam Cao
2024-04-14  0:24   ` Theodore Ts'o
2024-04-14  0:24     ` Theodore Ts'o
2024-04-14  1:46   ` Andreas Dilger
2024-04-14  1:46     ` Andreas Dilger
2024-04-14  2:04     ` Theodore Ts'o
2024-04-14  2:04       ` Theodore Ts'o
2024-04-14  2:18       ` Al Viro [this message]
2024-04-14  2:18         ` Al Viro
2024-04-14  2:15     ` Al Viro
2024-04-14  2:15       ` Al Viro
2024-04-14  4:16       ` Andreas Dilger
2024-04-14  4:16         ` Andreas Dilger
2024-04-14 14:08         ` Björn Töpel
2024-04-14 14:08           ` Björn Töpel
2024-04-15 13:04           ` Christian Brauner
2024-04-15 13:04             ` Christian Brauner
2024-04-15 16:04             ` Björn Töpel
2024-04-15 16:04               ` Björn Töpel
2024-04-16  6:44               ` Nam Cao
2024-04-16  6:44                 ` Nam Cao
2024-04-16  8:25                 ` Christian Brauner
2024-04-16  8:25                   ` Christian Brauner
2024-04-16 11:02                   ` Björn Töpel
2024-04-16 11:02                     ` Björn Töpel
2024-04-16 14:24                     ` Mike Rapoport
2024-04-16 14:24                       ` Mike Rapoport
2024-04-16 15:17                       ` Nam Cao
2024-04-16 15:17                         ` Nam Cao
2024-04-16 15:30                         ` Nam Cao
2024-04-16 15:30                           ` Nam Cao
2024-04-16 15:56                           ` Björn Töpel
2024-04-16 15:56                             ` Björn Töpel
2024-04-16 16:19                             ` Nam Cao
2024-04-16 16:19                               ` Nam Cao
2024-04-16 16:31                               ` Mike Rapoport
2024-04-16 16:31                                 ` Mike Rapoport
2024-04-16 17:00                                 ` Matthew Wilcox
2024-04-16 17:00                                   ` Matthew Wilcox
2024-04-16 18:34                                   ` Mike Rapoport
2024-04-16 18:34                                     ` Mike Rapoport
2024-04-16 22:36                                     ` Nam Cao
2024-04-16 22:36                                       ` Nam Cao
2024-04-17 15:31                                       ` Theodore Ts'o
2024-04-17 15:31                                         ` Theodore Ts'o
2024-04-17 18:06                                         ` Nam Cao
2024-04-17 18:06                                           ` Nam Cao
2024-04-17 19:34                                       ` Mike Rapoport
2024-04-17 19:34                                         ` Mike Rapoport
2024-04-17 22:09                                       ` Andreas Dilger
2024-04-17 22:09                                         ` Andreas Dilger
2024-04-18  9:17                                         ` Nam Cao
2024-04-18  9:17                                           ` Nam Cao
2024-04-16 18:05                               ` Björn Töpel
2024-04-16 18:05                                 ` Björn Töpel
2024-04-16 18:09                                 ` Nam Cao
2024-04-16 18:09                                   ` Nam Cao
2024-04-16 16:19                         ` Mike Rapoport
2024-04-16 16:19                           ` Mike Rapoport
2024-04-16 16:31                           ` Matthew Wilcox
2024-04-16 16:31                             ` Matthew Wilcox
2024-04-16 18:18                             ` Mike Rapoport
2024-04-16 18:18                               ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240414021830.GR2118490@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=adilger@dilger.ca \
    --cc=bjorn@kernel.org \
    --cc=brauner@kernel.org \
    --cc=conor@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=namcao@linutronix.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.