From: Manivannan Sadhasivam <mani@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Srikanth Thokala" <srikanth.thokala@intel.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
"Niklas Cassel" <cassel@kernel.org>,
linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org,
"Frank Li" <Frank.Li@nxp.com>
Subject: Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs
Date: Mon, 15 Apr 2024 19:30:15 +0530 [thread overview]
Message-ID: <20240415140015.GJ7537@thinkpad> (raw)
In-Reply-To: <20240412195836.GA13344@bhelgaas>
On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote:
> On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote:
> > All of the APIs are missing the Kernel-doc comments. Hence, add them.
>
> > + * dw_pcie_ep_reset_bar - Reset endpoint BAR
>
> Apparently this resets @bar for every function of the device, so it's
> not just a single BAR?
>
Right. It should've been 'Reset endpoint BARs'. And the API name is also
misleading, but that is not the scope of this series.
> > + * dw_pcie_ep_raise_intx_irq - Raise INTx IRQ to the host
> > + * @ep: DWC EP device
> > + * @func_no: Function number of the endpoint
> > + *
> > + * Return: 0 if success, errono otherwise.
>
> s/errono/errno/ (another instance below)
>
ah, thanks for spotting. Since this series is already merged, I hope Krzysztof
can ammend this.
- Mani
--
மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Srikanth Thokala" <srikanth.thokala@intel.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
"Niklas Cassel" <cassel@kernel.org>,
linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org,
"Frank Li" <Frank.Li@nxp.com>
Subject: Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs
Date: Mon, 15 Apr 2024 19:30:15 +0530 [thread overview]
Message-ID: <20240415140015.GJ7537@thinkpad> (raw)
In-Reply-To: <20240412195836.GA13344@bhelgaas>
On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote:
> On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote:
> > All of the APIs are missing the Kernel-doc comments. Hence, add them.
>
> > + * dw_pcie_ep_reset_bar - Reset endpoint BAR
>
> Apparently this resets @bar for every function of the device, so it's
> not just a single BAR?
>
Right. It should've been 'Reset endpoint BARs'. And the API name is also
misleading, but that is not the scope of this series.
> > + * dw_pcie_ep_raise_intx_irq - Raise INTx IRQ to the host
> > + * @ep: DWC EP device
> > + * @func_no: Function number of the endpoint
> > + *
> > + * Return: 0 if success, errono otherwise.
>
> s/errono/errno/ (another instance below)
>
ah, thanks for spotting. Since this series is already merged, I hope Krzysztof
can ammend this.
- Mani
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
linux-pci@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
"NXP Linux Team" <linux-imx@nxp.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Srikanth Thokala" <srikanth.thokala@intel.com>,
linux-arm-msm@vger.kernel.org,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linuxppc-dev@lists.ozlabs.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-omap@vger.kernel.org, "Mingkai Hu" <mingkai.hu@nxp.com>,
linux-arm-kernel@lists.infradead.org,
"Roy Zang" <roy.zang@nxp.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-kernel@vger.kernel.org, "Vidya Sagar" <vidyas@nvidia.com>,
linux-renesas-soc@vger.kernel.org,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs
Date: Mon, 15 Apr 2024 19:30:15 +0530 [thread overview]
Message-ID: <20240415140015.GJ7537@thinkpad> (raw)
In-Reply-To: <20240412195836.GA13344@bhelgaas>
On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote:
> On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote:
> > All of the APIs are missing the Kernel-doc comments. Hence, add them.
>
> > + * dw_pcie_ep_reset_bar - Reset endpoint BAR
>
> Apparently this resets @bar for every function of the device, so it's
> not just a single BAR?
>
Right. It should've been 'Reset endpoint BARs'. And the API name is also
misleading, but that is not the scope of this series.
> > + * dw_pcie_ep_raise_intx_irq - Raise INTx IRQ to the host
> > + * @ep: DWC EP device
> > + * @func_no: Function number of the endpoint
> > + *
> > + * Return: 0 if success, errono otherwise.
>
> s/errono/errno/ (another instance below)
>
ah, thanks for spotting. Since this series is already merged, I hope Krzysztof
can ammend this.
- Mani
--
மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Srikanth Thokala" <srikanth.thokala@intel.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
"Niklas Cassel" <cassel@kernel.org>,
linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org,
"Frank Li" <Frank.Li@nxp.com>
Subject: Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs
Date: Mon, 15 Apr 2024 19:30:15 +0530 [thread overview]
Message-ID: <20240415140015.GJ7537@thinkpad> (raw)
In-Reply-To: <20240412195836.GA13344@bhelgaas>
On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote:
> On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote:
> > All of the APIs are missing the Kernel-doc comments. Hence, add them.
>
> > + * dw_pcie_ep_reset_bar - Reset endpoint BAR
>
> Apparently this resets @bar for every function of the device, so it's
> not just a single BAR?
>
Right. It should've been 'Reset endpoint BARs'. And the API name is also
misleading, but that is not the scope of this series.
> > + * dw_pcie_ep_raise_intx_irq - Raise INTx IRQ to the host
> > + * @ep: DWC EP device
> > + * @func_no: Function number of the endpoint
> > + *
> > + * Return: 0 if success, errono otherwise.
>
> s/errono/errno/ (another instance below)
>
ah, thanks for spotting. Since this series is already merged, I hope Krzysztof
can ammend this.
- Mani
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-15 14:00 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 9:13 [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 1/8] " Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-04-12 19:58 ` Bjorn Helgaas
2024-04-12 19:58 ` Bjorn Helgaas
2024-04-12 19:58 ` Bjorn Helgaas
2024-04-12 19:58 ` Bjorn Helgaas
2024-04-15 14:00 ` Manivannan Sadhasivam [this message]
2024-04-15 14:00 ` Manivannan Sadhasivam
2024-04-15 14:00 ` Manivannan Sadhasivam
2024-04-15 14:00 ` Manivannan Sadhasivam
2024-04-15 14:34 ` Bjorn Helgaas
2024-04-15 14:34 ` Bjorn Helgaas
2024-04-15 14:34 ` Bjorn Helgaas
2024-04-15 14:34 ` Bjorn Helgaas
2024-03-27 9:13 ` [PATCH v12 3/8] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 4/8] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 5/8] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 6/8] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-29 19:16 ` Frank Li
2024-03-29 19:16 ` Frank Li
2024-03-29 19:16 ` Frank Li
2024-03-29 19:16 ` Frank Li
2024-03-27 9:13 ` [PATCH v12 8/8] PCI: endpoint: Remove "core_init_notifier" flag Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:13 ` Manivannan Sadhasivam
2024-03-27 9:41 ` Niklas Cassel
2024-03-27 9:41 ` Niklas Cassel
2024-03-27 9:41 ` Niklas Cassel
2024-03-27 9:41 ` Niklas Cassel
2024-03-29 19:17 ` Frank Li
2024-03-29 19:17 ` Frank Li
2024-03-29 19:17 ` Frank Li
2024-03-29 19:17 ` Frank Li
2024-04-12 20:22 ` Bjorn Helgaas
2024-04-12 20:22 ` Bjorn Helgaas
2024-04-12 20:22 ` Bjorn Helgaas
2024-04-12 20:22 ` Bjorn Helgaas
2024-04-14 10:51 ` Manivannan Sadhasivam
2024-04-14 10:51 ` Manivannan Sadhasivam
2024-04-14 10:51 ` Manivannan Sadhasivam
2024-04-14 10:51 ` Manivannan Sadhasivam
2024-05-17 17:04 ` [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Krzysztof Wilczyński
2024-05-17 17:04 ` Krzysztof Wilczyński
2024-05-17 17:04 ` Krzysztof Wilczyński
2024-05-17 17:04 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415140015.GJ7537@thinkpad \
--to=mani@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=festevam@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=mhiramat@kernel.org \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=srikanth.thokala@intel.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
--cc=vigneshr@ti.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.