From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: netdev@vger.kernel.org,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
intel-wired-lan@lists.osuosl.org, andrii.staikov@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Deduplicate tc action setup
Date: Tue, 16 Apr 2024 12:22:31 +0100 [thread overview]
Message-ID: <20240416112231.GL2320920@kernel.org> (raw)
In-Reply-To: <20240415084907.613777-1-marcin.szycik@linux.intel.com>
On Mon, Apr 15, 2024 at 10:49:07AM +0200, Marcin Szycik wrote:
> ice_tc_setup_redirect_action() and ice_tc_setup_mirror_action() are almost
> identical, except for setting filter action. Reduce them to one function
> with an extra param, which handles both cases.
>
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 56 ++++++---------------
> 1 file changed, 15 insertions(+), 41 deletions(-)
Less is more :)
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
andrii.staikov@intel.com,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Subject: Re: [PATCH iwl-next] ice: Deduplicate tc action setup
Date: Tue, 16 Apr 2024 12:22:31 +0100 [thread overview]
Message-ID: <20240416112231.GL2320920@kernel.org> (raw)
In-Reply-To: <20240415084907.613777-1-marcin.szycik@linux.intel.com>
On Mon, Apr 15, 2024 at 10:49:07AM +0200, Marcin Szycik wrote:
> ice_tc_setup_redirect_action() and ice_tc_setup_mirror_action() are almost
> identical, except for setting filter action. Reduce them to one function
> with an extra param, which handles both cases.
>
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 56 ++++++---------------
> 1 file changed, 15 insertions(+), 41 deletions(-)
Less is more :)
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-16 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 8:49 [Intel-wired-lan] [PATCH iwl-next] ice: Deduplicate tc action setup Marcin Szycik
2024-04-15 8:49 ` Marcin Szycik
2024-04-16 11:22 ` Simon Horman [this message]
2024-04-16 11:22 ` Simon Horman
2024-05-03 6:23 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2024-05-03 6:23 ` Buvaneswaran, Sujai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416112231.GL2320920@kernel.org \
--to=horms@kernel.org \
--cc=andrii.staikov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.