From: Francesco Dolcini <francesco@dolcini.it>
To: Frank Li <Frank.li@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes
Date: Wed, 17 Apr 2024 19:20:31 +0200 [thread overview]
Message-ID: <20240417172031.GA4100@francesco-nb> (raw)
In-Reply-To: <Zh/yZ2HyF+G8bty7@lizhi-Precision-Tower-5810>
Hello Frank,
On Wed, Apr 17, 2024 at 12:01:43PM -0400, Frank Li wrote:
> On Tue, Apr 16, 2024 at 08:50:26AM +0200, Francesco Dolcini wrote:
> > On Mon, Apr 15, 2024 at 03:46:38PM -0400, Frank Li wrote:
> > > Add i.MX8QM audio related nodes and update eDMA[0,1]'s information.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi | 473 +++++++++++++++++++++
> > > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 86 ++++
> > > 2 files changed, 559 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> > > new file mode 100644
> > > index 0000000000000..ed5a1b4af1d76
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
...
> > > +/delete-node/ &acm;
> > > +/delete-node/ &sai4;
> > > +/delete-node/ &sai5;
> > > +/delete-node/ &sai4_lpcg;
> > > +/delete-node/ &sai5_lpcg;
> >
> > Can you explain these delete-node ? This is something that I would
> > expect when a dtsi is previously included, not in this case.
>
> We want to avoid some property inherent from parent dtsi file because it is
> big difference with common one.
>
> This node will be rewrite totally in this files.
imx8qm-ss-audio.dtsi does not include any file. From where these
inherited properties are coming from? Which file is the "parent dtsi" ?
Thanks,
Francesco
WARNING: multiple messages have this Message-ID (diff)
From: Francesco Dolcini <francesco@dolcini.it>
To: Frank Li <Frank.li@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes
Date: Wed, 17 Apr 2024 19:20:31 +0200 [thread overview]
Message-ID: <20240417172031.GA4100@francesco-nb> (raw)
In-Reply-To: <Zh/yZ2HyF+G8bty7@lizhi-Precision-Tower-5810>
Hello Frank,
On Wed, Apr 17, 2024 at 12:01:43PM -0400, Frank Li wrote:
> On Tue, Apr 16, 2024 at 08:50:26AM +0200, Francesco Dolcini wrote:
> > On Mon, Apr 15, 2024 at 03:46:38PM -0400, Frank Li wrote:
> > > Add i.MX8QM audio related nodes and update eDMA[0,1]'s information.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi | 473 +++++++++++++++++++++
> > > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 86 ++++
> > > 2 files changed, 559 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> > > new file mode 100644
> > > index 0000000000000..ed5a1b4af1d76
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
...
> > > +/delete-node/ &acm;
> > > +/delete-node/ &sai4;
> > > +/delete-node/ &sai5;
> > > +/delete-node/ &sai4_lpcg;
> > > +/delete-node/ &sai5_lpcg;
> >
> > Can you explain these delete-node ? This is something that I would
> > expect when a dtsi is previously included, not in this case.
>
> We want to avoid some property inherent from parent dtsi file because it is
> big difference with common one.
>
> This node will be rewrite totally in this files.
imx8qm-ss-audio.dtsi does not include any file. From where these
inherited properties are coming from? Which file is the "parent dtsi" ?
Thanks,
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-17 17:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 19:46 [PATCH 00/10] arm64: dts: imx8qm Add audio\flexcan\i2c\fec1 nodes for imx8qm-mek board Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 01/10] arm64: dts: imx8-ss-audio: remove memory-region = <&dsp_reserved>; Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-16 6:50 ` Francesco Dolcini
2024-04-16 6:50 ` Francesco Dolcini
2024-04-17 16:01 ` Frank Li
2024-04-17 16:01 ` Frank Li
2024-04-17 17:20 ` Francesco Dolcini [this message]
2024-04-17 17:20 ` Francesco Dolcini
2024-04-17 18:29 ` Frank Li
2024-04-17 18:29 ` Frank Li
2024-04-15 19:46 ` [PATCH 03/10] arm64: dts: imx8qm-mek: add sai and wm8960 support Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 04/10] arm64: dts: imx8x: add cm41 subsystem dtsi Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 05/10] arm64: dts: imx8qm-mek: add i2c0 and children devices Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 06/10] arm64: dts: imx8qm-mek: add cm41_i2c " Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 07/10] arm64: dts: imx8qm-mek: add flexcan support Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 08/10] arm64: dts: imx8qm-mek: add lsio mu5 and mu6 Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 09/10] arm64: dts: imx8qm: add ocopt and fec_mac[0,1] Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-15 19:46 ` [PATCH 10/10] arm64: dts: imx8qm-mek: add fec2 support Frank Li
2024-04-15 19:46 ` Frank Li
2024-04-16 6:52 ` Francesco Dolcini
2024-04-16 6:52 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417172031.GA4100@francesco-nb \
--to=francesco@dolcini.it \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.