From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Michal Simek <michal.simek@amd.com>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support
Date: Mon, 22 Apr 2024 14:45:40 -0400 [thread overview]
Message-ID: <20240422184553.3573009-1-sean.anderson@linux.dev> (raw)
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
Last time I discussed converting the HPD work(s) to a threaded IRQ. I
did not end up doing that for this series since the steps would be
- Add locking
- Move link retraining to a work function
- Harden the IRQ
- Merge the works into a threaded IRQ (omitted)
Which with the exception of the final step is the same as leaving those
works as-is. Conversion to a threaded IRQ can be done as a follow-up.
Changes in v3:
- Store base pointers in zynqmp_disp directly
- Don't delay work
- Convert to a hard IRQ
- Use AUX IRQs instead of polling
- Take dp->lock in zynqmp_dp_hpd_work_func
Changes in v2:
- Fix kerneldoc
- Rearrange zynqmp_dp for better padding
- Split off the HPD IRQ work into another commit
- Expand the commit message
- Document hpd_irq_work
- Document debugfs files
- Add ignore_aux_errors and ignore_hpd debugfs files to replace earlier
implicit functionality
- Attempt to fix unreproducable, spurious build warning
- Drop "Optionally ignore DPCD errors" in favor of a debugfs file
directly affecting zynqmp_dp_aux_transfer.
Sean Anderson (13):
drm: xlnx: Store base pointers in zynqmp_disp directly
drm: xlnx: Fix kerneldoc
drm: zynqmp_dp: Downgrade log level for aux retries message
drm: zynqmp_dp: Adjust training values per-lane
drm: zynqmp_dp: Rearrange zynqmp_dp for better padding
drm: zynqmp_dp: Don't delay work
drm: zynqmp_dp: Add locking
drm: zynqmp_dp: Don't retrain the link in our IRQ
drm: zynqmp_dp: Convert to a hard IRQ
drm: zynqmp_dp: Use AUX IRQs instead of polling
drm: zynqmp_dp: Split off several helper functions
drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func
drm: zynqmp_dp: Add debugfs interface for compliance testing
Documentation/gpu/drivers.rst | 1 +
Documentation/gpu/zynqmp.rst | 149 +++++
MAINTAINERS | 1 +
drivers/gpu/drm/xlnx/zynqmp_disp.c | 44 +-
drivers/gpu/drm/xlnx/zynqmp_dp.c | 909 +++++++++++++++++++++++++---
drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.h | 4 +-
7 files changed, 1000 insertions(+), 109 deletions(-)
create mode 100644 Documentation/gpu/zynqmp.rst
--
2.35.1.1320.gc452695387.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Michal Simek <michal.simek@amd.com>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support
Date: Mon, 22 Apr 2024 14:45:40 -0400 [thread overview]
Message-ID: <20240422184553.3573009-1-sean.anderson@linux.dev> (raw)
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
Last time I discussed converting the HPD work(s) to a threaded IRQ. I
did not end up doing that for this series since the steps would be
- Add locking
- Move link retraining to a work function
- Harden the IRQ
- Merge the works into a threaded IRQ (omitted)
Which with the exception of the final step is the same as leaving those
works as-is. Conversion to a threaded IRQ can be done as a follow-up.
Changes in v3:
- Store base pointers in zynqmp_disp directly
- Don't delay work
- Convert to a hard IRQ
- Use AUX IRQs instead of polling
- Take dp->lock in zynqmp_dp_hpd_work_func
Changes in v2:
- Fix kerneldoc
- Rearrange zynqmp_dp for better padding
- Split off the HPD IRQ work into another commit
- Expand the commit message
- Document hpd_irq_work
- Document debugfs files
- Add ignore_aux_errors and ignore_hpd debugfs files to replace earlier
implicit functionality
- Attempt to fix unreproducable, spurious build warning
- Drop "Optionally ignore DPCD errors" in favor of a debugfs file
directly affecting zynqmp_dp_aux_transfer.
Sean Anderson (13):
drm: xlnx: Store base pointers in zynqmp_disp directly
drm: xlnx: Fix kerneldoc
drm: zynqmp_dp: Downgrade log level for aux retries message
drm: zynqmp_dp: Adjust training values per-lane
drm: zynqmp_dp: Rearrange zynqmp_dp for better padding
drm: zynqmp_dp: Don't delay work
drm: zynqmp_dp: Add locking
drm: zynqmp_dp: Don't retrain the link in our IRQ
drm: zynqmp_dp: Convert to a hard IRQ
drm: zynqmp_dp: Use AUX IRQs instead of polling
drm: zynqmp_dp: Split off several helper functions
drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func
drm: zynqmp_dp: Add debugfs interface for compliance testing
Documentation/gpu/drivers.rst | 1 +
Documentation/gpu/zynqmp.rst | 149 +++++
MAINTAINERS | 1 +
drivers/gpu/drm/xlnx/zynqmp_disp.c | 44 +-
drivers/gpu/drm/xlnx/zynqmp_dp.c | 909 +++++++++++++++++++++++++---
drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.h | 4 +-
7 files changed, 1000 insertions(+), 109 deletions(-)
create mode 100644 Documentation/gpu/zynqmp.rst
--
2.35.1.1320.gc452695387.dirty
next reply other threads:[~2024-04-22 18:46 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 18:45 Sean Anderson [this message]
2024-04-22 18:45 ` [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support Sean Anderson
2024-04-22 18:45 ` [PATCH v3 01/13] drm: xlnx: Store base pointers in zynqmp_disp directly Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-23 12:16 ` Tomi Valkeinen
2024-04-23 12:16 ` Tomi Valkeinen
2024-04-22 18:45 ` [PATCH v3 02/13] drm: xlnx: Fix kerneldoc Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-23 12:17 ` Tomi Valkeinen
2024-04-23 12:17 ` Tomi Valkeinen
2024-04-22 18:45 ` [PATCH v3 03/13] drm: zynqmp_dp: Downgrade log level for aux retries message Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 04/13] drm: zynqmp_dp: Adjust training values per-lane Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 05/13] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 06/13] drm: zynqmp_dp: Don't delay work Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-23 12:18 ` Tomi Valkeinen
2024-04-23 12:18 ` Tomi Valkeinen
2024-04-22 18:45 ` [PATCH v3 07/13] drm: zynqmp_dp: Add locking Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 08/13] drm: zynqmp_dp: Don't retrain the link in our IRQ Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 09/13] drm: zynqmp_dp: Convert to a hard IRQ Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 10/13] drm: zynqmp_dp: Use AUX IRQs instead of polling Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 11/13] drm: zynqmp_dp: Split off several helper functions Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 12/13] drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:45 ` [PATCH v3 13/13] drm: zynqmp_dp: Add debugfs interface for compliance testing Sean Anderson
2024-04-22 18:45 ` Sean Anderson
2024-04-22 18:48 ` [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support Sean Anderson
2024-04-22 18:48 ` Sean Anderson
2024-04-23 13:33 ` Tomi Valkeinen
2024-04-23 13:33 ` Tomi Valkeinen
2024-04-23 14:59 ` Sean Anderson
2024-04-23 14:59 ` Sean Anderson
2024-04-23 15:30 ` Tomi Valkeinen
2024-04-23 15:30 ` Tomi Valkeinen
2024-04-23 15:39 ` Sean Anderson
2024-04-23 15:39 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422184553.3573009-1-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.