From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
Subject: Re: getting rid of type argument to rte_malloc().
Date: Wed, 24 Apr 2024 09:23:51 -0700 [thread overview]
Message-ID: <20240424092351.31878a12@hermes.local> (raw)
In-Reply-To: <6e2e5f6e-7ff0-404e-991b-836d496ad164@amd.com>
On Wed, 24 Apr 2024 11:29:51 +0100
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 4/24/2024 5:08 AM, Stephen Hemminger wrote:
> > For the 24.11 release, I want to remove the unused type string argument
> > that shows up in rte_malloc() and related functions, then percolates down
> > through. It was a idea in the 1.0 release of DPDK, never implemented and
> > never removed. Yes it will cause API breakage, a large sweeping change;
> > probably easily scripted with coccinelle.
> >
> > Maybe doing ABI version now?
> >
>
> Won't this impact many applications, is there big enough motivation to
> force many DPDK applications to update their code, living with it looks
> simpler.
>
Yeah, probably too big an impact but at least:
- change the documentation to say "do not use" should be NULL
- add script to remove all usage inside of DPDK
- get rid of places where useless arg is passed around inside
of the allocator internals.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
Subject: Re: getting rid of type argument to rte_malloc().
Date: Wed, 24 Apr 2024 09:23:58 -0700 [thread overview]
Message-ID: <20240424092351.31878a12@hermes.local> (raw)
Message-ID: <20240424162358.BJE6X0OcAYJGjd5RrgJ054XtPBMbAtOtJewYpivovqk@z> (raw)
In-Reply-To: <6e2e5f6e-7ff0-404e-991b-836d496ad164@amd.com>
On Wed, 24 Apr 2024 11:29:51 +0100
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 4/24/2024 5:08 AM, Stephen Hemminger wrote:
> > For the 24.11 release, I want to remove the unused type string argument
> > that shows up in rte_malloc() and related functions, then percolates down
> > through. It was a idea in the 1.0 release of DPDK, never implemented and
> > never removed. Yes it will cause API breakage, a large sweeping change;
> > probably easily scripted with coccinelle.
> >
> > Maybe doing ABI version now?
> >
>
> Won't this impact many applications, is there big enough motivation to
> force many DPDK applications to update their code, living with it looks
> simpler.
>
Yeah, probably too big an impact but at least:
- change the documentation to say "do not use" should be NULL
- add script to remove all usage inside of DPDK
- get rid of places where useless arg is passed around inside
of the allocator internals.
next prev parent reply other threads:[~2024-04-24 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 4:08 getting rid of type argument to rte_malloc() Stephen Hemminger
2024-04-24 10:29 ` Ferruh Yigit
2024-04-24 16:23 ` Stephen Hemminger [this message]
2024-04-24 16:23 ` Stephen Hemminger
2024-04-24 17:09 ` Morten Brørup
2024-04-24 19:05 ` Stephen Hemminger
2024-04-24 19:06 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424092351.31878a12@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.