From: Heiko Carstens <hca@linux.ibm.com>
To: Bui Quang Minh <minhquangbui99@gmail.com>
Cc: Subbaraya Sundeep <sbhatta@marvell.com>,
linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
linux-scsi@vger.kernel.org,
Saurav Kashyap <saurav.kashyap@cavium.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Linu Cherian <lcherian@marvell.com>,
linux-s390@vger.kernel.org,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
intel-wired-lan@lists.osuosl.org,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sunil Goutham <sgoutham@marvell.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Geetha sowjanya <gakula@marvell.com>,
Arun Easi <arun.easi@cavium.com>,
Fabian Frederick <fabf@skynet.be>,
Manish Rangankar <manish.rangankar@cavium.com>,
Jens Axboe <axboe@kernel.dk>,
Nilesh Javali <nilesh.javali@cavium.com>,
GR-Linux-NIC-Dev@marvell.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Saurav Kashyap <skashyap@marvell.com>,
Rasesh Mody <rmody@marvell.com>,
netdev@vger.kernel.org,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
GR-QLogic-Storage-Upstream@marvell.com,
hariprasad <hkelam@marvell.com>,
Sven Schnelle <svens@linux.ibm.com>,
Jerin Jacob <jerinj@marvell.com>,
Sudarsana Kalluru <skalluru@marvell.com>
Subject: Re: [Intel-wired-lan] [PATCH v2 5/6] cio: ensure the copied buf is NUL terminated
Date: Wed, 24 Apr 2024 16:54:05 +0200 [thread overview]
Message-ID: <20240424145405.26193-C-hca@linux.ibm.com> (raw)
In-Reply-To: <20240424-fix-oob-read-v2-5-f1f1b53a10f4@gmail.com>
On Wed, Apr 24, 2024 at 09:44:22PM +0700, Bui Quang Minh wrote:
> Currently, we allocate a lbuf-sized kernel buffer and copy lbuf from
> userspace to that buffer. Later, we use scanf on this buffer but we don't
> ensure that the string is terminated inside the buffer, this can lead to
> OOB read when using scanf. Fix this issue by using memdup_user_nul instead.
>
> Fixes: a4f17cc72671 ("s390/cio: add CRW inject functionality")
> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
> ---
> drivers/s390/cio/cio_inject.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Bui Quang Minh <minhquangbui99@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
Rasesh Mody <rmody@marvell.com>,
Sudarsana Kalluru <skalluru@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Fabian Frederick <fabf@skynet.be>,
Saurav Kashyap <skashyap@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Nilesh Javali <nilesh.javali@cavium.com>,
Arun Easi <arun.easi@cavium.com>,
Manish Rangankar <manish.rangankar@cavium.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Sunil Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Saurav Kashyap <saurav.kashyap@cavium.com>,
linux-s390@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 5/6] cio: ensure the copied buf is NUL terminated
Date: Wed, 24 Apr 2024 16:54:05 +0200 [thread overview]
Message-ID: <20240424145405.26193-C-hca@linux.ibm.com> (raw)
In-Reply-To: <20240424-fix-oob-read-v2-5-f1f1b53a10f4@gmail.com>
On Wed, Apr 24, 2024 at 09:44:22PM +0700, Bui Quang Minh wrote:
> Currently, we allocate a lbuf-sized kernel buffer and copy lbuf from
> userspace to that buffer. Later, we use scanf on this buffer but we don't
> ensure that the string is terminated inside the buffer, this can lead to
> OOB read when using scanf. Fix this issue by using memdup_user_nul instead.
>
> Fixes: a4f17cc72671 ("s390/cio: add CRW inject functionality")
> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
> ---
> drivers/s390/cio/cio_inject.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2024-04-24 15:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:44 [Intel-wired-lan] [PATCH v2 0/6] Ensure the copied buf is NUL terminated Bui Quang Minh
2024-04-24 14:44 ` Bui Quang Minh
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 1/6] ice: ensure " Bui Quang Minh
2024-04-24 14:44 ` Bui Quang Minh
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 2/6] bna: " Bui Quang Minh
2024-04-24 14:44 ` Bui Quang Minh
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 3/6] bfa: " Bui Quang Minh
2024-04-24 14:44 ` Bui Quang Minh
2024-05-07 1:19 ` [Intel-wired-lan] " Martin K. Petersen
2024-05-07 1:19 ` Martin K. Petersen
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 4/6] qedf: " Bui Quang Minh
2024-04-24 14:44 ` Bui Quang Minh
2024-05-07 1:20 ` [Intel-wired-lan] " Martin K. Petersen
2024-05-07 1:20 ` Martin K. Petersen
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 5/6] cio: " Bui Quang Minh
2024-04-24 14:44 ` Bui Quang Minh
2024-04-24 14:54 ` Heiko Carstens [this message]
2024-04-24 14:54 ` Heiko Carstens
2024-04-24 15:16 ` [Intel-wired-lan] " Alexander Gordeev
2024-04-24 15:16 ` Alexander Gordeev
2024-04-26 10:10 ` [Intel-wired-lan] " Alexander Gordeev
2024-04-26 10:10 ` Alexander Gordeev
2024-04-26 14:29 ` [Intel-wired-lan] " Jakub Kicinski
2024-04-26 14:29 ` Jakub Kicinski
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 6/6] octeontx2-af: avoid off-by-one read from userspace Bui Quang Minh
2024-04-24 14:44 ` Bui Quang Minh
2024-04-26 2:30 ` [Intel-wired-lan] [PATCH v2 0/6] Ensure the copied buf is NUL terminated patchwork-bot+netdevbpf
2024-04-26 2:30 ` patchwork-bot+netdevbpf
2024-05-11 18:39 ` [Intel-wired-lan] " Martin K. Petersen
2024-05-11 18:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424145405.26193-C-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arun.easi@cavium.com \
--cc=axboe@kernel.dk \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabf@skynet.be \
--cc=gakula@marvell.com \
--cc=gor@linux.ibm.com \
--cc=hkelam@marvell.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manish.rangankar@cavium.com \
--cc=martin.petersen@oracle.com \
--cc=minhquangbui99@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nilesh.javali@cavium.com \
--cc=oberpar@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
--cc=rmody@marvell.com \
--cc=saurav.kashyap@cavium.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=skalluru@marvell.com \
--cc=skashyap@marvell.com \
--cc=sudarsana.kalluru@qlogic.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.