All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: dev@openvswitch.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Aaron Conole <aconole@redhat.com>
Subject: Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements
Date: Thu, 25 Apr 2024 12:21:51 -0700	[thread overview]
Message-ID: <20240425122151.1d5efcc2@kernel.org> (raw)
In-Reply-To: <20240425185719.GV42092@kernel.org>

On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote:
> openvswitch.sh does not appear to have any dependencies on Open vSwitch
> user-space. My understanding is that, rather, it makes use of
> tools/testing/selftests/net/openvswitch/ovs-dpctl.py to talk to the Kernel
> using Netlink (which is also what Open vSwitch user-space does).
> 
> My brief testing indicates that for this the only dependencies
> when running on Amazon Linux 2 are python3 and pyroute2.
> 
> I think that it should be possible to port pmtu.sh to use ovs-dpctl.py.
> This would require some enhancements to ovs-dpctl.py to handle adding the
> tunnel vports (interfaces).
> 
> As an aside, to run the Open vSwitch tests in pmtu.sh the openvswitch
> kernel module is needed. So I think it would make sense to add
> CONFIG_OPENVSWITCH to tools/testing/selftests/net/config.
> 
> That would mean that tools/testing/selftests/net/config also has all
> the requirements to run openvswitch.sh. If so, we probably wouldn't need to
> add tools/testing/selftests/net/openvswitch/config or otherwise do anything
> special to configure the kernel for openvswitch.sh.

That sounds great, for simplicity we could move the ovs files down 
to the .../net/ directory. It'd be cool to not have to do that, and
let us separate tests more clearly into directories. But right now
every directory has its own runner so there's a high price to pay
for a primarily aesthetic gain :(

  reply	other threads:[~2024-04-25 19:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 16:44 selftests: openvswitch: Questions about possible enhancements Simon Horman
2024-04-24 17:37 ` [ovs-dev] " Simon Horman
2024-04-24 17:59   ` Benjamin Poirier
2024-04-24 18:14     ` Aaron Conole
2024-04-25  7:33     ` Simon Horman
2024-04-24 18:14 ` Aaron Conole
2024-04-25  7:40   ` Simon Horman
2024-04-25 20:00     ` Aaron Conole
2024-04-25  0:30 ` Jakub Kicinski
2024-04-25  8:26   ` Simon Horman
2024-04-25 18:57     ` [ovs-dev] " Simon Horman
2024-04-25 19:21       ` Jakub Kicinski [this message]
2024-04-25 20:04         ` Aaron Conole
2024-04-26  7:05         ` Simon Horman
2024-04-25 19:58   ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240425122151.1d5efcc2@kernel.org \
    --to=kuba@kernel.org \
    --cc=aconole@redhat.com \
    --cc=dev@openvswitch.org \
    --cc=horms@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.