From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: [PATCH i-g-t v2 04/10] lib/intel_bufops: Drop tilings restrictions
Date: Fri, 26 Apr 2024 11:01:11 +0200 [thread overview]
Message-ID: <20240426090117.78060-5-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240426090117.78060-1-zbigniew.kempczynski@intel.com>
Different platforms supports different tilings so instead of asserting
on buffer creation path move responsibility of passing valid data
to the test. It can use intel_cmds_info to iterate over supported
tilings so this is better extendible and requires fewer changes.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/intel_bufops.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
index 43d6dd5b43..3bf89798ba 100644
--- a/lib/intel_bufops.c
+++ b/lib/intel_bufops.c
@@ -898,9 +898,6 @@ static void __intel_buf_init(struct buf_ops *bops,
if (compression) {
igt_require(bops->intel_gen >= 9);
- igt_assert(req_tiling == I915_TILING_Y ||
- req_tiling == I915_TILING_Yf ||
- req_tiling == I915_TILING_4);
/*
* On GEN12+ we align the main surface to 4 * 4 main surface
* tiles, which is 64kB. These 16 tiles are mapped by 4 AUX
--
2.34.1
next prev parent reply other threads:[~2024-04-26 9:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 9:01 [PATCH i-g-t v2 00/10] Add render-copy compression on Xe+ Zbigniew Kempczyński
2024-04-26 9:01 ` [PATCH i-g-t v2 01/10] lib/intel_bufops: Store devid on buffer ops creation Zbigniew Kempczyński
2024-04-26 9:01 ` [PATCH i-g-t v2 02/10] lib/intel_blt: Rename confusing fb tile to i915 tile Zbigniew Kempczyński
2024-04-26 11:11 ` Karolina Stolarek
2024-04-26 11:27 ` Zbigniew Kempczyński
2024-04-26 11:46 ` Karolina Stolarek
2024-04-26 9:01 ` [PATCH i-g-t v2 03/10] lib/intel_blt: Add i915 -> blt tile helper converter Zbigniew Kempczyński
2024-04-26 11:04 ` Karolina Stolarek
2024-04-26 9:01 ` Zbigniew Kempczyński [this message]
2024-04-26 9:01 ` [PATCH i-g-t v2 05/10] lib/intel_bufops: Start supporting compression on Xe2+ Zbigniew Kempczyński
2024-04-26 9:01 ` [PATCH i-g-t v2 06/10] lib/rendercopy_gen9: Allow to use all tilings on flatccs platforms Zbigniew Kempczyński
2024-04-26 13:23 ` Karolina Stolarek
2024-04-26 9:01 ` [PATCH i-g-t v2 07/10] lib/intel_cmds_info: Define tiling macros Zbigniew Kempczyński
2024-04-26 13:14 ` Karolina Stolarek
2024-05-07 5:46 ` Zbigniew Kempczyński
2024-04-26 9:01 ` [PATCH i-g-t v2 08/10] lib/intel_cmds_info: Introduce render tilings Zbigniew Kempczyński
2024-04-26 13:18 ` Karolina Stolarek
2024-05-07 5:49 ` Zbigniew Kempczyński
2024-04-26 9:01 ` [PATCH i-g-t v2 09/10] lib/intel_blt: Add render tilings and compression support helper Zbigniew Kempczyński
2024-04-26 11:16 ` Karolina Stolarek
2024-04-26 13:19 ` Karolina Stolarek
2024-04-26 9:01 ` [PATCH i-g-t v2 10/10] tests/xe_render_copy: Add subtest which exercises compression Zbigniew Kempczyński
2024-04-26 10:03 ` ✓ Fi.CI.BAT: success for Add render-copy compression on Xe+ (rev2) Patchwork
2024-04-26 10:20 ` ✓ CI.xeBAT: " Patchwork
2024-04-26 12:12 ` ✗ CI.xeFULL: failure " Patchwork
2024-04-26 14:00 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426090117.78060-5-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.