All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karolina Stolarek <karolina.stolarek@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t v2 08/10] lib/intel_cmds_info: Introduce render tilings
Date: Fri, 26 Apr 2024 15:18:25 +0200	[thread overview]
Message-ID: <8c4fc09e-0a19-4dd9-a6d2-b9feb764002a@intel.com> (raw)
In-Reply-To: <20240426090117.78060-9-zbigniew.kempczynski@intel.com>


On 26.04.2024 11:01, Zbigniew Kempczyński wrote:> +struct 
render_tiling_info {
> +	uint32_t supported_tiling;
> +	uint32_t supported_compressed_tiling;
> +};
> +
>   struct intel_cmds_info {
>   	struct blt_cmd_info const *blt_cmds[__BLT_MAX_CMD];
> +	struct render_tiling_info const *render_tilings;

These two structs should share the naming convention, as they describe
the same thing but for two different copy operations.

There are two ways about it -- either rename blt_cmd_info to
blt_tiling_info in a separate patch or make the render one to be
something like render_cmd_info.

All the best,
Karolina

>   };
>   
>   extern const struct intel_cmds_info pre_gen6_cmds_info;

  reply	other threads:[~2024-04-26 13:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26  9:01 [PATCH i-g-t v2 00/10] Add render-copy compression on Xe+ Zbigniew Kempczyński
2024-04-26  9:01 ` [PATCH i-g-t v2 01/10] lib/intel_bufops: Store devid on buffer ops creation Zbigniew Kempczyński
2024-04-26  9:01 ` [PATCH i-g-t v2 02/10] lib/intel_blt: Rename confusing fb tile to i915 tile Zbigniew Kempczyński
2024-04-26 11:11   ` Karolina Stolarek
2024-04-26 11:27     ` Zbigniew Kempczyński
2024-04-26 11:46       ` Karolina Stolarek
2024-04-26  9:01 ` [PATCH i-g-t v2 03/10] lib/intel_blt: Add i915 -> blt tile helper converter Zbigniew Kempczyński
2024-04-26 11:04   ` Karolina Stolarek
2024-04-26  9:01 ` [PATCH i-g-t v2 04/10] lib/intel_bufops: Drop tilings restrictions Zbigniew Kempczyński
2024-04-26  9:01 ` [PATCH i-g-t v2 05/10] lib/intel_bufops: Start supporting compression on Xe2+ Zbigniew Kempczyński
2024-04-26  9:01 ` [PATCH i-g-t v2 06/10] lib/rendercopy_gen9: Allow to use all tilings on flatccs platforms Zbigniew Kempczyński
2024-04-26 13:23   ` Karolina Stolarek
2024-04-26  9:01 ` [PATCH i-g-t v2 07/10] lib/intel_cmds_info: Define tiling macros Zbigniew Kempczyński
2024-04-26 13:14   ` Karolina Stolarek
2024-05-07  5:46     ` Zbigniew Kempczyński
2024-04-26  9:01 ` [PATCH i-g-t v2 08/10] lib/intel_cmds_info: Introduce render tilings Zbigniew Kempczyński
2024-04-26 13:18   ` Karolina Stolarek [this message]
2024-05-07  5:49     ` Zbigniew Kempczyński
2024-04-26  9:01 ` [PATCH i-g-t v2 09/10] lib/intel_blt: Add render tilings and compression support helper Zbigniew Kempczyński
2024-04-26 11:16   ` Karolina Stolarek
2024-04-26 13:19   ` Karolina Stolarek
2024-04-26  9:01 ` [PATCH i-g-t v2 10/10] tests/xe_render_copy: Add subtest which exercises compression Zbigniew Kempczyński
2024-04-26 10:03 ` ✓ Fi.CI.BAT: success for Add render-copy compression on Xe+ (rev2) Patchwork
2024-04-26 10:20 ` ✓ CI.xeBAT: " Patchwork
2024-04-26 12:12 ` ✗ CI.xeFULL: failure " Patchwork
2024-04-26 14:00 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c4fc09e-0a19-4dd9-a6d2-b9feb764002a@intel.com \
    --to=karolina.stolarek@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.