Re: [PATCH v6 1/6] iommu/arm-smmu-v3: Pass in cmdq pointer to arm_smmu_cmdq_issue_cmdlist()

From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	thierry.reding@gmail.com, vdumpa@nvidia.com,
	jonathanh@nvidia.com, linux-kernel@vger.kernel.org,
	iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v6 1/6] iommu/arm-smmu-v3: Pass in cmdq pointer to arm_smmu_cmdq_issue_cmdlist()
Date: Tue, 30 Apr 2024 10:54:58 -0300	[thread overview]
Message-ID: <20240430135458.GO941030@nvidia.com> (raw)
In-Reply-To: <0acb55059f7212abdf4277a81e2f033127072bc9.1714451595.git.nicolinc@nvidia.com>

On Mon, Apr 29, 2024 at 09:43:44PM -0700, Nicolin Chen wrote:
> The driver currently calls arm_smmu_get_cmdq() helper in different places,
> although they are all called from the arm_smmu_cmdq_issue_cmdlist().
> 
> Allow to pass in the cmdq pointer, instead of calling arm_smmu_get_cmdq()
> every time.
> 
> This will also help CMDQV extension in NVIDIA Tegra241 SoC, as its driver
> will maintain its own cmdq pointers, then need to redirect arm_smmu->cmdq
> to one of its vcmdqs upon seeing a supported command.
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason