From: Simon Horman <horms@kernel.org>
To: Shi-Sheng Yang <fourcolor4c@gmail.com>
Cc: matttbe@kernel.org, martineau@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
geliang@kernel.org, netdev@vger.kernel.org,
mptcp@lists.linux.dev, linux-kernel@vger.kernel.org,
Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>
Subject: Re: [PATCH] mptcp: subflow.c: fix typo
Date: Tue, 30 Apr 2024 19:00:57 +0100 [thread overview]
Message-ID: <20240430180057.GB2575892@kernel.org> (raw)
In-Reply-To: <20240429225033.3920874-1-james1qaz2wsx12qw@gmail.com>
On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> Replace 'greceful' with 'graceful'.
>
> Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>
Hi Shi-Sheng Yang,
Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
Could you consider fixing that too?
Better still, could you consider running codespell over
net/mptcp/ and fixing (the non false-positives) that it flags?
If you do repost then I think an appropriate prefix
would be 'mctp: ' rather than 'mctp: subflow.c ',
as this follows the pattern in git history.
And I think the target tree should be net-next.
That is, the patch should be based on net-next and
it should be designated in the subject.
e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments
Lastly, please keep in mind that 24h should elapse
before posting a new version.
Link: https://docs.kernel.org/process/maintainer-netdev.html
...
next prev parent reply other threads:[~2024-04-30 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 22:50 [PATCH] mptcp: subflow.c: fix typo Shi-Sheng Yang
2024-04-29 23:36 ` MPTCP CI
2024-04-30 18:00 ` Simon Horman [this message]
2024-05-01 15:57 ` Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430180057.GB2575892@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fourcolor4c@gmail.com \
--cc=geliang@kernel.org \
--cc=james1qaz2wsx12qw@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.