[PATCH] mptcp: subflow.c: fix typo

[PATCH] mptcp: subflow.c: fix typo

[Shi-Sheng Yang]

Replace 'greceful' with 'graceful'.

Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>
---
 net/mptcp/subflow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 6042a47da61b..c794288f6224 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -1234,7 +1234,7 @@ static void mptcp_subflow_fail(struct mptcp_sock *msk, struct sock *ssk)
 	struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(ssk);
 	unsigned long fail_tout;
 
-	/* greceful failure can happen only on the MPC subflow */
+	/* graceful failure can happen only on the MPC subflow */
 	if (WARN_ON_ONCE(ssk != READ_ONCE(msk->first)))
 		return;
 
-- 
2.34.1

Re: [PATCH] mptcp: subflow.c: fix typo

[MPTCP CI]

Hi Shi-Sheng,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8886551433

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/b0b2f391531a
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=849072


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: [PATCH] mptcp: subflow.c: fix typo

[Simon Horman]

On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> Replace 'greceful' with 'graceful'.
> 
> Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>

Hi Shi-Sheng Yang,

Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
Could you consider fixing that too?

Better still, could you consider running codespell over
net/mptcp/ and fixing (the non false-positives) that it flags?

If you do repost then I think an appropriate prefix
would be 'mctp: ' rather than 'mctp: subflow.c ',
as this follows the pattern in git history.

And I think the target tree should be net-next.
That is, the patch should be based on net-next and
it should be designated in the subject.

e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments

Lastly, please keep in mind that 24h should elapse
before posting a new version.

Link: https://docs.kernel.org/process/maintainer-netdev.html

...

Re: [PATCH] mptcp: subflow.c: fix typo

[Kuan-Wei Chiu]

On Tue, Apr 30, 2024 at 07:00:57PM +0100, Simon Horman wrote:
> On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> > Replace 'greceful' with 'graceful'.
> > 
> > Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@gmail.com>
> 
> Hi Shi-Sheng Yang,
> 
> Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
> Could you consider fixing that too?
> 
> Better still, could you consider running codespell over
> net/mptcp/ and fixing (the non false-positives) that it flags?
> 
> If you do repost then I think an appropriate prefix
> would be 'mctp: ' rather than 'mctp: subflow.c ',
> as this follows the pattern in git history.
> 
> And I think the target tree should be net-next.
> That is, the patch should be based on net-next and
> it should be designated in the subject.
> 
> e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments
> 
> Lastly, please keep in mind that 24h should elapse
> before posting a new version.
> 
> Link: https://docs.kernel.org/process/maintainer-netdev.html
> 
> ...
>

Hi Shi-Sheng,

I also noticed that the email you sent and the email from SoB are not
the same, which causes checkpatch.pl to complain about the following
warning:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Shi-ShengYang fourcolor4c@gmail.com' != 'Signed-off-by: Shi-Sheng Yang james1qaz2wsx12qw@gmail.com'

total: 0 errors, 1 warning, 0 checks, 8 lines checked

Could you please address this issue in the next version as well?

Regards,
Kuan-Wei