Re: [PATCH 1/8] selftests: x86: Remove dependence of headers file

Re: [PATCH 1/8] selftests: x86: Remove dependence of headers file

[kernel test robot]

:::::: 
:::::: Manual check reason: "low confidence bisect report"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240501122918.3831734-2-usama.anjum@collabora.com>
References: <20240501122918.3831734-2-usama.anjum@collabora.com>
TO: Muhammad Usama Anjum <usama.anjum@collabora.com>
TO: Shuah Khan <skhan@linuxfoundation.org>
TO: Nathan Chancellor <nathan@kernel.org>
TO: Nick Desaulniers <ndesaulniers@google.com>
TO: Bill Wendling <morbo@google.com>
TO: Justin Stitt <justinstitt@google.com>
TO: Muhammad Usama Anjum <usama.anjum@collabora.com>
TO: Rick Edgecombe <rick.p.edgecombe@intel.com>
TO: "Mike Rapoport (IBM)" <rppt@kernel.org>
TO: Ingo Molnar <mingo@kernel.org>
TO: Dave Hansen <dave.hansen@linux.intel.com>
TO: Alexey Dobriyan <adobriyan@gmail.com>
TO: Binbin Wu <binbin.wu@linux.intel.com>
TO: "Chang S. Bae" <chang.seok.bae@intel.com>
TO: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
TO: linux-kselftest@vger.kernel.org
TO: linux-kernel@vger.kernel.org
TO: llvm@lists.linux.dev
CC: kernel@collabora.com

Hi Muhammad,

kernel test robot noticed the following build errors:

[auto build test ERROR on shuah-kselftest/next]
[also build test ERROR on shuah-kselftest/fixes linus/master v6.9-rc6 next-20240503]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/selftests-x86-Remove-dependence-of-headers-file/20240501-203158
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
patch link:    https://lore.kernel.org/r/20240501122918.3831734-2-usama.anjum%40collabora.com
patch subject: [PATCH 1/8] selftests: x86: Remove dependence of headers file
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
compiler: clang version 18.1.4 (https://github.com/llvm/llvm-project e6c3289804a67ea0bb6a86fadbe454dd93b8d855)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405042136.6JepEDCv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202405042136.6JepEDCv-lkp@intel.com/

All errors (new ones prefixed by >>):

>> <inline asm>:7:8: error: expected absolute expression
       7 |         .ifne . - test_page - 4096
         |               ^
>> <inline asm>:8:2: error: test page is not one page long
       8 |         .error "test page is not one page long"
         |         ^
   2 errors generated.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH 0/8] selftests: x86: build suite with clang

[Muhammad Usama Anjum]

This series fixes build errors found by clang to allow the x86 suite to
get built with the clang.

Unfortunately, there is one bug [1] in the clang becuase of which
extended asm isn't handled correctly by it and build fails for
sysret_rip.c. Hence even after this series the build of this test would
fail with clang. Should we disable this test for now when clang is used
until the bug is fixed in clang? Not sure. Any opinions?

[1] https://github.com/llvm/llvm-project/issues/53728

Muhammad Usama Anjum (8):
  selftests: x86: Remove dependence of headers file
  selftests: x86: check_initial_reg_state: remove -no-pie while using
    -static
  selftests: x86: test_vsyscall: remove unused function
  selftests: x86: fsgsbase_restore: fix asm directive from =rm to =r
  selftests: x86: syscall_arg_fault_32: remove unused variable
  selftests: x86: test_FISTTP: use fisttps instead of ambigous fisttp
  selftests: x86: fsgsbase: Remove unused function and variable
  selftests: x86: amx: Remove unused functions

 tools/testing/selftests/x86/Makefile            |  9 +++++----
 tools/testing/selftests/x86/amx.c               | 16 ----------------
 tools/testing/selftests/x86/fsgsbase.c          |  6 ------
 tools/testing/selftests/x86/fsgsbase_restore.c  |  2 +-
 tools/testing/selftests/x86/syscall_arg_fault.c |  1 -
 tools/testing/selftests/x86/test_FISTTP.c       |  8 ++++----
 tools/testing/selftests/x86/test_vsyscall.c     |  5 -----
 7 files changed, 10 insertions(+), 37 deletions(-)

-- 
2.39.2

[PATCH 1/8] selftests: x86: Remove dependence of headers file

[Muhammad Usama Anjum]

Remove header file dependence to remove the following error caught by
clang.

clang: error: cannot specify -o when generating multiple output files

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/x86/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 0b872c0a42d20..671b1819694ff 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -72,10 +72,10 @@ all_64: $(BINARIES_64)
 
 EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64)
 
-$(BINARIES_32): $(OUTPUT)/%_32: %.c helpers.h
+$(BINARIES_32): $(OUTPUT)/%_32: %.c
 	$(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl -lm
 
-$(BINARIES_64): $(OUTPUT)/%_64: %.c helpers.h
+$(BINARIES_64): $(OUTPUT)/%_64: %.c
 	$(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
 
 # x86_64 users should be encouraged to install 32-bit libraries
-- 
2.39.2