* [PATCH v2] nvmet: make nvmet_wq unbound
@ 2024-05-07 6:54 Sagi Grimberg
2024-05-07 7:25 ` Christoph Hellwig
2024-05-07 15:07 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Sagi Grimberg @ 2024-05-07 6:54 UTC (permalink / raw)
To: linux-nvme; +Cc: Christoph Hellwig, Keith Busch, Chaitanya Kulkarni
From: Sagi Grimberg <sagi.grimberg@vastdata.com>
When deleting many controllers one-by-one, it takes a very
long time as these work elements may serialize as they are
scheduled on the executing cpu instead of spreading. In general
nvmet_wq can definitely be used for long standing work elements
so its better to make it unbound regardless.
Signed-off-by: Sagi Grimberg <sagi.grimberg@vastdata.com>
---
Changes from v1:
- remove unneeded WQ_SYSFS
drivers/nvme/target/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index e06013c5dace..2fde22323622 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -1686,7 +1686,8 @@ static int __init nvmet_init(void)
if (!buffered_io_wq)
goto out_free_zbd_work_queue;
- nvmet_wq = alloc_workqueue("nvmet-wq", WQ_MEM_RECLAIM, 0);
+ nvmet_wq = alloc_workqueue("nvmet-wq",
+ WQ_MEM_RECLAIM | WQ_UNBOUND, 0);
if (!nvmet_wq)
goto out_free_buffered_work_queue;
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] nvmet: make nvmet_wq unbound
2024-05-07 6:54 [PATCH v2] nvmet: make nvmet_wq unbound Sagi Grimberg
@ 2024-05-07 7:25 ` Christoph Hellwig
2024-05-07 15:07 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-05-07 7:25 UTC (permalink / raw)
To: Sagi Grimberg
Cc: linux-nvme, Christoph Hellwig, Keith Busch, Chaitanya Kulkarni
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] nvmet: make nvmet_wq unbound
2024-05-07 6:54 [PATCH v2] nvmet: make nvmet_wq unbound Sagi Grimberg
2024-05-07 7:25 ` Christoph Hellwig
@ 2024-05-07 15:07 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2024-05-07 15:07 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: linux-nvme, Christoph Hellwig, Chaitanya Kulkarni
On Tue, May 07, 2024 at 09:54:10AM +0300, Sagi Grimberg wrote:
> From: Sagi Grimberg <sagi.grimberg@vastdata.com>
>
> When deleting many controllers one-by-one, it takes a very
> long time as these work elements may serialize as they are
> scheduled on the executing cpu instead of spreading. In general
> nvmet_wq can definitely be used for long standing work elements
> so its better to make it unbound regardless.
>
> Signed-off-by: Sagi Grimberg <sagi.grimberg@vastdata.com>
Applied to nvme-6.9, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-07 15:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-07 6:54 [PATCH v2] nvmet: make nvmet_wq unbound Sagi Grimberg
2024-05-07 7:25 ` Christoph Hellwig
2024-05-07 15:07 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.