All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Mayhew <smayhew@redhat.com>
To: kdevops@lists.linux.dev
Subject: [PATCH] nfstest: add the delegation test group
Date: Fri, 10 May 2024 11:58:04 -0400	[thread overview]
Message-ID: <20240510155804.21397-1-smayhew@redhat.com> (raw)

nfstest_delegation can use a second mount with a different nfs version
to trigger delegation recalls (i.e. it doesn't need to use a second
client), so it can be added to the nfstest workflow easily.

Note that the delegation test does show quite a few failures.  For
example, on a recent-ish Fedora kernel:

$ grep -Eh "^[0-9]+ tests" nfstest_delegation_20240510_152*.log
689 tests (623 passed, 66 failed)
1329 tests (1287 passed, 42 failed)
1329 tests (1287 passed, 42 failed)

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 playbooks/roles/nfstest/templates/delegation.sh.j2 | 13 +++++++++++++
 workflows/nfstest/Kconfig                          |  6 ++++++
 workflows/nfstest/Makefile                         |  3 +++
 3 files changed, 22 insertions(+)
 create mode 100755 playbooks/roles/nfstest/templates/delegation.sh.j2

diff --git a/playbooks/roles/nfstest/templates/delegation.sh.j2 b/playbooks/roles/nfstest/templates/delegation.sh.j2
new file mode 100755
index 0000000..ede24d4
--- /dev/null
+++ b/playbooks/roles/nfstest/templates/delegation.sh.j2
@@ -0,0 +1,13 @@
+#!/bin/bash
+
+export PYTHONPATH="{{ nfstest_install_dir }}"
+cd {{ nfstest_install_dir }}/test/
+
+for vers in 4.0 4.1 4.2
+do
+  ./nfstest_delegation --runtest=all --createlog --nfsversion=${vers} \
+	--server={{ nfstest_nfs_server_host }} \
+	--export=/export/{{ nfstest_nfs_server_export }}
+done
+
+exit 0
diff --git a/workflows/nfstest/Kconfig b/workflows/nfstest/Kconfig
index a029a56..e2f57aa 100644
--- a/workflows/nfstest/Kconfig
+++ b/workflows/nfstest/Kconfig
@@ -54,6 +54,12 @@ config NFSTEST_TEST_GROUP_ALLOC
 	help
 	  Provision a target node to test NFSv4.2 space reservation.
 
+config NFSTEST_TEST_GROUP_DELEGATION
+	bool "Enable the nfstest_delegation testing section"
+	default n
+	help
+	  Provision target nodes to test NFS delegations.
+
 config NFSTEST_TEST_GROUP_DIO
 	bool "Enable the nfstest_dio testing section"
 	default n
diff --git a/workflows/nfstest/Makefile b/workflows/nfstest/Makefile
index 638ec1f..8a92496 100644
--- a/workflows/nfstest/Makefile
+++ b/workflows/nfstest/Makefile
@@ -23,6 +23,9 @@ NFSTEST_ARGS += nfstest_repo_commit=$(NFSTEST_REPO_COMMIT)
 ifeq (y,$(CONFIG_NFSTEST_TEST_GROUP_ALLOC))
 NFSTEST_ENABLED_TEST_GROUPS += alloc
 endif
+ifeq (y,$(CONFIG_NFSTEST_TEST_GROUP_DELEGATION))
+NFSTEST_ENABLED_TEST_GROUPS += delegation
+endif
 ifeq (y,$(CONFIG_NFSTEST_TEST_GROUP_DIO))
 NFSTEST_ENABLED_TEST_GROUPS += dio
 endif
-- 
2.43.0


             reply	other threads:[~2024-05-10 15:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 15:58 Scott Mayhew [this message]
2024-05-10 16:02 ` [PATCH] nfstest: add the delegation test group Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510155804.21397-1-smayhew@redhat.com \
    --to=smayhew@redhat.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.