Re: [PATCH v8 3/7] drm/i915: Compute CMRR and calculate vtotal

[kernel test robot <lkp@intel.com>]

Hi Mitul,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20240510]
[cannot apply to drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.9-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mitul-Golani/drm-i915-Define-and-compute-Transcoder-CMRR-registers/20240509-160819
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20240509075833.1858363-4-mitulkumar.ajitkumar.golani%40intel.com
patch subject: [PATCH v8 3/7] drm/i915: Compute CMRR and calculate vtotal
config: arm-randconfig-001-20240511 (https://download.01.org/0day-ci/archive/20240511/202405110834.fRP3Ivmx-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project b910bebc300dafb30569cecc3017b446ea8eafa0)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240511/202405110834.fRP3Ivmx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405110834.fRP3Ivmx-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/display/intel_vrr.c:7:
   In file included from drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h:15:
   In file included from drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h:11:
   In file included from drivers/gpu/drm/xe/xe_bo.h:9:
   In file included from include/drm/ttm/ttm_tt.h:30:
   In file included from include/linux/pagemap.h:8:
   In file included from include/linux/mm.h:2210:
   include/linux/vmstat.h:522:36: error: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Werror,-Wenum-enum-conversion]
     522 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> drivers/gpu/drm/i915/display/intel_vrr.c:160:28: error: comparison of distinct pointer types ('typeof ((adjusted_pixel_rate)) *' (aka 'long long *') and 'uint64_t *' (aka 'unsigned long long *')) [-Werror,-Wcompare-distinct-pointer-types]
     160 |         crtc_state->cmrr.cmrr_m = do_div(adjusted_pixel_rate, crtc_state->cmrr.cmrr_n);
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/asm-generic/div64.h:222:28: note: expanded from macro 'do_div'
     222 |         (void)(((typeof((n)) *)0) == ((uint64_t *)0));  \
         |                ~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~
   2 errors generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS
   Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n]
   Selected by [m]:
   - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM_XE [=m] && DRM_XE [=m]=m


vim +160 drivers/gpu/drm/i915/display/intel_vrr.c

   134	
   135	static unsigned int
   136	cmrr_get_vtotal(struct intel_crtc_state *crtc_state)
   137	{
   138		int multiplier_m = 1, multiplier_n = 1, vtotal;
   139		int actual_refresh_rate, desired_refresh_rate;
   140		long long actual_pixel_rate, adjusted_pixel_rate, pixel_clock_per_line;
   141		struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
   142	
   143		pixel_clock_per_line =
   144			adjusted_mode->crtc_clock * 1000 / adjusted_mode->crtc_htotal;
   145		actual_refresh_rate =
   146			pixel_clock_per_line * FIXED_POINT_PRECISION / adjusted_mode->crtc_vtotal;
   147		desired_refresh_rate = drm_mode_vrefresh(adjusted_mode);
   148		actual_pixel_rate = actual_refresh_rate * adjusted_mode->crtc_vtotal;
   149		actual_pixel_rate =
   150			(actual_pixel_rate * adjusted_mode->crtc_htotal) / FIXED_POINT_PRECISION;
   151	
   152		multiplier_m = 1001;
   153		multiplier_n = 1000;
   154	
   155		crtc_state->cmrr.cmrr_n =
   156			((desired_refresh_rate * adjusted_mode->crtc_htotal * multiplier_n) / multiplier_m);
   157		crtc_state->cmrr.cmrr_n *= multiplier_n;
   158		vtotal = (actual_pixel_rate * multiplier_n) / crtc_state->cmrr.cmrr_n;
   159		adjusted_pixel_rate = actual_pixel_rate * multiplier_m;
 > 160		crtc_state->cmrr.cmrr_m = do_div(adjusted_pixel_rate, crtc_state->cmrr.cmrr_n);
   161	
   162		return vtotal;
   163	}
   164	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki