From: Simon Horman <horms@kernel.org>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, bartosz.golaszewski@linaro.org,
rohan.g.thomas@intel.com, rmk+kernel@armlinux.org.uk,
fancer.lancer@gmail.com, ahalaney@redhat.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH v5 1/2] net: stmmac: move the EST lock to struct stmmac_priv
Date: Sat, 11 May 2024 18:37:48 +0100 [thread overview]
Message-ID: <20240511173748.GR2347895@kernel.org> (raw)
In-Reply-To: <20240510122155.3394723-2-xiaolei.wang@windriver.com>
On Fri, May 10, 2024 at 08:21:54PM +0800, Xiaolei Wang wrote:
> Reinitialize the whole EST structure would also reset the mutex
> lock which is embedded in the EST structure, and then trigger
> the following warning. To address this, move the lock to struct
> stmmac_priv. We also need to reacquire the mutex lock when doing
> this initialization.
>
> DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> WARNING: CPU: 3 PID: 505 at kernel/locking/mutex.c:587 __mutex_lock+0xd84/0x1068
> Modules linked in:
> CPU: 3 PID: 505 Comm: tc Not tainted 6.9.0-rc6-00053-g0106679839f7-dirty #29
> Hardware name: NXP i.MX8MPlus EVK board (DT)
> pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> pc : __mutex_lock+0xd84/0x1068
> lr : __mutex_lock+0xd84/0x1068
> sp : ffffffc0864e3570
> x29: ffffffc0864e3570 x28: ffffffc0817bdc78 x27: 0000000000000003
> x26: ffffff80c54f1808 x25: ffffff80c9164080 x24: ffffffc080d723ac
> x23: 0000000000000000 x22: 0000000000000002 x21: 0000000000000000
> x20: 0000000000000000 x19: ffffffc083bc3000 x18: ffffffffffffffff
> x17: ffffffc08117b080 x16: 0000000000000002 x15: ffffff80d2d40000
> x14: 00000000000002da x13: ffffff80d2d404b8 x12: ffffffc082b5a5c8
> x11: ffffffc082bca680 x10: ffffffc082bb2640 x9 : ffffffc082bb2698
> x8 : 0000000000017fe8 x7 : c0000000ffffefff x6 : 0000000000000001
> x5 : ffffff8178fe0d48 x4 : 0000000000000000 x3 : 0000000000000027
> x2 : ffffff8178fe0d50 x1 : 0000000000000000 x0 : 0000000000000000
> Call trace:
> __mutex_lock+0xd84/0x1068
> mutex_lock_nested+0x28/0x34
> tc_setup_taprio+0x118/0x68c
> stmmac_setup_tc+0x50/0xf0
> taprio_change+0x868/0xc9c
>
> Fixes: b2aae654a479 ("net: stmmac: add mutex lock to protect est parameters")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, bartosz.golaszewski@linaro.org,
rohan.g.thomas@intel.com, rmk+kernel@armlinux.org.uk,
fancer.lancer@gmail.com, ahalaney@redhat.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH v5 1/2] net: stmmac: move the EST lock to struct stmmac_priv
Date: Sat, 11 May 2024 18:37:48 +0100 [thread overview]
Message-ID: <20240511173748.GR2347895@kernel.org> (raw)
In-Reply-To: <20240510122155.3394723-2-xiaolei.wang@windriver.com>
On Fri, May 10, 2024 at 08:21:54PM +0800, Xiaolei Wang wrote:
> Reinitialize the whole EST structure would also reset the mutex
> lock which is embedded in the EST structure, and then trigger
> the following warning. To address this, move the lock to struct
> stmmac_priv. We also need to reacquire the mutex lock when doing
> this initialization.
>
> DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> WARNING: CPU: 3 PID: 505 at kernel/locking/mutex.c:587 __mutex_lock+0xd84/0x1068
> Modules linked in:
> CPU: 3 PID: 505 Comm: tc Not tainted 6.9.0-rc6-00053-g0106679839f7-dirty #29
> Hardware name: NXP i.MX8MPlus EVK board (DT)
> pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> pc : __mutex_lock+0xd84/0x1068
> lr : __mutex_lock+0xd84/0x1068
> sp : ffffffc0864e3570
> x29: ffffffc0864e3570 x28: ffffffc0817bdc78 x27: 0000000000000003
> x26: ffffff80c54f1808 x25: ffffff80c9164080 x24: ffffffc080d723ac
> x23: 0000000000000000 x22: 0000000000000002 x21: 0000000000000000
> x20: 0000000000000000 x19: ffffffc083bc3000 x18: ffffffffffffffff
> x17: ffffffc08117b080 x16: 0000000000000002 x15: ffffff80d2d40000
> x14: 00000000000002da x13: ffffff80d2d404b8 x12: ffffffc082b5a5c8
> x11: ffffffc082bca680 x10: ffffffc082bb2640 x9 : ffffffc082bb2698
> x8 : 0000000000017fe8 x7 : c0000000ffffefff x6 : 0000000000000001
> x5 : ffffff8178fe0d48 x4 : 0000000000000000 x3 : 0000000000000027
> x2 : ffffff8178fe0d50 x1 : 0000000000000000 x0 : 0000000000000000
> Call trace:
> __mutex_lock+0xd84/0x1068
> mutex_lock_nested+0x28/0x34
> tc_setup_taprio+0x118/0x68c
> stmmac_setup_tc+0x50/0xf0
> taprio_change+0x868/0xc9c
>
> Fixes: b2aae654a479 ("net: stmmac: add mutex lock to protect est parameters")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-11 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 12:21 [net PATCH v5 0/2] Move EST lock and EST structure to struct stmmac_priv Xiaolei Wang
2024-05-10 12:21 ` Xiaolei Wang
2024-05-10 12:21 ` [net PATCH v5 1/2] net: stmmac: move the EST lock " Xiaolei Wang
2024-05-10 12:21 ` Xiaolei Wang
2024-05-11 17:37 ` Simon Horman [this message]
2024-05-11 17:37 ` Simon Horman
2024-05-11 18:01 ` Serge Semin
2024-05-11 18:01 ` Serge Semin
2024-05-10 12:21 ` [net PATCH v5 2/2] net: stmmac: move the EST structure " Xiaolei Wang
2024-05-10 12:21 ` Xiaolei Wang
2024-05-11 17:41 ` Simon Horman
2024-05-11 17:41 ` Simon Horman
2024-05-11 18:10 ` Serge Semin
2024-05-11 18:10 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240511173748.GR2347895@kernel.org \
--to=horms@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rohan.g.thomas@intel.com \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.