[Buildroot] [PATCH v2] package/nfs-utils: only install fsidd binary and unit file with enabled nfsd

[Buildroot] [PATCH v2] package/nfs-utils: only install fsidd binary and unit file with enabled nfsd

[Jan Čermák]

FSID daemon and its systemd unit file both depend on
BR2_PACKAGE_NFS_UTILS_RPC_NFSD but they're now always installed. Remove them
both if BR2_PACKAGE_NFS_UTILS_RPC_NFSD is disabled.

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Signed-off-by: Jan Čermák <sairon@sairon.cz>
---
 package/nfs-utils/nfs-utils.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index 4f2b41c782..b757e3e51d 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -42,7 +42,8 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPCDEBUG) += usr/sbin/rpcdebug
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_LOCKD) += usr/sbin/rpc.lockd
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_NFSD) += usr/sbin/exportfs \
-	usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service
+	usr/sbin/rpc.mountd usr/sbin/rpc.nfsd usr/lib/systemd/system/nfs-server.service \
+	usr/sbin/fsidd usr/lib/systemd/system/fsidd.service
 
 ifeq ($(BR2_PACKAGE_NFS_UTILS_NFSV4),y)
 NFS_UTILS_CONF_OPTS += --enable-nfsv4 --enable-nfsv41
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/nfs-utils: only install fsidd binary and unit file with enabled nfsd

[Thomas Petazzoni via buildroot]

On Fri,  1 Mar 2024 10:21:02 +0100
Jan Čermák <sairon@sairon.cz> wrote:

> FSID daemon and its systemd unit file both depend on
> BR2_PACKAGE_NFS_UTILS_RPC_NFSD but they're now always installed. Remove them
> both if BR2_PACKAGE_NFS_UTILS_RPC_NFSD is disabled.
> 
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Jan Čermák <sairon@sairon.cz>
> ---
>  package/nfs-utils/nfs-utils.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/nfs-utils: only install fsidd binary and unit file with enabled nfsd

[Peter Korsgaard]

>>>>> "Jan" == Jan Čermák <sairon@sairon.cz> writes:

 > FSID daemon and its systemd unit file both depend on
 > BR2_PACKAGE_NFS_UTILS_RPC_NFSD but they're now always installed. Remove them
 > both if BR2_PACKAGE_NFS_UTILS_RPC_NFSD is disabled.

 > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
 > Signed-off-by: Jan Čermák <sairon@sairon.cz>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot