From: Thinh Tran <thinhtr@linux.ibm.com>
To: netdev@vger.kernel.org, kuba@kernel.org,
anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com,
przemyslaw.kitszel@intel.com
Cc: edumazet@google.com, rob.thomas@ibm.com,
Thinh Tran <thinhtr@linux.ibm.com>,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
davem@davemloft.net
Subject: [Intel-wired-lan] [PATCH iwl-net V2, 0/2] Fix repeated EEH reports in MSI domain
Date: Mon, 13 May 2024 12:55:47 -0500 [thread overview]
Message-ID: <20240513175549.609-1-thinhtr@linux.ibm.com> (raw)
The patch fixes an issue where repeated EEH reports with a single error
on the bus of Intel X710 4-port 10G Base-T adapter in the MSI domain
causes the device to be permanently disabled. It fully resets and
restarts the device when handling the PCI EEH error.
Two new functions, i40e_io_suspend() and i40e_io_resume(), have been
introduced. These functions were factored out from the existing
i40e_suspend() and i40e_resume() respectively. This factoring was
done due to concerns about the logic of the I40E_SUSPENSED state, which
caused the device not able to recover. The functions are now used in the
EEH handling for device suspend/resume callbacks.
- In the PCI error detected callback, replaced i40e_prep_for_reset()
with i40e_io_suspend(). The change is to fully suspend all I/O
operations
- In the PCI error slot reset callback, replaced pci_enable_device_mem()
with pci_enable_device(). This change enables both I/O and memory of
the device.
- In the PCI error resume callback, replaced i40e_handle_reset_warning()
with i40e_io_resume(). This change allows the system to resume I/O
operations
v2: fixed typos and split into two commits
Thinh Tran (2):
i40e: fractoring out i40e_suspend/i40e_resume
i40e: Fully suspend and resume IO operations in EEH case
drivers/net/ethernet/intel/i40e/i40e_main.c | 257 +++++++++++---------
1 file changed, 140 insertions(+), 117 deletions(-)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Thinh Tran <thinhtr@linux.ibm.com>
To: netdev@vger.kernel.org, kuba@kernel.org,
anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com,
przemyslaw.kitszel@intel.com
Cc: jesse.brandeburg@intel.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, rob.thomas@ibm.com,
Thinh Tran <thinhtr@linux.ibm.com>
Subject: [PATCH iwl-net V2,0/2] Fix repeated EEH reports in MSI domain
Date: Mon, 13 May 2024 12:55:47 -0500 [thread overview]
Message-ID: <20240513175549.609-1-thinhtr@linux.ibm.com> (raw)
The patch fixes an issue where repeated EEH reports with a single error
on the bus of Intel X710 4-port 10G Base-T adapter in the MSI domain
causes the device to be permanently disabled. It fully resets and
restarts the device when handling the PCI EEH error.
Two new functions, i40e_io_suspend() and i40e_io_resume(), have been
introduced. These functions were factored out from the existing
i40e_suspend() and i40e_resume() respectively. This factoring was
done due to concerns about the logic of the I40E_SUSPENSED state, which
caused the device not able to recover. The functions are now used in the
EEH handling for device suspend/resume callbacks.
- In the PCI error detected callback, replaced i40e_prep_for_reset()
with i40e_io_suspend(). The change is to fully suspend all I/O
operations
- In the PCI error slot reset callback, replaced pci_enable_device_mem()
with pci_enable_device(). This change enables both I/O and memory of
the device.
- In the PCI error resume callback, replaced i40e_handle_reset_warning()
with i40e_io_resume(). This change allows the system to resume I/O
operations
v2: fixed typos and split into two commits
Thinh Tran (2):
i40e: fractoring out i40e_suspend/i40e_resume
i40e: Fully suspend and resume IO operations in EEH case
drivers/net/ethernet/intel/i40e/i40e_main.c | 257 +++++++++++---------
1 file changed, 140 insertions(+), 117 deletions(-)
--
2.25.1
next reply other threads:[~2024-05-13 17:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 17:55 Thinh Tran [this message]
2024-05-13 17:55 ` [PATCH iwl-net V2,0/2] Fix repeated EEH reports in MSI domain Thinh Tran
2024-05-13 17:55 ` [Intel-wired-lan] [PATCH iwl-net V2, 1/2] i40e: fractoring out i40e_suspend/i40e_resume Thinh Tran
2024-05-13 17:55 ` [PATCH iwl-net V2,1/2] " Thinh Tran
2024-05-13 17:55 ` [Intel-wired-lan] [PATCH iwl-net V2, 2/2] i40e: Fully suspend and resume IO operations in EEH case Thinh Tran
2024-05-13 17:55 ` [PATCH iwl-net V2,2/2] " Thinh Tran
2024-05-14 9:55 ` [Intel-wired-lan] [PATCH iwl-net V2, 0/2] Fix repeated EEH reports in MSI domain Simon Horman
2024-05-14 9:55 ` [PATCH iwl-net V2,0/2] " Simon Horman
2024-05-14 17:11 ` [Intel-wired-lan] [PATCH iwl-net V2, 0/2] " Jacob Keller
2024-05-14 19:52 ` Thinh Tran
2024-05-14 19:52 ` [PATCH iwl-net V2,0/2] " Thinh Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513175549.609-1-thinhtr@linux.ibm.com \
--to=thinhtr@linux.ibm.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rob.thomas@ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.