* [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for gcc 14.1.0
@ 2024-05-13 6:40 Neal Frager via buildroot
2024-05-13 6:40 ` [Buildroot] [PATCH v1 2/2] package/gcc-bare-metal: bump to " Neal Frager via buildroot
2024-05-13 19:58 ` [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for " Thomas Petazzoni via buildroot
0 siblings, 2 replies; 4+ messages in thread
From: Neal Frager via buildroot @ 2024-05-13 6:40 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, thomas.petazzoni, Neal Frager,
michal.simek
This patch is needed for building newlib with gcc 14.1.0. Without this patch,
the following build error will occur:
../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte':
../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration]
3 | _write(1, &c, 1);
This patch has been submitted upstream:
https://patchwork.sourceware.org/project/newlib/patch/20240513062419.2042278-1-neal.frager@amd.com/
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
...oblaze-fix-read-and-_write-declarati.patch | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch
diff --git a/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch
new file mode 100644
index 0000000000..8901f60c3c
--- /dev/null
+++ b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch
@@ -0,0 +1,39 @@
+From 1ebecb83607e9c0cc44ad1e518169ae03c0f2d26 Mon Sep 17 00:00:00 2001
+From: Neal Frager <neal.frager@amd.com>
+Date: Mon, 13 May 2024 07:22:47 +0100
+Subject: [PATCH] libgloss: microblaze: fix read and _write declarations
+
+This patch resolves the following build error which occurs with gcc 14.1.0:
+../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte':
+../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration]
+ 3 | _write(1, &c, 1);
+
+Signed-off-by: Neal Frager <neal.frager@amd.com>
+---
+ libgloss/microblaze/linux-inbyte.c | 2 ++
+ libgloss/microblaze/linux-outbyte.c | 2 ++
+ 2 files changed, 4 insertions(+)
+
+diff --git a/libgloss/microblaze/linux-inbyte.c b/libgloss/microblaze/linux-inbyte.c
+index 58fdf1957..2f8d33871 100644
+--- a/libgloss/microblaze/linux-inbyte.c
++++ b/libgloss/microblaze/linux-inbyte.c
+@@ -1,3 +1,5 @@
++extern int read (int, char *, int);
++
+ int inbyte(void)
+ {
+ char ch = 0;
+diff --git a/libgloss/microblaze/linux-outbyte.c b/libgloss/microblaze/linux-outbyte.c
+index 9d7bc4890..46de511f6 100644
+--- a/libgloss/microblaze/linux-outbyte.c
++++ b/libgloss/microblaze/linux-outbyte.c
+@@ -1,3 +1,5 @@
++extern int _write (int, char *, int);
++
+ void outbyte (unsigned char c)
+ {
+ _write(1, &c, 1);
+--
+2.25.1
+
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH v1 2/2] package/gcc-bare-metal: bump to gcc 14.1.0
2024-05-13 6:40 [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for gcc 14.1.0 Neal Frager via buildroot
@ 2024-05-13 6:40 ` Neal Frager via buildroot
2024-05-13 19:58 ` Thomas Petazzoni via buildroot
2024-05-13 19:58 ` [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for " Thomas Petazzoni via buildroot
1 sibling, 1 reply; 4+ messages in thread
From: Neal Frager via buildroot @ 2024-05-13 6:40 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, thomas.petazzoni, Neal Frager,
michal.simek
See here for changes:
https://gcc.gnu.org/gcc-14/changes.html
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
package/gcc-bare-metal/13.2.0 | 1 -
package/gcc-bare-metal/14.1.0 | 1 +
package/gcc-bare-metal/gcc-bare-metal.mk | 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
delete mode 120000 package/gcc-bare-metal/13.2.0
create mode 120000 package/gcc-bare-metal/14.1.0
diff --git a/package/gcc-bare-metal/13.2.0 b/package/gcc-bare-metal/13.2.0
deleted file mode 120000
index b7a75dc7dd..0000000000
--- a/package/gcc-bare-metal/13.2.0
+++ /dev/null
@@ -1 +0,0 @@
-../gcc/13.2.0/
\ No newline at end of file
diff --git a/package/gcc-bare-metal/14.1.0 b/package/gcc-bare-metal/14.1.0
new file mode 120000
index 0000000000..e519bfb6fd
--- /dev/null
+++ b/package/gcc-bare-metal/14.1.0
@@ -0,0 +1 @@
+../gcc/14.1.0/
\ No newline at end of file
diff --git a/package/gcc-bare-metal/gcc-bare-metal.mk b/package/gcc-bare-metal/gcc-bare-metal.mk
index 0dfc8d7a5c..2f36b49125 100644
--- a/package/gcc-bare-metal/gcc-bare-metal.mk
+++ b/package/gcc-bare-metal/gcc-bare-metal.mk
@@ -4,7 +4,7 @@
#
################################################################################
-HOST_GCC_BARE_METAL_VERSION = 13.2.0
+HOST_GCC_BARE_METAL_VERSION = 14.1.0
HOST_GCC_BARE_METAL_SITE = \
https://ftp.gnu.org/gnu/gcc/gcc-$(HOST_GCC_BARE_METAL_VERSION)
HOST_GCC_BARE_METAL_SOURCE = gcc-$(HOST_GCC_BARE_METAL_VERSION).tar.xz
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v1 2/2] package/gcc-bare-metal: bump to gcc 14.1.0
2024-05-13 6:40 ` [Buildroot] [PATCH v1 2/2] package/gcc-bare-metal: bump to " Neal Frager via buildroot
@ 2024-05-13 19:58 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-05-13 19:58 UTC (permalink / raw)
To: Neal Frager via buildroot
Cc: michal.simek, ibai.erkiaga-elorza, luca.ceresoli, Neal Frager
On Mon, 13 May 2024 07:40:39 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> See here for changes:
> https://gcc.gnu.org/gcc-14/changes.html
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> package/gcc-bare-metal/13.2.0 | 1 -
> package/gcc-bare-metal/14.1.0 | 1 +
> package/gcc-bare-metal/gcc-bare-metal.mk | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> delete mode 120000 package/gcc-bare-metal/13.2.0
> create mode 120000 package/gcc-bare-metal/14.1.0
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for gcc 14.1.0
2024-05-13 6:40 [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for gcc 14.1.0 Neal Frager via buildroot
2024-05-13 6:40 ` [Buildroot] [PATCH v1 2/2] package/gcc-bare-metal: bump to " Neal Frager via buildroot
@ 2024-05-13 19:58 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-05-13 19:58 UTC (permalink / raw)
To: Neal Frager via buildroot
Cc: michal.simek, ibai.erkiaga-elorza, luca.ceresoli, Neal Frager
Hello,
On Mon, 13 May 2024 07:40:38 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> This patch is needed for building newlib with gcc 14.1.0. Without this patch,
> the following build error will occur:
>
> ../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte':
> ../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration]
> 3 | _write(1, &c, 1);
>
> This patch has been submitted upstream:
> https://patchwork.sourceware.org/project/newlib/patch/20240513062419.2042278-1-neal.frager@amd.com/
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> ...oblaze-fix-read-and-_write-declarati.patch | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch
>
> diff --git a/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch
> new file mode 100644
> index 0000000000..8901f60c3c
> --- /dev/null
> +++ b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch
This patch should have been directly in package/newlib-bare-metal/,
there is no need for a per-version directory. Such subdirectories are
only needed when multiple versions of the package are supported (gcc,
binutils, gdb, etc.) but not for normal packages that have a fixed
version.
> @@ -0,0 +1,39 @@
> +From 1ebecb83607e9c0cc44ad1e518169ae03c0f2d26 Mon Sep 17 00:00:00 2001
> +From: Neal Frager <neal.frager@amd.com>
> +Date: Mon, 13 May 2024 07:22:47 +0100
> +Subject: [PATCH] libgloss: microblaze: fix read and _write declarations
> +
> +This patch resolves the following build error which occurs with gcc 14.1.0:
> +../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte':
> +../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration]
> + 3 | _write(1, &c, 1);
> +
> +Signed-off-by: Neal Frager <neal.frager@amd.com>
The "Upstream:" tag was missing here, and this issue was reported by
"make check-package":
WARNING: package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation)
I fixed both issues and applied. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-13 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-13 6:40 [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for gcc 14.1.0 Neal Frager via buildroot
2024-05-13 6:40 ` [Buildroot] [PATCH v1 2/2] package/gcc-bare-metal: bump to " Neal Frager via buildroot
2024-05-13 19:58 ` Thomas Petazzoni via buildroot
2024-05-13 19:58 ` [Buildroot] [PATCH v1 1/2] package/newlib-bare-metal: add patch for " Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.