From: Simon Horman <horms@kernel.org>
To: Thinh Tran <thinhtr@linux.ibm.com>
Cc: pmenzel@molgen.mpg.de, netdev@vger.kernel.org,
rob.thomas@ibm.com, aleksandr.loktionov@intel.com,
edumazet@google.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com,
Jacob Keller <jacob.e.keller@intel.com>,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net V4, 2/2] i40e: Fully suspend and resume IO operations in EEH case
Date: Thu, 16 May 2024 09:51:19 +0100 [thread overview]
Message-ID: <20240516085119.GH179178@kernel.org> (raw)
In-Reply-To: <20240515210705.620-3-thinhtr@linux.ibm.com>
On Wed, May 15, 2024 at 04:07:05PM -0500, Thinh Tran wrote:
> When EEH events occurs, the callback functions in the i40e, which are
> managed by the EEH driver, will completely suspend and resume all IO
> operations.
>
> - In the PCI error detected callback, replaced i40e_prep_for_reset()
> with i40e_io_suspend(). The change is to fully suspend all I/O
> operations
> - In the PCI error slot reset callback, replaced pci_enable_device_mem()
> with pci_enable_device(). This change enables both I/O and memory of
> the device.
> - In the PCI error resume callback, replaced i40e_handle_reset_warning()
> with i40e_io_resume(). This change allows the system to resume I/O
> operations
>
> Fixes: a5f3d2c17b07 ("powerpc/pseries/pci: Add MSI domains")
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Tested-by: Robert Thomas <rob.thomas@ibm.com>
> Signed-off-by: Thinh Tran <thinhtr@linux.ibm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Thinh Tran <thinhtr@linux.ibm.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com,
przemyslaw.kitszel@intel.com, pmenzel@molgen.mpg.de,
jesse.brandeburg@intel.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, rob.thomas@ibm.com,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH iwl-net V4,2/2] i40e: Fully suspend and resume IO operations in EEH case
Date: Thu, 16 May 2024 09:51:19 +0100 [thread overview]
Message-ID: <20240516085119.GH179178@kernel.org> (raw)
In-Reply-To: <20240515210705.620-3-thinhtr@linux.ibm.com>
On Wed, May 15, 2024 at 04:07:05PM -0500, Thinh Tran wrote:
> When EEH events occurs, the callback functions in the i40e, which are
> managed by the EEH driver, will completely suspend and resume all IO
> operations.
>
> - In the PCI error detected callback, replaced i40e_prep_for_reset()
> with i40e_io_suspend(). The change is to fully suspend all I/O
> operations
> - In the PCI error slot reset callback, replaced pci_enable_device_mem()
> with pci_enable_device(). This change enables both I/O and memory of
> the device.
> - In the PCI error resume callback, replaced i40e_handle_reset_warning()
> with i40e_io_resume(). This change allows the system to resume I/O
> operations
>
> Fixes: a5f3d2c17b07 ("powerpc/pseries/pci: Add MSI domains")
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Tested-by: Robert Thomas <rob.thomas@ibm.com>
> Signed-off-by: Thinh Tran <thinhtr@linux.ibm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-16 8:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 21:07 [Intel-wired-lan] [PATCH iwl-net V4, 0/2] Fix repeated EEH reports in MSI domain Thinh Tran
2024-05-15 21:07 ` [PATCH iwl-net V4,0/2] " Thinh Tran
2024-05-15 21:07 ` [Intel-wired-lan] [PATCH iwl-net V4, 1/2] i40e: factoring out i40e_suspend/i40e_resume Thinh Tran
2024-05-15 21:07 ` [PATCH iwl-net V4,1/2] " Thinh Tran
2024-05-16 8:50 ` [Intel-wired-lan] [PATCH iwl-net V4, 1/2] " Simon Horman
2024-05-16 8:50 ` [PATCH iwl-net V4,1/2] " Simon Horman
2024-05-16 19:11 ` [Intel-wired-lan] [PATCH iwl-net V4, 1/2] " Jacob Keller
2024-05-16 19:11 ` Jacob Keller
2024-05-16 21:34 ` Thinh Tran
2024-05-16 21:34 ` Thinh Tran
2024-05-23 17:57 ` Pucha, HimasekharX Reddy
2024-05-23 17:57 ` Pucha, HimasekharX Reddy
2024-05-15 21:07 ` [Intel-wired-lan] [PATCH iwl-net V4, 2/2] i40e: Fully suspend and resume IO operations in EEH case Thinh Tran
2024-05-15 21:07 ` [PATCH iwl-net V4,2/2] " Thinh Tran
2024-05-16 8:51 ` Simon Horman [this message]
2024-05-16 8:51 ` Simon Horman
2024-05-23 17:59 ` [Intel-wired-lan] [PATCH iwl-net V4, 2/2] " Pucha, HimasekharX Reddy
2024-05-23 17:59 ` Pucha, HimasekharX Reddy
2025-08-07 4:50 ` Lukas Wunner
2025-08-07 4:50 ` [PATCH iwl-net V4,2/2] " Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516085119.GH179178@kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=rob.thomas@ibm.com \
--cc=thinhtr@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.