All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: implement AQ download pkg retry
Date: Thu, 16 May 2024 15:56:27 +0100	[thread overview]
Message-ID: <20240516145627.GB443576@kernel.org> (raw)
In-Reply-To: <20240516140426.60439-1-wojciech.drewek@intel.com>

On Thu, May 16, 2024 at 04:04:26PM +0200, Wojciech Drewek wrote:
> ice_aqc_opc_download_pkg (0x0C40) AQ sporadically returns error due
> to FW issue. Fix this by retrying five times before moving to
> Safe Mode.

Hi Wojciech,

As this is for iwl-net, and therefore net, please consider supplying a
Fixes tag.

Otherwise this looks good to me.

> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>

...

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH iwl-net] ice: implement AQ download pkg retry
Date: Thu, 16 May 2024 15:56:27 +0100	[thread overview]
Message-ID: <20240516145627.GB443576@kernel.org> (raw)
In-Reply-To: <20240516140426.60439-1-wojciech.drewek@intel.com>

On Thu, May 16, 2024 at 04:04:26PM +0200, Wojciech Drewek wrote:
> ice_aqc_opc_download_pkg (0x0C40) AQ sporadically returns error due
> to FW issue. Fix this by retrying five times before moving to
> Safe Mode.

Hi Wojciech,

As this is for iwl-net, and therefore net, please consider supplying a
Fixes tag.

Otherwise this looks good to me.

> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>

...

  reply	other threads:[~2024-05-16 14:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 14:04 [Intel-wired-lan] [PATCH iwl-net] ice: implement AQ download pkg retry Wojciech Drewek
2024-05-16 14:04 ` Wojciech Drewek
2024-05-16 14:56 ` Simon Horman [this message]
2024-05-16 14:56   ` Simon Horman
2024-05-17  7:42   ` [Intel-wired-lan] " Wojciech Drewek
2024-05-17  7:42     ` Wojciech Drewek
2024-05-16 16:36 ` [Intel-wired-lan] " Brett Creeley
2024-05-16 16:36   ` Brett Creeley
2024-05-17  7:49   ` [Intel-wired-lan] " Wojciech Drewek
2024-05-17  7:49     ` Wojciech Drewek
2024-05-17  8:29     ` [Intel-wired-lan] " Przemek Kitszel
2024-05-17  8:29       ` Przemek Kitszel
2024-05-17  7:26 ` Naveen Mamindlapalli
2024-05-17  7:26   ` Naveen Mamindlapalli
2024-05-17  7:51   ` [Intel-wired-lan] " Wojciech Drewek
2024-05-17  7:51     ` Wojciech Drewek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516145627.GB443576@kernel.org \
    --to=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.