All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] mtd: rawnand: onfi: read parameter pages in one go
Date: Thu, 16 May 2024 15:09:25 +0200	[thread overview]
Message-ID: <20240516150925.5c65319b@xps-13> (raw)
In-Reply-To: <ZkXylC2xrlqGW_xV@pengutronix.de>

Hi Sascha,

> > > > nand_read_data_op() is not supported by all NAND controllers.
> > > > nand_change_read_column_op() is not supported or at least is hard to
> > > > support by NAND controllers that use a different page layout than
> > > > expected by the NAND core.    
> > > 
> > > I'm sorry but RNDOUT is not so hard to support, and I know no NAND
> > > controller without this feature (I think even the first mxc controller
> > > supports it?). However, the command does not exist on small page NANDs
> > > (512 bytes).  
> > 
> > Nevermind, the ONFI spec (in all versions) states that RNDOUT are
> > allowed during parameter page reads, regardless of the size of the chip
> > (at least, that is not mentioned).  
> 
> I could imagine that there are no ONFI compliant chips with small pages,
> I don't know how to verify this though.
> 
> Anyway, this was a try to make reading the parameter pages a bit more
> straight forward. It seems the MXC NAND controller can't support reading
> three parameter pages in one go either. It works in software ECC mode
> because I reverse the syndome type layout the controller introduces, but
> it can't work with hardware ECC.

Hardware ECC should not be used at this step and should be disabled.
There should not be any ECC interference.

> So disregard this patch.

I now have a proposal, I'll send a v2 of my previous series.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] mtd: rawnand: onfi: read parameter pages in one go
Date: Thu, 16 May 2024 15:09:25 +0200	[thread overview]
Message-ID: <20240516150925.5c65319b@xps-13> (raw)
In-Reply-To: <ZkXylC2xrlqGW_xV@pengutronix.de>

Hi Sascha,

> > > > nand_read_data_op() is not supported by all NAND controllers.
> > > > nand_change_read_column_op() is not supported or at least is hard to
> > > > support by NAND controllers that use a different page layout than
> > > > expected by the NAND core.    
> > > 
> > > I'm sorry but RNDOUT is not so hard to support, and I know no NAND
> > > controller without this feature (I think even the first mxc controller
> > > supports it?). However, the command does not exist on small page NANDs
> > > (512 bytes).  
> > 
> > Nevermind, the ONFI spec (in all versions) states that RNDOUT are
> > allowed during parameter page reads, regardless of the size of the chip
> > (at least, that is not mentioned).  
> 
> I could imagine that there are no ONFI compliant chips with small pages,
> I don't know how to verify this though.
> 
> Anyway, this was a try to make reading the parameter pages a bit more
> straight forward. It seems the MXC NAND controller can't support reading
> three parameter pages in one go either. It works in software ECC mode
> because I reverse the syndome type layout the controller introduces, but
> it can't work with hardware ECC.

Hardware ECC should not be used at this step and should be disabled.
There should not be any ECC interference.

> So disregard this patch.

I now have a proposal, I'll send a v2 of my previous series.

Thanks,
Miquèl

  reply	other threads:[~2024-05-16 13:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 13:41 [PATCH] mtd: rawnand: onfi: read parameter pages in one go Sascha Hauer
2024-05-14 13:41 ` Sascha Hauer
2024-05-16  8:13 ` Miquel Raynal
2024-05-16  8:13   ` Miquel Raynal
2024-05-16  9:58   ` Miquel Raynal
2024-05-16  9:58     ` Miquel Raynal
2024-05-16 11:48     ` Sascha Hauer
2024-05-16 11:48       ` Sascha Hauer
2024-05-16 13:09       ` Miquel Raynal [this message]
2024-05-16 13:09         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516150925.5c65319b@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.