Re: [PATCH v16 00/22] Refactoring Microchip PCIe driver and add StarFive PCIe

From: "Krzysztof Wilczyński" <kw@linux.com>
To: Minda Chen <minda.chen@starfivetech.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Conor Dooley <conor@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Daire McNamara <daire.mcnamara@microchip.com>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mason Huo <mason.huo@starfivetech.com>,
	Leyfoon Tan <leyfoon.tan@starfivetech.com>,
	Kevin Xie <kevin.xie@starfivetech.com>
Subject: Re: [PATCH v16 00/22] Refactoring Microchip PCIe driver and add StarFive PCIe
Date: Fri, 17 May 2024 20:16:26 +0900	[thread overview]
Message-ID: <20240517111626.GP202520@rocinante> (raw)
In-Reply-To: <20240328091835.14797-1-minda.chen@starfivetech.com>

Hello,

> This patchset final purpose is add PCIe driver for StarFive JH7110 SoC.
> JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the
> same IP and have commit their codes, which are mixed with PLDA
> controller codes and Microchip platform codes.
> 
> For re-use the PLDA controller codes, I request refactoring microchip
> codes, move PLDA common codes to PLDA files.
> Desigware and Cadence is good example for refactoring codes.

Applied to controller/microchip, thank you!

[01/21] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties
        https://git.kernel.org/pci/pci/c/0ce827c82eea
[02/21] dt-bindings: PCI: Add StarFive JH7110 PCIe controller
        https://git.kernel.org/pci/pci/c/91b4524c9135
[03/21] PCI: Add PCIE_RESET_CONFIG_DEVICE_WAIT_MS waiting time value
        https://git.kernel.org/pci/pci/c/4b83a1379e8c
[04/21] PCI: microchip: Move pcie-microchip-host.c to PLDA directory
        https://git.kernel.org/pci/pci/c/ced442bf0124
[05/21] PCI: microchip: Move PLDA IP register macros to pcie-plda.h
        https://git.kernel.org/pci/pci/c/571f57cc281c
[06/21] PCI: microchip: Add bridge_addr field to struct mc_pcie
        https://git.kernel.org/pci/pci/c/73c9dcd35dd8
[07/21] PCI: microchip: Rename two PCIe data structures
        https://git.kernel.org/pci/pci/c/e92d66e0aa1e
[08/08] PCI: microchip: Move PCIe host data structures to plda-pcie.h
        https://git.kernel.org/pci/pci/c/79c0d7d53a51
[09/21] PCI: microchip: Rename two setup functions
        https://git.kernel.org/pci/pci/c/082bda75f7b0
[10/21] PCI: microchip: Change the argument of plda_pcie_setup_iomems()
        https://git.kernel.org/pci/pci/c/9251a0b72188
[11/21] PCI: microchip: Move setup functions to pcie-plda-host.c
        https://git.kernel.org/pci/pci/c/047cc7da3a25
[12/21] PCI: microchip: Rename interrupt related functions
        https://git.kernel.org/pci/pci/c/ddac0618211f
[13/21] PCI: microchip: Add num_events field to struct plda_pcie_rp
        https://git.kernel.org/pci/pci/c/cb90f7f6145b
[14/21] PCI: microchip: Add request_event_irq() callback function
        https://git.kernel.org/pci/pci/c/0ffbe1c70551
[15/21] PCI: microchip: Add INTx and MSI event num to struct plda_event
        https://git.kernel.org/pci/pci/c/9932c5d45e5a
[16/21] PCI: microchip: Add get_events() callback and add PLDA get_event()
        https://git.kernel.org/pci/pci/c/170407afbcc4
[17/21] PCI: microchip: Add event irqchip field to host port and add PLDA irqchip
        https://git.kernel.org/pci/pci/c/5e33af45dbcb
[18/21] PCI: microchip: Move IRQ functions to pcie-plda-host.c
        https://git.kernel.org/pci/pci/c/4e47aaf7afed
[19/21] PCI: plda: Add event bitmap field to struct plda_pcie_rp
        https://git.kernel.org/pci/pci/c/008d2bc41e3c
[20/21] PCI: plda: Add host init/deinit and map bus functions
        https://git.kernel.org/pci/pci/c/d86b148a401c
[21/21] PCI: starfive: Add JH7110 PCIe controller
        https://git.kernel.org/pci/pci/c/e6e7b974e425

	Krzysztof