From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Arthur Becker <arthur.becker@sentec.com>,
"robh@kernel.org" <robh@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: iio: light: add veml6040 RGBW-LS bindings
Date: Sun, 19 May 2024 12:57:05 +0100 [thread overview]
Message-ID: <20240519125705.49967e97@jic23-huawei> (raw)
In-Reply-To: <20240513-repulsive-fiftieth-884b3805472f@spud>
On Mon, 13 May 2024 17:26:12 +0100
Conor Dooley <conor@kernel.org> wrote:
> On Mon, May 13, 2024 at 02:35:44PM +0000, Arthur Becker wrote:
> > This commit adds device tree bindings for the veml6040 RGBW Light Sensor
> >
> > signed-off-by: Arthur Becker <arthur.becker@sentec.com>
>
> If you're writing a standalone binding for this and not putting it into
> trivial-devices.yaml you should document the supply for this device.
It's a broken email thread. Driver is there, but soemthing has gone
wrong with sending.
Arthur, if this is a company email setup thing, consider the b4 web portal
method for v2.
Jonathan
>
> > ---
> >
> > .../bindings/iio/light/veml6040.yaml | 43 +++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/light/veml6040.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/veml6040.yaml b/Documentation/devicetree/bindings/iio/light/veml6040.yaml
> > new file mode 100644
> > index 000000000000..796c22f75575
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/veml6040.yaml
>
> Filename matching the compatible please.
>
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/light/veml6040.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: VEML6040 RGBW Light Sensor
> > +
> > +maintainers:
> > + - Arthur Becker <arthur.becker@sentec.com>
> > +
> > +description: |
>
> This | isn;t needed, you've got no formatting to preserve.
>
>
> Cheers,
> Conor.
next prev parent reply other threads:[~2024-05-19 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 14:35 [PATCH] dt-bindings: iio: light: add veml6040 RGBW-LS bindings Arthur Becker
2024-05-13 16:26 ` Conor Dooley
2024-05-19 11:57 ` Jonathan Cameron [this message]
2024-05-19 12:02 ` Conor Dooley
2024-05-19 12:25 ` Jonathan Cameron
2024-05-14 7:10 ` Krzysztof Kozlowski
2024-05-14 7:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240519125705.49967e97@jic23-huawei \
--to=jic23@kernel.org \
--cc=arthur.becker@sentec.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.