Re: [PATCH] dt-bindings: iio: light: add veml6040 RGBW-LS bindings

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 13 May 2024 17:26:12 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Mon, May 13, 2024 at 02:35:44PM +0000, Arthur Becker wrote:
> > This commit adds device tree bindings for the veml6040 RGBW Light Sensor
> > 
> > signed-off-by: Arthur Becker <arthur.becker@sentec.com>  
> 
> If you're writing a standalone binding for this and not putting it into
> trivial-devices.yaml you should document the supply for this device.
> 

Plus turn it on in the driver! In many cases supplies are hardwired
to on, but it the regulator framework will happily deal with that
by supplying a fake regulator.  The binding should however reflect that
the sensor needs power and list it as required.  Ideal is dts
files that do list fixed supplies but the fallback to a fake one will
work if not.

Jonathan
> > ---
> > 
> >  .../bindings/iio/light/veml6040.yaml          | 43 +++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/light/veml6040.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/light/veml6040.yaml b/Documentation/devicetree/bindings/iio/light/veml6040.yaml
> > new file mode 100644
> > index 000000000000..796c22f75575
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/veml6040.yaml  
> 
> Filename matching the compatible please.
> 
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/light/veml6040.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: VEML6040 RGBW Light Sensor
> > +
> > +maintainers:
> > +  - Arthur Becker <arthur.becker@sentec.com>
> > +
> > +description: |  
> 
> This | isn;t needed, you've got no formatting to preserve.
> 
> 
> Cheers,
> Conor.