[PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63
@ 2023-11-02 18:19 Clayton Craft
  2023-11-03 17:28 ` Jessica Zhang
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Clayton Craft @ 2023-11-02 18:19 UTC (permalink / raw)
  To: dri-devel

This panel is found on laptops e.g., variants of the Thinkpad X13s.
Configuration was collected from the panel's EDID.

Signed-off-by: Clayton Craft <clayton@craftyguy.net>
---

V2: renamed to "*_mode" since there is only 1 mode listed

 drivers/gpu/drm/panel/panel-edp.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 95c8472d878a..e2e4d88a5159 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1204,6 +1204,29 @@ static const struct panel_desc boe_nv133fhm_n61 = {
 	},
 };
 
+static const struct drm_display_mode boe_nv133wum_n63_mode = {
+	.clock = 157760,
+	.hdisplay = 1920,
+	.hsync_start = 1920 + 48,
+	.hsync_end = 1920 + 48 + 32,
+	.htotal = 1920 + 48 + 32 + 80,
+	.vdisplay = 1200,
+	.vsync_start = 1200 + 3,
+	.vsync_end = 1200 + 3 + 6,
+	.vtotal = 1200 + 3 + 6 + 31,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc boe_nv133wum_n63 = {
+	.modes = &boe_nv133wum_n63_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 286,
+		.height = 179,
+	},
+};
+
 static const struct drm_display_mode boe_nv140fhmn49_modes[] = {
 	{
 		.clock = 148500,
@@ -1723,6 +1746,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "boe,nv133fhm-n62",
 		.data = &boe_nv133fhm_n61,
+	}, {
+		.compatible = "boe,nv133wum-n63",
+		.data = &boe_nv133wum_n63,
 	}, {
 		.compatible = "boe,nv140fhmn49",
 		.data = &boe_nv140fhmn49,
@@ -1852,6 +1878,7 @@ static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x095f, &delay_200_500_e50, "NE135FBM-N41 v8.1"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x098d, &boe_nv110wtm_n61.delay, "NV110WTM-N61"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x09dd, &delay_200_500_e50, "NT116WHM-N21"),
+	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
 
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63
  2023-11-02 18:19 [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63 Clayton Craft
@ 2023-11-03 17:28 ` Jessica Zhang
  2023-11-03 22:28 ` Dmitry Baryshkov
  2024-05-20 21:03 ` [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63 Dmitry Baryshkov
  2 siblings, 0 replies; 7+ messages in thread
From: Jessica Zhang @ 2023-11-03 17:28 UTC (permalink / raw)
  To: Clayton Craft, dri-devel



On 11/2/2023 11:19 AM, Clayton Craft wrote:
> This panel is found on laptops e.g., variants of the Thinkpad X13s.
> Configuration was collected from the panel's EDID.
> 
> Signed-off-by: Clayton Craft <clayton@craftyguy.net>

LGTM

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang


> ---
> 
> V2: renamed to "*_mode" since there is only 1 mode listed
> 
>   drivers/gpu/drm/panel/panel-edp.c | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 95c8472d878a..e2e4d88a5159 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1204,6 +1204,29 @@ static const struct panel_desc boe_nv133fhm_n61 = {
>   	},
>   };
>   
> +static const struct drm_display_mode boe_nv133wum_n63_mode = {
> +	.clock = 157760,
> +	.hdisplay = 1920,
> +	.hsync_start = 1920 + 48,
> +	.hsync_end = 1920 + 48 + 32,
> +	.htotal = 1920 + 48 + 32 + 80,
> +	.vdisplay = 1200,
> +	.vsync_start = 1200 + 3,
> +	.vsync_end = 1200 + 3 + 6,
> +	.vtotal = 1200 + 3 + 6 + 31,
> +	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc boe_nv133wum_n63 = {
> +	.modes = &boe_nv133wum_n63_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 286,
> +		.height = 179,
> +	},
> +};
> +
>   static const struct drm_display_mode boe_nv140fhmn49_modes[] = {
>   	{
>   		.clock = 148500,
> @@ -1723,6 +1746,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "boe,nv133fhm-n62",
>   		.data = &boe_nv133fhm_n61,
> +	}, {
> +		.compatible = "boe,nv133wum-n63",
> +		.data = &boe_nv133wum_n63,
>   	}, {
>   		.compatible = "boe,nv140fhmn49",
>   		.data = &boe_nv140fhmn49,
> @@ -1852,6 +1878,7 @@ static const struct edp_panel_entry edp_panels[] = {
>   	EDP_PANEL_ENTRY('B', 'O', 'E', 0x095f, &delay_200_500_e50, "NE135FBM-N41 v8.1"),
>   	EDP_PANEL_ENTRY('B', 'O', 'E', 0x098d, &boe_nv110wtm_n61.delay, "NV110WTM-N61"),
>   	EDP_PANEL_ENTRY('B', 'O', 'E', 0x09dd, &delay_200_500_e50, "NT116WHM-N21"),
> +	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
>   	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
>   	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
>   
> -- 
> 2.40.1
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63
  2023-11-02 18:19 [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63 Clayton Craft
  2023-11-03 17:28 ` Jessica Zhang
@ 2023-11-03 22:28 ` Dmitry Baryshkov
  2024-05-20 20:06   ` [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel Clayton Craft
  2024-05-20 21:03 ` [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63 Dmitry Baryshkov
  2 siblings, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2023-11-03 22:28 UTC (permalink / raw)
  To: Clayton Craft; +Cc: dri-devel

On Thu, 2 Nov 2023 at 20:19, Clayton Craft <clayton@craftyguy.net> wrote:
>
> This panel is found on laptops e.g., variants of the Thinkpad X13s.
> Configuration was collected from the panel's EDID.
>
> Signed-off-by: Clayton Craft <clayton@craftyguy.net>
> ---
>
> V2: renamed to "*_mode" since there is only 1 mode listed
>
>  drivers/gpu/drm/panel/panel-edp.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 95c8472d878a..e2e4d88a5159 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1204,6 +1204,29 @@ static const struct panel_desc boe_nv133fhm_n61 = {
>         },
>  };
>
> +static const struct drm_display_mode boe_nv133wum_n63_mode = {
> +       .clock = 157760,
> +       .hdisplay = 1920,
> +       .hsync_start = 1920 + 48,
> +       .hsync_end = 1920 + 48 + 32,
> +       .htotal = 1920 + 48 + 32 + 80,
> +       .vdisplay = 1200,
> +       .vsync_start = 1200 + 3,
> +       .vsync_end = 1200 + 3 + 6,
> +       .vtotal = 1200 + 3 + 6 + 31,
> +       .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc boe_nv133wum_n63 = {
> +       .modes = &boe_nv133wum_n63_mode,
> +       .num_modes = 1,
> +       .bpc = 8,
> +       .size = {
> +               .width = 286,
> +               .height = 179,
> +       },
> +};
> +
>  static const struct drm_display_mode boe_nv140fhmn49_modes[] = {
>         {
>                 .clock = 148500,
> @@ -1723,6 +1746,9 @@ static const struct of_device_id platform_of_match[] = {
>         }, {
>                 .compatible = "boe,nv133fhm-n62",
>                 .data = &boe_nv133fhm_n61,
> +       }, {
> +               .compatible = "boe,nv133wum-n63",
> +               .data = &boe_nv133wum_n63,

Just for my understanding. Why do you need to add panel mode and size?
Isn't a delay (added below) enough for your case?

>         }, {
>                 .compatible = "boe,nv140fhmn49",
>                 .data = &boe_nv140fhmn49,
> @@ -1852,6 +1878,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x095f, &delay_200_500_e50, "NE135FBM-N41 v8.1"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x098d, &boe_nv110wtm_n61.delay, "NV110WTM-N61"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x09dd, &delay_200_500_e50, "NT116WHM-N21"),
> +       EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
>
> --
> 2.40.1
>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel
  2023-11-03 22:28 ` Dmitry Baryshkov
@ 2024-05-20 20:06   ` Clayton Craft
  2024-05-20 21:07     ` Dmitry Baryshkov
  0 siblings, 1 reply; 7+ messages in thread
From: Clayton Craft @ 2024-05-20 20:06 UTC (permalink / raw)
  To: dmitry.baryshkov; +Cc: clayton, dri-devel

This panel is found on some laptops e.g., variants of the Thinkpad X13s.

Signed-off-by: Clayton Craft <clayton@craftyguy.net>
---
 drivers/gpu/drm/panel/panel-edp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 6db277efcbb7..f75db9917667 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -2047,6 +2047,7 @@ static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b34, &delay_200_500_e80, "NV122WUM-N41"),
+	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b43, &delay_200_500_e200, "NV140FHM-T09"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b56, &delay_200_500_e80, "NT140FHM-N47"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0c20, &delay_200_500_e80, "NT140FHM-N47"),
-- 
2.45.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel
  2024-05-20 20:06   ` [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel Clayton Craft
@ 2024-05-20 21:07     ` Dmitry Baryshkov
  2024-05-20 21:25       ` Clayton Craft
  0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2024-05-20 21:07 UTC (permalink / raw)
  To: Clayton Craft; +Cc: dri-devel

On Mon, May 20, 2024 at 01:06:00PM -0700, Clayton Craft wrote:
> This panel is found on some laptops e.g., variants of the Thinkpad X13s.
> 
> Signed-off-by: Clayton Craft <clayton@craftyguy.net>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 1 +
>  1 file changed, 1 insertion(+)

Please don't send patches as a response to other mails and also please
keep versioning consistent. This should have been v3.

> 
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 6db277efcbb7..f75db9917667 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -2047,6 +2047,7 @@ static const struct edp_panel_entry edp_panels[] = {
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b34, &delay_200_500_e80, "NV122WUM-N41"),
> +	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b43, &delay_200_500_e200, "NV140FHM-T09"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b56, &delay_200_500_e80, "NT140FHM-N47"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0c20, &delay_200_500_e80, "NT140FHM-N47"),
> -- 
> 2.45.1
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel
  2024-05-20 21:07     ` Dmitry Baryshkov
@ 2024-05-20 21:25       ` Clayton Craft
  0 siblings, 0 replies; 7+ messages in thread
From: Clayton Craft @ 2024-05-20 21:25 UTC (permalink / raw)
  To: Dmitry Baryshkov; +Cc: dri-devel

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Tue, 21 May 2024 00:07:04 +0300 Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:
> On Mon, May 20, 2024 at 01:06:00PM -0700, Clayton Craft wrote:
> > This panel is found on some laptops e.g., variants of the Thinkpad X13s.
> > 
> > Signed-off-by: Clayton Craft <clayton@craftyguy.net>
> > ---
> >  drivers/gpu/drm/panel/panel-edp.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Please don't send patches as a response to other mails and also please
> keep versioning consistent. This should have been v3.

Understood, and I'm sorry for the mistakes. I will resend it as V3.

-Clayton

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63
  2023-11-02 18:19 [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63 Clayton Craft
  2023-11-03 17:28 ` Jessica Zhang
  2023-11-03 22:28 ` Dmitry Baryshkov
@ 2024-05-20 21:03 ` Dmitry Baryshkov
  2 siblings, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2024-05-20 21:03 UTC (permalink / raw)
  To: Clayton Craft; +Cc: dri-devel

On Thu, Nov 02, 2023 at 11:19:07AM -0700, Clayton Craft wrote:
> This panel is found on laptops e.g., variants of the Thinkpad X13s.
> Configuration was collected from the panel's EDID.
> 
> Signed-off-by: Clayton Craft <clayton@craftyguy.net>
> ---
> 
> V2: renamed to "*_mode" since there is only 1 mode listed
> 
>  drivers/gpu/drm/panel/panel-edp.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 95c8472d878a..e2e4d88a5159 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1204,6 +1204,29 @@ static const struct panel_desc boe_nv133fhm_n61 = {
>  	},
>  };
>  
> +static const struct drm_display_mode boe_nv133wum_n63_mode = {
> +	.clock = 157760,
> +	.hdisplay = 1920,
> +	.hsync_start = 1920 + 48,
> +	.hsync_end = 1920 + 48 + 32,
> +	.htotal = 1920 + 48 + 32 + 80,
> +	.vdisplay = 1200,
> +	.vsync_start = 1200 + 3,
> +	.vsync_end = 1200 + 3 + 6,
> +	.vtotal = 1200 + 3 + 6 + 31,
> +	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc boe_nv133wum_n63 = {
> +	.modes = &boe_nv133wum_n63_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 286,
> +		.height = 179,
> +	},
> +};
> +
>  static const struct drm_display_mode boe_nv140fhmn49_modes[] = {
>  	{
>  		.clock = 148500,
> @@ -1723,6 +1746,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "boe,nv133fhm-n62",
>  		.data = &boe_nv133fhm_n61,
> +	}, {
> +		.compatible = "boe,nv133wum-n63",
> +		.data = &boe_nv133wum_n63,

Why do we need this entry? Is the default EDID correct?

>  	}, {
>  		.compatible = "boe,nv140fhmn49",
>  		.data = &boe_nv140fhmn49,
> @@ -1852,6 +1878,7 @@ static const struct edp_panel_entry edp_panels[] = {
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x095f, &delay_200_500_e50, "NE135FBM-N41 v8.1"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x098d, &boe_nv110wtm_n61.delay, "NV110WTM-N61"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x09dd, &delay_200_500_e50, "NT116WHM-N21"),
> +	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
>  	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
>  
> -- 
> 2.40.1
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-05-20 21:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-02 18:19 [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63 Clayton Craft
2023-11-03 17:28 ` Jessica Zhang
2023-11-03 22:28 ` Dmitry Baryshkov
2024-05-20 20:06   ` [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel Clayton Craft
2024-05-20 21:07     ` Dmitry Baryshkov
2024-05-20 21:25       ` Clayton Craft
2024-05-20 21:03 ` [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63 Dmitry Baryshkov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.