All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andersson@kernel.org,
	konrad.dybcio@linaro.org, richard@nod.at, vigneshr@ti.com,
	manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH v6 4/8] drivers: mtd: nand: Add qpic_common API file
Date: Tue, 21 May 2024 14:51:40 +0200	[thread overview]
Message-ID: <20240521145140.5cb49946@xps-13> (raw)
In-Reply-To: <20240521105532.1537845-5-quic_mdalam@quicinc.com>

Hi,

>  drivers/mtd/nand/Makefile            |    4 +-
>  drivers/mtd/nand/qpic_common.c       |  740 +++++++++++++++++
>  drivers/mtd/nand/raw/qcom_nandc.c    | 1090 +-------------------------
>  include/linux/mtd/nand-qpic-common.h |  467 +++++++++++
>  4 files changed, 1222 insertions(+), 1079 deletions(-)
>  create mode 100644 drivers/mtd/nand/qpic_common.c
>  create mode 100644 include/linux/mtd/nand-qpic-common.h
> 
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 19e1291ac4d5..e59106e0a3af 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -3,7 +3,9 @@
>  nandcore-objs := core.o bbt.o
>  obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o
>  obj-$(CONFIG_MTD_NAND_ECC_MEDIATEK) += ecc-mtk.o
> -
> +ifeq ($(CONFIG_MTD_NAND_QCOM),y)
> +obj-y	+= qpic_common.o
> +endif

Breaks if you set CONFIG_MTD_NAND_QCOM = m

>  obj-y	+= onenand/
>  obj-y	+= raw/
>  obj-y	+= spi/
> diff --git a/drivers/mtd/nand/qpic_common.c b/drivers/mtd/nand/qpic_common.c
> new file mode 100644
> index 000000000000..dfbbb5f626b6
> --- /dev/null
> +++ b/drivers/mtd/nand/qpic_common.c
> @@ -0,0 +1,740 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + */
> +#include <linux/bitops.h>
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/dmaengine.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/dma/qcom_adm.h>
> +#include <linux/dma/qcom_bam_dma.h>
> +#include <linux/module.h>
> +#include <linux/mtd/partitions.h>

Didn't you say you would remove that include?

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andersson@kernel.org,
	konrad.dybcio@linaro.org, richard@nod.at, vigneshr@ti.com,
	manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH v6 4/8] drivers: mtd: nand: Add qpic_common API file
Date: Tue, 21 May 2024 14:51:40 +0200	[thread overview]
Message-ID: <20240521145140.5cb49946@xps-13> (raw)
In-Reply-To: <20240521105532.1537845-5-quic_mdalam@quicinc.com>

Hi,

>  drivers/mtd/nand/Makefile            |    4 +-
>  drivers/mtd/nand/qpic_common.c       |  740 +++++++++++++++++
>  drivers/mtd/nand/raw/qcom_nandc.c    | 1090 +-------------------------
>  include/linux/mtd/nand-qpic-common.h |  467 +++++++++++
>  4 files changed, 1222 insertions(+), 1079 deletions(-)
>  create mode 100644 drivers/mtd/nand/qpic_common.c
>  create mode 100644 include/linux/mtd/nand-qpic-common.h
> 
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 19e1291ac4d5..e59106e0a3af 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -3,7 +3,9 @@
>  nandcore-objs := core.o bbt.o
>  obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o
>  obj-$(CONFIG_MTD_NAND_ECC_MEDIATEK) += ecc-mtk.o
> -
> +ifeq ($(CONFIG_MTD_NAND_QCOM),y)
> +obj-y	+= qpic_common.o
> +endif

Breaks if you set CONFIG_MTD_NAND_QCOM = m

>  obj-y	+= onenand/
>  obj-y	+= raw/
>  obj-y	+= spi/
> diff --git a/drivers/mtd/nand/qpic_common.c b/drivers/mtd/nand/qpic_common.c
> new file mode 100644
> index 000000000000..dfbbb5f626b6
> --- /dev/null
> +++ b/drivers/mtd/nand/qpic_common.c
> @@ -0,0 +1,740 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + */
> +#include <linux/bitops.h>
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/dmaengine.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/dma/qcom_adm.h>
> +#include <linux/dma/qcom_bam_dma.h>
> +#include <linux/module.h>
> +#include <linux/mtd/partitions.h>

Didn't you say you would remove that include?

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2024-05-21 12:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 10:55 [PATCH v6 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-05-21 10:55 ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 4/8] drivers: mtd: nand: Add qpic_common API file Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam
2024-05-21 11:54   ` Krzysztof Kozlowski
2024-05-21 11:54     ` Krzysztof Kozlowski
2024-05-21 12:31     ` Md Sadre Alam
2024-05-21 12:31       ` Md Sadre Alam
2024-05-21 12:51   ` Miquel Raynal [this message]
2024-05-21 12:51     ` Miquel Raynal
2024-05-22  6:08     ` Md Sadre Alam
2024-05-22  6:08       ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 5/8] drivers: mtd: nand: use FIELD_PREP and GENMASK Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam
2024-05-21 12:53   ` Miquel Raynal
2024-05-21 12:53     ` Miquel Raynal
2024-05-22  6:09     ` Md Sadre Alam
2024-05-22  6:09       ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam
2024-05-21 13:24   ` Miquel Raynal
2024-05-21 13:24     ` Miquel Raynal
2024-05-22  9:42     ` Md Sadre Alam
2024-05-22  9:42       ` Md Sadre Alam
2024-05-22 12:33       ` Miquel Raynal
2024-05-22 12:33         ` Miquel Raynal
2024-05-23  3:34         ` Md Sadre Alam
2024-05-23  3:34           ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam
2024-05-21 10:55 ` [PATCH v6 8/8] arm64: dts: qcom: ipq9574: Disable eMMC node Md Sadre Alam
2024-05-21 10:55   ` Md Sadre Alam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240521145140.5cb49946@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.