All of lore.kernel.org
 help / color / mirror / Atom feed
* [plbossart-sound:sdw/rt712-quirks 19/24] drivers/soundwire/slave.c:91:undefined reference to `sdca_lookup_interface_revision'
@ 2024-05-21 11:07 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-05-21 11:07 UTC (permalink / raw)
  To: Pierre-Louis Bossart; +Cc: oe-kbuild-all

tree:   https://github.com/plbossart/sound sdw/rt712-quirks
head:   00d39334f0f6f7d27e80b4741b63e4742e073fb7
commit: 2b3abca668a1f59e1426ea6e13d9c07672552f6f [19/24] soundwire: slave: parse SDCA function mask and revision
config: x86_64-randconfig-104-20240521 (https://download.01.org/0day-ci/archive/20240521/202405211946.PwCEHZPV-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240521/202405211946.PwCEHZPV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405211946.PwCEHZPV-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: vmlinux.o: in function `sdw_slave_add':
>> drivers/soundwire/slave.c:91:(.text+0x1472da0): undefined reference to `sdca_lookup_interface_revision'
>> ld: drivers/soundwire/slave.c:92:(.text+0x1472da8): undefined reference to `sdca_lookup_function_mask'


vim +91 drivers/soundwire/slave.c

    25	
    26	int sdw_slave_add(struct sdw_bus *bus,
    27			  struct sdw_slave_id *id, struct fwnode_handle *fwnode)
    28	{
    29		struct sdw_slave *slave;
    30		int ret;
    31		int i;
    32	
    33		slave = kzalloc(sizeof(*slave), GFP_KERNEL);
    34		if (!slave)
    35			return -ENOMEM;
    36	
    37		/* Initialize data structure */
    38		memcpy(&slave->id, id, sizeof(*id));
    39		slave->dev.parent = bus->dev;
    40		slave->dev.fwnode = fwnode;
    41	
    42		if (id->unique_id == SDW_IGNORED_UNIQUE_ID) {
    43			/* name shall be sdw:ctrl:link:mfg:part:class */
    44			dev_set_name(&slave->dev, "sdw:%01x:%01x:%04x:%04x:%02x",
    45				     bus->controller_id, bus->link_id, id->mfg_id, id->part_id,
    46				     id->class_id);
    47		} else {
    48			/* name shall be sdw:ctrl:link:mfg:part:class:unique */
    49			dev_set_name(&slave->dev, "sdw:%01x:%01x:%04x:%04x:%02x:%01x",
    50				     bus->controller_id, bus->link_id, id->mfg_id, id->part_id,
    51				     id->class_id, id->unique_id);
    52		}
    53	
    54		slave->dev.bus = &sdw_bus_type;
    55		slave->dev.of_node = of_node_get(to_of_node(fwnode));
    56		slave->dev.type = &sdw_slave_type;
    57		slave->dev.groups = sdw_slave_status_attr_groups;
    58		slave->bus = bus;
    59		slave->status = SDW_SLAVE_UNATTACHED;
    60		init_completion(&slave->enumeration_complete);
    61		init_completion(&slave->initialization_complete);
    62		slave->dev_num = 0;
    63		slave->probed = false;
    64		slave->first_interrupt_done = false;
    65		mutex_init(&slave->sdw_dev_lock);
    66	
    67		for (i = 0; i < SDW_MAX_PORTS; i++)
    68			init_completion(&slave->port_ready[i]);
    69	
    70		mutex_lock(&bus->bus_lock);
    71		list_add_tail(&slave->node, &bus->slaves);
    72		mutex_unlock(&bus->bus_lock);
    73	
    74		ret = device_register(&slave->dev);
    75		if (ret) {
    76			dev_err(bus->dev, "Failed to add slave: ret %d\n", ret);
    77	
    78			/*
    79			 * On err, don't free but drop ref as this will be freed
    80			 * when release method is invoked.
    81			 */
    82			mutex_lock(&bus->bus_lock);
    83			list_del(&slave->node);
    84			mutex_unlock(&bus->bus_lock);
    85			put_device(&slave->dev);
    86	
    87			return ret;
    88		}
    89		sdw_slave_debugfs_init(slave);
    90	
  > 91		sdca_lookup_interface_revision(slave);
  > 92		sdca_lookup_function_mask(slave);
    93	
    94		return ret;
    95	}
    96	EXPORT_SYMBOL(sdw_slave_add);
    97	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-05-21 11:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 11:07 [plbossart-sound:sdw/rt712-quirks 19/24] drivers/soundwire/slave.c:91:undefined reference to `sdca_lookup_interface_revision' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.