[PATCH] Log kernel version in check.log

[PATCH] Log kernel version in check.log

[cem]

From: Carlos Maiolino <cem@kernel.org>

After collecting several xfstests runs, it's useful to keep track on
which kernel a specific run happened.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 check | 1 +
 1 file changed, 1 insertion(+)

diff --git a/check b/check
index c6dba89b..7703c128 100755
--- a/check
+++ b/check
@@ -478,6 +478,7 @@ _wrapup()
 		fi
 
 		_global_log ""
+		_global_log "Kernel version: $(uname -r)"
 		_global_log "$(date)"
 
 		echo "SECTION       -- $section" >>$tmp.summary
-- 
2.45.1

Re: [PATCH] Log kernel version in check.log

[Darrick J. Wong]

On Wed, May 22, 2024 at 01:33:38PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> After collecting several xfstests runs, it's useful to keep track on
> which kernel a specific run happened.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

I wonder if you want to capture more of the system variables, like
__generate_report_vars does?

(Should we be capturing ${FSTYP}progs version too?)

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  check | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/check b/check
> index c6dba89b..7703c128 100755
> --- a/check
> +++ b/check
> @@ -478,6 +478,7 @@ _wrapup()
>  		fi
>  
>  		_global_log ""
> +		_global_log "Kernel version: $(uname -r)"
>  		_global_log "$(date)"
>  
>  		echo "SECTION       -- $section" >>$tmp.summary
> -- 
> 2.45.1
> 
> 

Re: [PATCH] Log kernel version in check.log

[Zorro Lang]

On Wed, May 22, 2024 at 07:42:41AM -0700, Darrick J. Wong wrote:
> On Wed, May 22, 2024 at 01:33:38PM +0200, cem@kernel.org wrote:
> > From: Carlos Maiolino <cem@kernel.org>
> > 
> > After collecting several xfstests runs, it's useful to keep track on
> > which kernel a specific run happened.
> > 
> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> 
> I wonder if you want to capture more of the system variables, like
> __generate_report_vars does?
> 
> (Should we be capturing ${FSTYP}progs version too?)

That's good to me, but my concern is: It's hard to have a common method to
get the ${FSTYP}progs version. For most of localfs, "mkfs.$FSTYP -V" can
get a version message, but not all can do that. Even if we can let each
$FSTYP get its version through its own way, but the testers can install
the ${FSTYP}progs by many different ways, e.g. make & make install, or
a .rpm, or a .deb or something else.

If you have any good idea, please feel free to tell me:)

Thanks,
Zorro

> 
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> 
> --D
> 
> > ---
> >  check | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/check b/check
> > index c6dba89b..7703c128 100755
> > --- a/check
> > +++ b/check
> > @@ -478,6 +478,7 @@ _wrapup()
> >  		fi
> >  
> >  		_global_log ""
> > +		_global_log "Kernel version: $(uname -r)"
> >  		_global_log "$(date)"
> >  
> >  		echo "SECTION       -- $section" >>$tmp.summary
> > -- 
> > 2.45.1
> > 
> > 
>