All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Michal Simek <michal.simek@amd.com>,
	linux-gpio@vger.kernel.org,
	Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: xilinx: Add support for function with pins
Date: Wed, 22 May 2024 09:48:46 -0500	[thread overview]
Message-ID: <20240522144846.GA3277292-robh@kernel.org> (raw)
In-Reply-To: <20240520150424.2531458-2-sean.anderson@linux.dev>

On Mon, May 20, 2024 at 11:04:23AM -0400, Sean Anderson wrote:
> Support specifying the function per-pin. The driver doesn't care
> whethern you use pins or groups for this purpose.
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
> 
> (no changes since v1)
> 
>  .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 344 +++++++++---------
>  1 file changed, 176 insertions(+), 168 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> index f13d315b5d5e..d3b258245e28 100644
> --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> @@ -42,179 +42,187 @@ patternProperties:
>          $ref: pinmux-node.yaml#
>  
>          properties:
> +          pins:
> +            description:
> +              List of pins to select (either this or "groups" must be specified)

Express as a schema:

oneOf:
  - required: [pins]
  - required: [groups]


> +            items:
> +              pattern: '^MIO([0-9]|[1-6][0-9]|7[0-7])$'
> +
>            groups:
>              description:
>                List of groups to select (either this or "pins" must be
>                specified), available groups for this subnode.
>              items:

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Michal Simek <michal.simek@amd.com>,
	linux-gpio@vger.kernel.org,
	Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: xilinx: Add support for function with pins
Date: Wed, 22 May 2024 09:48:46 -0500	[thread overview]
Message-ID: <20240522144846.GA3277292-robh@kernel.org> (raw)
In-Reply-To: <20240520150424.2531458-2-sean.anderson@linux.dev>

On Mon, May 20, 2024 at 11:04:23AM -0400, Sean Anderson wrote:
> Support specifying the function per-pin. The driver doesn't care
> whethern you use pins or groups for this purpose.
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
> 
> (no changes since v1)
> 
>  .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 344 +++++++++---------
>  1 file changed, 176 insertions(+), 168 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> index f13d315b5d5e..d3b258245e28 100644
> --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> @@ -42,179 +42,187 @@ patternProperties:
>          $ref: pinmux-node.yaml#
>  
>          properties:
> +          pins:
> +            description:
> +              List of pins to select (either this or "groups" must be specified)

Express as a schema:

oneOf:
  - required: [pins]
  - required: [groups]


> +            items:
> +              pattern: '^MIO([0-9]|[1-6][0-9]|7[0-7])$'
> +
>            groups:
>              description:
>                List of groups to select (either this or "pins" must be
>                specified), available groups for this subnode.
>              items:

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-05-22 14:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 15:04 [PATCH v2 0/2] pinctrl: zynqmp: Support muxing individual pins Sean Anderson
2024-05-20 15:04 ` Sean Anderson
2024-05-20 15:04 ` [PATCH v2 1/2] dt-bindings: pinctrl: xilinx: Add support for function with pins Sean Anderson
2024-05-20 15:04   ` Sean Anderson
2024-05-22 14:48   ` Rob Herring [this message]
2024-05-22 14:48     ` Rob Herring
2024-05-20 15:04 ` [PATCH v2 2/2] pinctrl: zynqmp: Support muxing individual pins Sean Anderson
2024-05-20 15:04   ` Sean Anderson
2024-06-10 12:16   ` Potthuri, Sai Krishna
2024-06-10 12:16     ` Potthuri, Sai Krishna
2024-06-10 16:59     ` Sean Anderson
2024-06-10 16:59       ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240522144846.GA3277292-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=sai.krishna.potthuri@amd.com \
    --cc=sean.anderson@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.