From: Eddie James <eajames@linux.ibm.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v6 02/20] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes
Date: Wed, 22 May 2024 14:25:06 -0500 [thread overview]
Message-ID: <20240522192524.3286237-3-eajames@linux.ibm.com> (raw)
In-Reply-To: <20240522192524.3286237-1-eajames@linux.ibm.com>
The FSI2SPI bridge has several SPI controllers behind it, which
should be documented. Also, therefore the node needs to specify
address and size cells.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/fsi/ibm,fsi2spi.yaml | 36 ++++++++++++++++---
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml b/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
index e2ca0b0004714..ad5c83f484255 100644
--- a/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
+++ b/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
@@ -9,11 +9,10 @@ title: IBM FSI-attached SPI controllers
maintainers:
- Eddie James <eajames@linux.ibm.com>
-description: |
+description:
This binding describes an FSI CFAM engine called the FSI2SPI. Therefore this
- node will always be a child of an FSI CFAM node; see fsi.txt for details on
- FSI slave and CFAM nodes. This FSI2SPI engine provides access to a number of
- SPI controllers.
+ node will always be a child of an FSI CFAM node. This FSI2SPI engine provides
+ access to a number of SPI controllers.
properties:
compatible:
@@ -24,6 +23,17 @@ properties:
items:
- description: FSI slave address
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^spi@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/spi/ibm,spi-fsi.yaml
+
required:
- compatible
- reg
@@ -35,4 +45,22 @@ examples:
fsi2spi at 1c00 {
compatible = "ibm,fsi2spi";
reg = <0x1c00 0x400>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ spi at 0 {
+ compatible = "ibm,spi-fsi";
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eeprom at 0 {
+ compatible = "atmel,at25";
+ reg = <0>;
+ address-width = <24>;
+ pagesize = <256>;
+ size = <0x80000>;
+ spi-max-frequency = <1000000>;
+ };
+ };
};
--
2.39.3
WARNING: multiple messages have this Message-ID (diff)
From: Eddie James <eajames@linux.ibm.com>
To: linux-fsi@lists.ozlabs.org
Cc: eajames@linux.ibm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ninad@linux.ibm.com,
lakshmiy@us.ibm.com, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
andrew@codeconstruct.com.au, joel@jms.id.au, robh@kernel.org,
conor+dt@kernel.org, krzk+dt@kernel.org, andi.shyti@kernel.org,
broonie@kernel.org
Subject: [PATCH v6 02/20] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes
Date: Wed, 22 May 2024 14:25:06 -0500 [thread overview]
Message-ID: <20240522192524.3286237-3-eajames@linux.ibm.com> (raw)
In-Reply-To: <20240522192524.3286237-1-eajames@linux.ibm.com>
The FSI2SPI bridge has several SPI controllers behind it, which
should be documented. Also, therefore the node needs to specify
address and size cells.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/fsi/ibm,fsi2spi.yaml | 36 ++++++++++++++++---
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml b/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
index e2ca0b0004714..ad5c83f484255 100644
--- a/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
+++ b/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
@@ -9,11 +9,10 @@ title: IBM FSI-attached SPI controllers
maintainers:
- Eddie James <eajames@linux.ibm.com>
-description: |
+description:
This binding describes an FSI CFAM engine called the FSI2SPI. Therefore this
- node will always be a child of an FSI CFAM node; see fsi.txt for details on
- FSI slave and CFAM nodes. This FSI2SPI engine provides access to a number of
- SPI controllers.
+ node will always be a child of an FSI CFAM node. This FSI2SPI engine provides
+ access to a number of SPI controllers.
properties:
compatible:
@@ -24,6 +23,17 @@ properties:
items:
- description: FSI slave address
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^spi@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/spi/ibm,spi-fsi.yaml
+
required:
- compatible
- reg
@@ -35,4 +45,22 @@ examples:
fsi2spi@1c00 {
compatible = "ibm,fsi2spi";
reg = <0x1c00 0x400>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ spi@0 {
+ compatible = "ibm,spi-fsi";
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eeprom@0 {
+ compatible = "atmel,at25";
+ reg = <0>;
+ address-width = <24>;
+ pagesize = <256>;
+ size = <0x80000>;
+ spi-max-frequency = <1000000>;
+ };
+ };
};
--
2.39.3
next prev parent reply other threads:[~2024-05-22 19:25 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 19:25 [PATCH v6 00/20] ARM: dts: aspeed: Add IBM P11 BMC systems Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-22 19:25 ` [PATCH v6 01/20] spi: dt-bindings: Document the IBM FSI-attached SPI controller Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-22 19:25 ` Eddie James [this message]
2024-05-22 19:25 ` [PATCH v6 02/20] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-05-22 19:25 ` [PATCH v6 03/20] dt-bindings: fsi: Document the IBM SCOM engine Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 9:28 ` Markus Elfring
2024-05-23 9:28 ` Markus Elfring
2024-05-23 9:43 ` Conor Dooley
2024-05-23 9:45 ` Conor Dooley
2024-05-23 11:05 ` [v6 " Markus Elfring
2024-05-23 11:05 ` Markus Elfring
2024-05-22 19:25 ` [PATCH v6 04/20] dt-bindings: fsi: p9-occ: Convert to json-schema Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 15:37 ` Markus Elfring
2024-05-23 15:37 ` Markus Elfring
2024-05-22 19:25 ` [PATCH v6 05/20] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 15:55 ` Markus Elfring
2024-05-23 15:55 ` Markus Elfring
2024-05-22 19:25 ` [PATCH v6 06/20] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 6:57 ` Krzysztof Kozlowski
2024-05-23 6:57 ` Krzysztof Kozlowski
2024-05-22 19:25 ` [PATCH v6 07/20] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-22 19:25 ` [PATCH v6 08/20] dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-22 19:25 ` [PATCH v6 09/20] dt-bindings: fsi: Document the AST2700 FSI controller Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-22 19:25 ` [PATCH v6 10/20] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-28 14:58 ` Ninad Palsule
2024-05-22 19:25 ` [PATCH v6 11/20] dt-bindings: i2c: i2c-fsi: Convert to json-schema Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 6:59 ` Krzysztof Kozlowski
2024-05-23 6:59 ` Krzysztof Kozlowski
2024-05-28 14:52 ` Ninad Palsule
2024-05-28 14:52 ` Ninad Palsule
2024-05-22 19:25 ` [PATCH v6 12/20] dt-bindings: arm: aspeed: add IBM P11 BMC boards Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-28 14:24 ` Ninad Palsule
2024-05-28 14:24 ` Ninad Palsule
2024-05-22 19:25 ` [PATCH v6 13/20] ARM: dts: aspeed: Add IBM P11 FSI devices Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-28 14:22 ` Ninad Palsule
2024-05-22 19:25 ` [PATCH v6 14/20] ARM: dts: aspeed: Add IBM P11 Blueridge BMC system Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-24 22:47 ` Ninad Palsule
2024-05-28 14:50 ` Eddie James
2024-05-28 14:50 ` Eddie James
2024-05-22 19:25 ` [PATCH v6 15/20] ARM: dts: aspeed: Add IBM P11 Blueridge 4U " Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-24 22:27 ` Ninad Palsule
2024-05-24 22:27 ` Ninad Palsule
2024-05-22 19:25 ` [PATCH v6 16/20] ARM: dts: aspeed: Add IBM P11 Fuji " Eddie James
2024-05-22 19:26 ` Eddie James
2024-05-28 14:08 ` Ninad Palsule
2024-05-28 14:47 ` Eddie James
2024-05-28 14:47 ` Eddie James
2024-05-22 19:25 ` [PATCH v6 17/20] ARM: dts: aspeed: Add IBM Huygens " Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 12:48 ` kernel test robot
2024-05-23 12:48 ` kernel test robot
2024-05-23 19:07 ` Eddie James
2024-05-23 19:07 ` Eddie James
2024-05-23 18:45 ` Markus Elfring
2024-05-23 18:45 ` Markus Elfring
2024-05-23 19:00 ` Eddie James
2024-05-23 19:00 ` Eddie James
2024-05-23 19:30 ` [v6 " Markus Elfring
2024-05-23 19:30 ` Markus Elfring
2024-05-23 19:33 ` Conor Dooley
2024-05-23 19:33 ` Conor Dooley
2024-05-23 19:46 ` Markus Elfring
2024-05-23 19:46 ` Markus Elfring
2024-05-23 20:33 ` Al Viro
2024-05-23 20:33 ` Al Viro
2024-05-24 6:38 ` Markus Elfring
2024-05-24 6:38 ` Markus Elfring
2024-05-23 20:24 ` [PATCH v6 " Krzysztof Kozlowski
2024-05-23 20:24 ` Krzysztof Kozlowski
2024-05-23 20:33 ` [v6 " Markus Elfring
2024-05-23 20:33 ` Markus Elfring
2024-05-23 21:38 ` [PATCH v6 " Ninad Palsule
2024-05-23 21:38 ` Ninad Palsule
2024-05-22 19:25 ` [PATCH v6 18/20] fsi: occ: Get device number from FSI minor number API Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 21:36 ` Ninad Palsule
2024-05-23 21:36 ` Ninad Palsule
2024-05-22 19:25 ` [PATCH v6 19/20] fsi: occ: Find next available child rather than node name match Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-22 19:25 ` [PATCH v6 20/20] fsi: scom: Update compatible string to match documentation Eddie James
2024-05-22 19:25 ` Eddie James
2024-05-23 21:29 ` Ninad Palsule
2024-05-23 21:29 ` Ninad Palsule
2024-05-23 21:31 ` [PATCH v6 19/20] fsi: occ: Find next available child rather than node name match Ninad Palsule
2024-05-23 21:31 ` Ninad Palsule
2024-06-05 15:47 ` [PATCH v6 00/20] ARM: dts: aspeed: Add IBM P11 BMC systems Eddie James
2024-06-05 15:47 ` Eddie James
2024-06-06 1:31 ` Andrew Jeffery
2024-06-06 1:31 ` Andrew Jeffery
2024-07-08 13:47 ` Rob Herring
2024-07-08 13:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522192524.3286237-3-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.