From: Simon Horman <horms@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Maher Sanalla <msanalla@nvidia.com>
Subject: Re: [PATCH net 1/8] net/mlx5: Lag, do bond only if slaves agree on roce state
Date: Thu, 23 May 2024 10:45:36 +0100 [thread overview]
Message-ID: <20240523094536.GD883722@kernel.org> (raw)
In-Reply-To: <20240522192659.840796-2-tariqt@nvidia.com>
On Wed, May 22, 2024 at 10:26:52PM +0300, Tariq Toukan wrote:
> From: Maher Sanalla <msanalla@nvidia.com>
>
> Currently, the driver does not enforce that lag bond slaves must have
> matching roce capabilities. Yet, in mlx5_do_bond(), the driver attempts
> to enable roce on all vports of the bond slaves, causing the following
> syndrome when one slave has no roce fw support:
>
> mlx5_cmd_out_err:809:(pid 25427): MODIFY_NIC_VPORT_CONTEXT(0×755) op_mod(0×0)
> failed, status bad parameter(0×3), syndrome (0xc1f678), err(-22)
>
> Thus, create HW lag only if bond's slaves agree on roce state,
> either all slaves have roce support resulting in a roce lag bond,
> or none do, resulting in a raw eth bond.
>
> Fixes: 7907f23adc18 ("net/mlx5: Implement RoCE LAG feature")
> Signed-off-by: Maher Sanalla <msanalla@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-23 9:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 19:26 [PATCH net 0/8] mlx5 fixes 24-05-22 Tariq Toukan
2024-05-22 19:26 ` [PATCH net 1/8] net/mlx5: Lag, do bond only if slaves agree on roce state Tariq Toukan
2024-05-23 9:45 ` Simon Horman [this message]
2024-05-22 19:26 ` [PATCH net 2/8] net/mlx5: Do not query MPIR on embedded CPU function Tariq Toukan
2024-05-23 9:46 ` Simon Horman
2024-05-22 19:26 ` [PATCH net 3/8] net/mlx5: Fix MTMP register capability offset in MCAM register Tariq Toukan
2024-05-23 9:47 ` Simon Horman
2024-05-22 19:26 ` [PATCH net 4/8] net/mlx5: Use mlx5_ipsec_rx_status_destroy to correctly delete status rules Tariq Toukan
2024-05-23 9:47 ` Simon Horman
2024-05-22 19:26 ` [PATCH net 5/8] net/mlx5e: Fix IPsec tunnel mode offload feature check Tariq Toukan
2024-05-23 9:48 ` Simon Horman
2024-05-22 19:26 ` [PATCH net 6/8] net/mlx5e: Do not use ptp structure for tx ts stats when not initialized Tariq Toukan
2024-05-23 9:48 ` Simon Horman
2024-05-22 19:26 ` [PATCH net 7/8] net/mlx5e: Use rx_missed_errors instead of rx_dropped for reporting buffer exhaustion Tariq Toukan
2024-05-23 9:48 ` Simon Horman
2024-05-22 19:26 ` [PATCH net 8/8] net/mlx5e: Fix UDP GSO for encapsulated packets Tariq Toukan
2024-05-23 9:48 ` Simon Horman
2024-05-24 12:30 ` [PATCH net 0/8] mlx5 fixes 24-05-22 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523094536.GD883722@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=msanalla@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.