All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	Jason Baron <jbaron@akamai.com>,
	Dragos Tatulea <dtatulea@nvidia.com>,
	Boris Pismenny <borisp@nvidia.com>
Subject: Re: [PATCH net 8/8] net/mlx5e: Fix UDP GSO for encapsulated packets
Date: Thu, 23 May 2024 10:48:59 +0100	[thread overview]
Message-ID: <20240523094859.GK883722@kernel.org> (raw)
In-Reply-To: <20240522192659.840796-9-tariqt@nvidia.com>

On Wed, May 22, 2024 at 10:26:59PM +0300, Tariq Toukan wrote:
> From: Gal Pressman <gal@nvidia.com>
> 
> When the skb is encapsulated, adjust the inner UDP header instead of the
> outer one, and account for UDP header (instead of TCP) in the inline
> header size calculation.
> 
> Fixes: 689adf0d4892 ("net/mlx5e: Add UDP GSO support")
> Reported-by: Jason Baron <jbaron@akamai.com>
> Closes: https://lore.kernel.org/netdev/c42961cb-50b9-4a9a-bd43-87fe48d88d29@akamai.com/
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> Reviewed-by: Boris Pismenny <borisp@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Thanks,

This patch looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

While looking over this patch, I noticed that it seems
that a similar pattern to the mlx5e_tx_get_gso_ihs() code
modified here appears in at least the MANA and NFP drivers.
So perhaps we could consider a helper in future.

  reply	other threads:[~2024-05-23  9:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 19:26 [PATCH net 0/8] mlx5 fixes 24-05-22 Tariq Toukan
2024-05-22 19:26 ` [PATCH net 1/8] net/mlx5: Lag, do bond only if slaves agree on roce state Tariq Toukan
2024-05-23  9:45   ` Simon Horman
2024-05-22 19:26 ` [PATCH net 2/8] net/mlx5: Do not query MPIR on embedded CPU function Tariq Toukan
2024-05-23  9:46   ` Simon Horman
2024-05-22 19:26 ` [PATCH net 3/8] net/mlx5: Fix MTMP register capability offset in MCAM register Tariq Toukan
2024-05-23  9:47   ` Simon Horman
2024-05-22 19:26 ` [PATCH net 4/8] net/mlx5: Use mlx5_ipsec_rx_status_destroy to correctly delete status rules Tariq Toukan
2024-05-23  9:47   ` Simon Horman
2024-05-22 19:26 ` [PATCH net 5/8] net/mlx5e: Fix IPsec tunnel mode offload feature check Tariq Toukan
2024-05-23  9:48   ` Simon Horman
2024-05-22 19:26 ` [PATCH net 6/8] net/mlx5e: Do not use ptp structure for tx ts stats when not initialized Tariq Toukan
2024-05-23  9:48   ` Simon Horman
2024-05-22 19:26 ` [PATCH net 7/8] net/mlx5e: Use rx_missed_errors instead of rx_dropped for reporting buffer exhaustion Tariq Toukan
2024-05-23  9:48   ` Simon Horman
2024-05-22 19:26 ` [PATCH net 8/8] net/mlx5e: Fix UDP GSO for encapsulated packets Tariq Toukan
2024-05-23  9:48   ` Simon Horman [this message]
2024-05-24 12:30 ` [PATCH net 0/8] mlx5 fixes 24-05-22 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240523094859.GK883722@kernel.org \
    --to=horms@kernel.org \
    --cc=borisp@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dtatulea@nvidia.com \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=jbaron@akamai.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.