All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@samba.org>
To: David Howells <dhowells@redhat.com>
Cc: David Howells via samba-technical
	<samba-technical@lists.samba.org>,
	Steve French <sfrench@samba.org>, Jeremy Allison <jra@samba.org>,
	linux-cifs@vger.kernel.org, Paulo Alcantara <pc@manguebit.com>
Subject: Re: Bug in Samba's implementation of FSCTL_QUERY_ALLOCATED_RANGES?
Date: Thu, 23 May 2024 14:54:20 +1000	[thread overview]
Message-ID: <20240523145420.5bf49110@echidna> (raw)
In-Reply-To: <370800.1716374185@warthog.procyon.org.uk>

On Wed, 22 May 2024 11:36:25 +0100, David Howells wrote:

> David Disseldorp <ddiss@samba.org> wrote:
> > ...
> > I think the best way to proceed here would be to capture traffic for the
> > same workload against a Windows SMB server. This could be don't by using
> > your cifs.ko workload or extending test_ioctl_sparse_qar_malformed().  
> 
> I don't have a windows server I can try.  Steve may be able to try that.

I'll put it on my todo list for the next time I have a Windows VM
sitting around. I do recall testing Samba alongside Windows when doing
the initial implementation, but QAR is very FS block / allocation size
specific, so 1:1 behaviour isn't straightforward (nor is it required by
the FSCTL_QUERY_ALLOCATED_RANGES / FSCTL_SET_ZERO_DATA specs).

Cheers, David

  reply	other threads:[~2024-05-23  4:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 23:53 Bug in Samba's implementation of FSCTL_QUERY_ALLOCATED_RANGES? David Howells
2024-05-22  8:53 ` David Disseldorp
2024-05-22 10:36   ` David Howells
2024-05-23  4:54     ` David Disseldorp [this message]
2024-05-23  5:05       ` ronnie sahlberg
2024-05-23  6:21         ` David Howells
2024-05-23  6:28           ` ronnie sahlberg
2024-05-23  6:36             ` David Howells
2024-05-23 14:29               ` Tom Talpey
2024-05-23 15:28                 ` Paulo Alcantara
2024-05-23 22:49                   ` Jeremy Allison
2024-05-24  7:45                     ` Stefan Metzmacher
2024-08-22 22:26                     ` David Howells
2024-08-23 13:20                       ` David Disseldorp
2024-08-28 10:25                         ` David Howells
2024-08-28 10:55                           ` David Disseldorp
2024-08-28 11:52                             ` David Howells
2024-08-28 12:57                               ` David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240523145420.5bf49110@echidna \
    --to=ddiss@samba.org \
    --cc=dhowells@redhat.com \
    --cc=jra@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pc@manguebit.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.