All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: David Disseldorp <ddiss@samba.org>
Cc: dhowells@redhat.com, Jeremy Allison <jra@samba.org>,
	Paulo Alcantara <pc@manguebit.com>, Tom Talpey <tom@talpey.com>,
	ronnie sahlberg <ronniesahlberg@gmail.com>,
	David Howells via samba-technical
	<samba-technical@lists.samba.org>,
	Steve French <sfrench@samba.org>,
	linux-cifs@vger.kernel.org
Subject: Re: Bug in Samba's implementation of FSCTL_QUERY_ALLOCATED_RANGES?
Date: Wed, 28 Aug 2024 12:52:25 +0100	[thread overview]
Message-ID: <965293.1724845945@warthog.procyon.org.uk> (raw)
In-Reply-To: <20240828105536.1e6226df.ddiss@samba.org>

Okay, that fixes the problem.

For reference, the file can be prepared thusly:

	xfs_io -c "pwrite 0 16M" -c "fpunch 0 1M" -c "fpunch 2M 1M" -c "fpunch 4M 1M" -c "fpunch 6M 1M" -c "fpunch 8M 1M" /xfstest.test/foo

and then the test run:

	xfs_io -c "seek -h 1" /xfstest.test/foo

Something like punch-hole is needed to set the sparse flag - otherwise QAR
isn't used by llseek().

So:

	Tested-by: David Howells <dhowells@redhat.com>

if you need it.

The Fedora samba version I applied this to was:

	samba-4.19.7-1.fc39.x86_64

though I had to drop the testing bits as they didn't build.

David


  reply	other threads:[~2024-08-28 11:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 23:53 Bug in Samba's implementation of FSCTL_QUERY_ALLOCATED_RANGES? David Howells
2024-05-22  8:53 ` David Disseldorp
2024-05-22 10:36   ` David Howells
2024-05-23  4:54     ` David Disseldorp
2024-05-23  5:05       ` ronnie sahlberg
2024-05-23  6:21         ` David Howells
2024-05-23  6:28           ` ronnie sahlberg
2024-05-23  6:36             ` David Howells
2024-05-23 14:29               ` Tom Talpey
2024-05-23 15:28                 ` Paulo Alcantara
2024-05-23 22:49                   ` Jeremy Allison
2024-05-24  7:45                     ` Stefan Metzmacher
2024-08-22 22:26                     ` David Howells
2024-08-23 13:20                       ` David Disseldorp
2024-08-28 10:25                         ` David Howells
2024-08-28 10:55                           ` David Disseldorp
2024-08-28 11:52                             ` David Howells [this message]
2024-08-28 12:57                               ` David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=965293.1724845945@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=ddiss@samba.org \
    --cc=jra@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pc@manguebit.com \
    --cc=ronniesahlberg@gmail.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.