* [PATCH] hwmon: (nzxt-smart2) add another USB ID
@ 2024-05-23 20:31 Aleksandr Mezin
2024-05-23 21:47 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Aleksandr Mezin @ 2024-05-23 20:31 UTC (permalink / raw)
To: linux-hwmon; +Cc: Aleksandr Mezin, stable, Jean Delvare, Guenter Roeck
Fan speed control reported to be working with existing userspace (hidraw)
software, so I assume it's compatible. Fan channel count is the same. No known
differences from already supported devices, at least regarding fan speed
control and initialization.
Discovered in liquidctl project:
https://github.com/liquidctl/liquidctl/pull/702
Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
Cc: stable@vger.kernel.org # v6.1+
---
drivers/hwmon/nzxt-smart2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
index 7aa586eb74be..df6fa72a6b59 100644
--- a/drivers/hwmon/nzxt-smart2.c
+++ b/drivers/hwmon/nzxt-smart2.c
@@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
{ HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
{ HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
{ HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
+ { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */
{},
};
--
2.45.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2024-05-23 20:31 [PATCH] hwmon: (nzxt-smart2) add another USB ID Aleksandr Mezin
@ 2024-05-23 21:47 ` Guenter Roeck
2024-05-23 23:34 ` Aleksandr Mezin
2024-05-24 0:39 ` [PATCH v2] hwmon: (nzxt-smart2) Add support for device 1e71:2020 Aleksandr Mezin
0 siblings, 2 replies; 6+ messages in thread
From: Guenter Roeck @ 2024-05-23 21:47 UTC (permalink / raw)
To: Aleksandr Mezin, linux-hwmon; +Cc: Jean Delvare
On 5/23/24 13:31, Aleksandr Mezin wrote:
> Fan speed control reported to be working with existing userspace (hidraw)
> software, so I assume it's compatible. Fan channel count is the same. No known
> differences from already supported devices, at least regarding fan speed
> control and initialization.
>
> Discovered in liquidctl project:
>
> https://github.com/liquidctl/liquidctl/pull/702
>
That is not an appropriate commit description.
Guenter
> Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
> Cc: stable@vger.kernel.org # v6.1+
> ---
> drivers/hwmon/nzxt-smart2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
> index 7aa586eb74be..df6fa72a6b59 100644
> --- a/drivers/hwmon/nzxt-smart2.c
> +++ b/drivers/hwmon/nzxt-smart2.c
> @@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
> { HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
> { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
> { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
> + { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */
> {},
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2024-05-23 21:47 ` Guenter Roeck
@ 2024-05-23 23:34 ` Aleksandr Mezin
2024-05-24 0:11 ` Guenter Roeck
2024-05-24 0:39 ` [PATCH v2] hwmon: (nzxt-smart2) Add support for device 1e71:2020 Aleksandr Mezin
1 sibling, 1 reply; 6+ messages in thread
From: Aleksandr Mezin @ 2024-05-23 23:34 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hwmon, Jean Delvare
I'm sorry, I don't understand what exactly is wrong with the
description. Especially because patches with similar descriptions were
accepted before.
On Fri, May 24, 2024 at 12:47 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 5/23/24 13:31, Aleksandr Mezin wrote:
> > Fan speed control reported to be working with existing userspace (hidraw)
> > software, so I assume it's compatible. Fan channel count is the same. No known
> > differences from already supported devices, at least regarding fan speed
> > control and initialization.
> >
> > Discovered in liquidctl project:
> >
> > https://github.com/liquidctl/liquidctl/pull/702
> >
>
> That is not an appropriate commit description.
>
> Guenter
>
> > Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
> > Cc: stable@vger.kernel.org # v6.1+
> > ---
> > drivers/hwmon/nzxt-smart2.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
> > index 7aa586eb74be..df6fa72a6b59 100644
> > --- a/drivers/hwmon/nzxt-smart2.c
> > +++ b/drivers/hwmon/nzxt-smart2.c
> > @@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
> > { HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
> > { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
> > { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
> > + { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */
> > {},
> > };
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (nzxt-smart2) add another USB ID
2024-05-23 23:34 ` Aleksandr Mezin
@ 2024-05-24 0:11 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2024-05-24 0:11 UTC (permalink / raw)
To: Aleksandr Mezin; +Cc: linux-hwmon, Jean Delvare
On 5/23/24 16:34, Aleksandr Mezin wrote:
> I'm sorry, I don't understand what exactly is wrong with the
> description. Especially because patches with similar descriptions were
> accepted before.
>
See Documentation/process/submitting-patches.rst, "Describe your changes"
And thanks for pointing out that I am not perfect.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] hwmon: (nzxt-smart2) Add support for device 1e71:2020
2024-05-23 21:47 ` Guenter Roeck
2024-05-23 23:34 ` Aleksandr Mezin
@ 2024-05-24 0:39 ` Aleksandr Mezin
2024-05-29 22:41 ` Guenter Roeck
1 sibling, 1 reply; 6+ messages in thread
From: Aleksandr Mezin @ 2024-05-24 0:39 UTC (permalink / raw)
To: linux-hwmon; +Cc: Aleksandr Mezin, stable, Jean Delvare, Guenter Roeck
Add support for device with USB ID 1e71:2020.
Fan speed control reported to be working with existing userspace (hidraw)
software, so I assume it's compatible. Fan channel count is the same.
No known differences from already supported devices, at least regarding
fan speed control and initialization.
Discovered in liquidctl project:
https://github.com/liquidctl/liquidctl/pull/702
Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
Cc: stable@vger.kernel.org # v6.1+
---
v2: Improved the description, changed the subject to include device id
(previous subject was "hwmon: (nzxt-smart2) add another USB ID").
drivers/hwmon/nzxt-smart2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
index 7aa586eb74be..df6fa72a6b59 100644
--- a/drivers/hwmon/nzxt-smart2.c
+++ b/drivers/hwmon/nzxt-smart2.c
@@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = {
{ HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */
{ HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */
{ HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */
+ { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */
{},
};
--
2.45.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-29 22:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 20:31 [PATCH] hwmon: (nzxt-smart2) add another USB ID Aleksandr Mezin
2024-05-23 21:47 ` Guenter Roeck
2024-05-23 23:34 ` Aleksandr Mezin
2024-05-24 0:11 ` Guenter Roeck
2024-05-24 0:39 ` [PATCH v2] hwmon: (nzxt-smart2) Add support for device 1e71:2020 Aleksandr Mezin
2024-05-29 22:41 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.