From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Mikulas Patocka <mpatocka@redhat.com>,
Damien Le Moal <dlemoal@kernel.org>,
dm-devel@lists.linux.dev
Subject: Re: [PATCH 1/3] dm: move setting zoned_enabled to dm_table_set_restrictions
Date: Fri, 24 May 2024 18:40:51 +0200 [thread overview]
Message-ID: <20240524164051.GA21444@lst.de> (raw)
In-Reply-To: <ZlCtT0FadH4I8dFb@kernel.org>
On Fri, May 24, 2024 at 11:07:59AM -0400, Mike Snitzer wrote:
> > + ret = dm_revalidate_zones(md, t);
> > + if (ret < 0)
> > + return 0;
>
> Not following why you're return 0 if r < 0.
>
> blk_revalidate_disk_zones() has quite a few negative checks that
> return regular error codes, so why drop those validation errors?
Because I messed this up..
next prev parent reply other threads:[~2024-05-24 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 14:29 convert newly added dm-zone code to the atomic queue commit API Christoph Hellwig
2024-05-24 14:29 ` [PATCH 1/3] dm: move setting zoned_enabled to dm_table_set_restrictions Christoph Hellwig
2024-05-24 15:07 ` Mike Snitzer
2024-05-24 16:40 ` Christoph Hellwig [this message]
2024-05-24 14:29 ` [PATCH 2/3] dm: remove dm_check_zoned Christoph Hellwig
2024-05-24 15:09 ` Mike Snitzer
2024-05-24 14:29 ` [PATCH 3/3] dm: make dm_set_zones_restrictions work on the queue limits Christoph Hellwig
2024-05-24 15:15 ` Mike Snitzer
2024-05-24 16:41 ` Christoph Hellwig
2024-05-24 15:17 ` convert newly added dm-zone code to the atomic queue commit API Mike Snitzer
-- strict thread matches above, loose matches on Subject: below --
2024-05-27 8:04 convert newly added dm-zone code to the atomic queue commit API v2 Christoph Hellwig
2024-05-27 8:04 ` [PATCH 1/3] dm: move setting zoned_enabled to dm_table_set_restrictions Christoph Hellwig
2024-05-27 11:34 ` Johannes Thumshirn
2024-05-27 12:36 convert newly added dm-zone code to the atomic queue commit API v3 Christoph Hellwig
2024-05-27 12:36 ` [PATCH 1/3] dm: move setting zoned_enabled to dm_table_set_restrictions Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524164051.GA21444@lst.de \
--to=hch@lst.de \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.