From: Mike Snitzer <snitzer@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Damien Le Moal <dlemoal@kernel.org>,
dm-devel@lists.linux.dev, linux-block@vger.kernel.org
Subject: Re: convert newly added dm-zone code to the atomic queue commit API
Date: Fri, 24 May 2024 11:17:47 -0400 [thread overview]
Message-ID: <ZlCvm3_PpaNmPa0q@kernel.org> (raw)
In-Reply-To: <20240524142929.817565-1-hch@lst.de>
On Fri, May 24, 2024 at 04:29:08PM +0200, Christoph Hellwig wrote:
> Hi all,
>
> the new dm-zone code added by Damien in 6.10-rc directly modifies the
> queue limits instead of using the commit-style API that dm has used
> forever and that the block layer adopted now, and thus can only run
> after all the other changes have been commited. This is quite a land
> mine and can be easily fixed.
>
> Note that if this doesn't go into 6.10-rc we'll need a way to get this
> in before more block work in this area for 6.11, i.e. probably through
> the block tree.
>
> Diffstat:
> dm-table.c | 19 +++++++---------
> dm-zone.c | 72 +++++++++++++++++++++++++++----------------------------------
> dm.h | 3 +-
> 3 files changed, 44 insertions(+), 50 deletions(-)
Found a couple issues/questions in patches 1 and 3.
But once all looks good: I'm fine with these changes going through
Jens for 6.10-rc (especially in that all DM's zoned changes for 6.10
were merged through block anyway).
Mike
prev parent reply other threads:[~2024-05-24 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 14:29 convert newly added dm-zone code to the atomic queue commit API Christoph Hellwig
2024-05-24 14:29 ` [PATCH 1/3] dm: move setting zoned_enabled to dm_table_set_restrictions Christoph Hellwig
2024-05-24 15:07 ` Mike Snitzer
2024-05-24 16:40 ` Christoph Hellwig
2024-05-24 14:29 ` [PATCH 2/3] dm: remove dm_check_zoned Christoph Hellwig
2024-05-24 15:09 ` Mike Snitzer
2024-05-24 14:29 ` [PATCH 3/3] dm: make dm_set_zones_restrictions work on the queue limits Christoph Hellwig
2024-05-24 15:15 ` Mike Snitzer
2024-05-24 16:41 ` Christoph Hellwig
2024-05-24 15:17 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlCvm3_PpaNmPa0q@kernel.org \
--to=snitzer@kernel.org \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.